{"html_url": "https://github.com/simonw/datasette/issues/167#issuecomment-350516782", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/167", "id": 350516782, "node_id": "MDEyOklzc3VlQ29tbWVudDM1MDUxNjc4Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-12-10T00:48:54Z", "updated_at": "2017-12-10T00:48:54Z", "author_association": "OWNER", "body": "I can simplify this all by dropping the nicety where if a table is using a rowid the Link column is titled rowid instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 280315352, "label": "Nasty bug: last column not being correctly displayed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/167#issuecomment-350515985", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/167", "id": 350515985, "node_id": "MDEyOklzc3VlQ29tbWVudDM1MDUxNTk4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-12-10T00:28:39Z", "updated_at": "2017-12-10T00:28:39Z", "author_association": "OWNER", "body": "A better alternative:\r\n\r\n```async def display_columns_and_rows(self, database, table, rows, link_column=False):```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 280315352, "label": "Nasty bug: last column not being correctly displayed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/167#issuecomment-350515616", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/167", "id": 350515616, "node_id": "MDEyOklzc3VlQ29tbWVudDM1MDUxNTYxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-12-10T00:21:58Z", "updated_at": "2017-12-10T00:21:58Z", "author_association": "OWNER", "body": "This function signature is pretty gross: https://github.com/simonw/datasette/blob/7a7e4b2ed8c76c6d002a9d707dbc840f6a2abf7f/datasette/app.py#L418", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 280315352, "label": "Nasty bug: last column not being correctly displayed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/167#issuecomment-350424595", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/167", "id": 350424595, "node_id": "MDEyOklzc3VlQ29tbWVudDM1MDQyNDU5NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-12-09T05:08:27Z", "updated_at": "2017-12-09T05:08:27Z", "author_association": "OWNER", "body": "Perhaps the row.html and table.html templates should be passed the same data but should themselves decide if they will display the Link column ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 280315352, "label": "Nasty bug: last column not being correctly displayed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/167#issuecomment-350421661", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/167", "id": 350421661, "node_id": "MDEyOklzc3VlQ29tbWVudDM1MDQyMTY2MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-12-09T03:52:46Z", "updated_at": "2017-12-09T03:52:46Z", "author_association": "OWNER", "body": "Input: results from the database, foreign key definitions, primary key definitions, type of page\r\n\r\nOutput: display_columns and display_rows", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 280315352, "label": "Nasty bug: last column not being correctly displayed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/167#issuecomment-350125953", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/167", "id": 350125953, "node_id": "MDEyOklzc3VlQ29tbWVudDM1MDEyNTk1Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-12-07T23:25:28Z", "updated_at": "2017-12-07T23:25:28Z", "author_association": "OWNER", "body": "My column/row HTML display logic has got way too convoluted. This is a sign I need to add proper unit tests for it and clean it up.\r\n\r\nThe complexity comes from:\r\n\r\n* Displaying a rowid for tables that do not have a primary key\r\n* Showing an additional Link column for rows with a primary key\r\n* Not displaying that Link column on the individual row pages\r\n* Trying to get foreign keys working correctly in all cases, e.g. #152 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 280315352, "label": "Nasty bug: last column not being correctly displayed"}, "performed_via_github_app": null}