{"html_url": "https://github.com/simonw/datasette/pull/209#issuecomment-382210976", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/209", "id": 382210976, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MjIxMDk3Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-18T01:12:26Z", "updated_at": "2018-04-18T01:12:26Z", "author_association": "OWNER", "body": "OK, aaf59db570ab7688af72c08bb5bc1edc145e3e07 should mean that the tests pass when I merge that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314455877, "label": " Don't duplicate simple primary keys in the link column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/209#issuecomment-382205189", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/209", "id": 382205189, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MjIwNTE4OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-18T00:42:44Z", "updated_at": "2018-04-18T00:43:02Z", "author_association": "OWNER", "body": "I managed to get a better error message out of that test. The server is returning this (but only on Python 3.6, not on Python 3.5 - and only in Travis, not in my local environment):\r\n\r\n```{'error': 'interrupted', 'ok': False, 'status': 400, 'title': 'Invalid SQL'}```\r\n\r\nhttps://travis-ci.org/simonw/datasette/jobs/367929134", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314455877, "label": " Don't duplicate simple primary keys in the link column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/209#issuecomment-381905593", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/209", "id": 381905593, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTkwNTU5Mw==", "user": {"value": 45057, "label": "russss"}, "created_at": "2018-04-17T08:50:28Z", "updated_at": "2018-04-17T08:50:28Z", "author_association": "CONTRIBUTOR", "body": "I've added another commit which puts classes a class on each `<td>` by default with its column name, and I've also made the PK column bold.\r\n\r\nUnfortunately the tests are still failing on 3.6, which is weird. I can't reproduce locally...", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314455877, "label": " Don't duplicate simple primary keys in the link column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/209#issuecomment-381738137", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/209", "id": 381738137, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTczODEzNw==", "user": {"value": 45057, "label": "russss"}, "created_at": "2018-04-16T20:27:43Z", "updated_at": "2018-04-16T20:27:43Z", "author_association": "CONTRIBUTOR", "body": "Tests now fixed, honest. The failing test on Travis looks like an intermittent sqlite failure which should resolve itself on a retry...", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314455877, "label": " Don't duplicate simple primary keys in the link column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/209#issuecomment-381483301", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/209", "id": 381483301, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTQ4MzMwMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-16T05:25:08Z", "updated_at": "2018-04-16T05:25:08Z", "author_association": "OWNER", "body": "I think this is a good improvement. If you fix the tests I'll merge it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314455877, "label": " Don't duplicate simple primary keys in the link column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/209#issuecomment-381441392", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/209", "id": 381441392, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTQ0MTM5Mg==", "user": {"value": 45057, "label": "russss"}, "created_at": "2018-04-15T21:59:15Z", "updated_at": "2018-04-15T21:59:15Z", "author_association": "CONTRIBUTOR", "body": "I suspected this would cause some test failures, but I'll wait for opinions before attempting to fix them.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314455877, "label": " Don't duplicate simple primary keys in the link column"}, "performed_via_github_app": null}