{"html_url": "https://github.com/simonw/datasette/pull/257#issuecomment-388628966", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/257", "id": 388628966, "node_id": "MDEyOklzc3VlQ29tbWVudDM4ODYyODk2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-13T14:00:47Z", "updated_at": "2018-05-13T14:06:35Z", "author_association": "OWNER", "body": "Running specific tests:\r\n```\r\nvenv35/bin/pip install pytest beautifulsoup4 aiohttp\r\nvenv35/bin/pytest tests/test_utils.py\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 322591993, "label": "Refactor views"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/257#issuecomment-388627281", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/257", "id": 388627281, "node_id": "MDEyOklzc3VlQ29tbWVudDM4ODYyNzI4MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-13T13:36:21Z", "updated_at": "2018-05-13T13:36:21Z", "author_association": "OWNER", "body": "https://github.com/rtfd/readthedocs.org/issues/3812#issuecomment-373780860 suggests Python 3.5.2 may have the fix.\r\n\r\nYup, that worked:\r\n\r\n```\r\npyenv install 3.5.2\r\nrm -rf venv35\r\n/Users/simonw/.pyenv/versions/3.5.2/bin/python -mvenv venv35\r\nsource venv35/bin/activate\r\n# Not sure why I need this in my local environment but I do:\r\npip install datasette_plugin_demos\r\npython setup.py test\r\n```\r\n\r\nThis is now giving me the same test failure locally that I am seeing in Travis.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 322591993, "label": "Refactor views"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/257#issuecomment-388626804", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/257", "id": 388626804, "node_id": "MDEyOklzc3VlQ29tbWVudDM4ODYyNjgwNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-13T13:28:20Z", "updated_at": "2018-05-13T13:28:20Z", "author_association": "OWNER", "body": "Unfortunately, running `python setup.py test` on my laptop using Python 3.5.0 in that virtualenv results in a flow of weird Sanic-related errors:\r\n\r\n```\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv35/lib/python3.5/site-packages/sanic-0.7.0-py3.5.egg/sanic/testing.py\", line 16, in _local_request\r\n    import aiohttp\r\n  File \"/Users/simonw/Dropbox/Development/datasette/.eggs/aiohttp-2.3.2-py3.5-macosx-10.13-x86_64.egg/aiohttp/__init__.py\", line 6, in <module>\r\n    from .client import *  # noqa\r\n  File \"/Users/simonw/Dropbox/Development/datasette/.eggs/aiohttp-2.3.2-py3.5-macosx-10.13-x86_64.egg/aiohttp/client.py\", line 13, in <module>\r\n    from yarl import URL\r\n  File \"/Users/simonw/Dropbox/Development/datasette/.eggs/yarl-1.2.4-py3.5-macosx-10.13-x86_64.egg/yarl/__init__.py\", line 11, in <module>\r\n    from .quoting import _Quoter, _Unquoter\r\n  File \"/Users/simonw/Dropbox/Development/datasette/.eggs/yarl-1.2.4-py3.5-macosx-10.13-x86_64.egg/yarl/quoting.py\", line 3, in <module>\r\n    from typing import Optional, TYPE_CHECKING, cast\r\nImportError: cannot import name 'TYPE_CHECKING'\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 322591993, "label": "Refactor views"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/257#issuecomment-388626721", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/257", "id": 388626721, "node_id": "MDEyOklzc3VlQ29tbWVudDM4ODYyNjcyMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-13T13:27:04Z", "updated_at": "2018-05-13T13:27:04Z", "author_association": "OWNER", "body": "I managed to get Python 3.5.0 running on my laptop using [pyenv](https://github.com/pyenv/pyenv). Here's the incantation I used:\r\n\r\n```\r\n# Install pyenv using homebrew (turns out I already had it)\r\nbrew install pyenv\r\n# Check which versions of Python I have installed\r\npyenv versions\r\n# Install Python 3.5.0\r\npyenv install 3.5.0\r\n# Figure out where pyenv has been installing things\r\npyenv root\r\n# Check I can run my newly installed Python 3.5.0\r\n/Users/simonw/.pyenv/versions/3.5.0/bin/python\r\n# Use it to create a new virtualenv\r\n/Users/simonw/.pyenv/versions/3.5.0/bin/python -mvenv venv35\r\nsource venv35/bin/activate\r\n# Install datasette into that virtualenv\r\npython setup.py install\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 322591993, "label": "Refactor views"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/257#issuecomment-388625703", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/257", "id": 388625703, "node_id": "MDEyOklzc3VlQ29tbWVudDM4ODYyNTcwMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-13T13:10:09Z", "updated_at": "2018-05-13T13:10:09Z", "author_association": "OWNER", "body": "I'm still seeing intermittent Python 3.5 failures due to dictionary ordering differences.\r\n\r\nhttps://travis-ci.org/simonw/datasette/jobs/378356802\r\n\r\n```\r\n>       assert expected_facet_results == facet_results\r\nE       AssertionError: assert {'city': [{'c...alue': 'MI'}]} == {'city': [{'co...alue': 'MI'}]}\r\nE         Omitting 1 identical items, use -vv to show\r\nE         Differing items:\r\nE         {'city': [{'count': 4, 'toggle_url': '_facet=state&_facet=city&state=MI&city=Detroit', 'value': 'Detroit'}]} != {'city': [{'count': 4, 'toggle_url': 'state=MI&_facet=state&_facet=city&city=Detroit', 'value': 'Detroit'}]}\r\nE         Use -v to get the full diff\r\n```\r\n\r\nTo solve these cleanly I need to be able to run Python 3.5 on my local laptop rather than relying on Travis every time.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 322591993, "label": "Refactor views"}, "performed_via_github_app": null}