{"html_url": "https://github.com/simonw/datasette/issues/333#issuecomment-407267966", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/333", "id": 407267966, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNzI2Nzk2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-24T03:21:42Z", "updated_at": "2018-07-24T03:21:42Z", "author_association": "OWNER", "body": "Demo: https://700d83d.datasette.io/fixtures-dcc1dbf/facetable.json?_facet=state&_size=5&_labels=on", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 338768551, "label": "Datasette on Zeit Now returns http URLs for facet and next links"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/333#issuecomment-407109113", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/333", "id": 407109113, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNzEwOTExMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-23T15:59:02Z", "updated_at": "2018-07-23T15:59:02Z", "author_association": "OWNER", "body": "I still need to modify `datasette publish now` to set this config option on the instances that it deploys.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 338768551, "label": "Datasette on Zeit Now returns http URLs for facet and next links"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/333#issuecomment-405988035", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/333", "id": 405988035, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNTk4ODAzNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-18T16:12:35Z", "updated_at": "2018-07-18T16:12:35Z", "author_association": "OWNER", "body": "I'll add a `absolute_url(request, path)` method on the base view class which knows to check the new config option.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 338768551, "label": "Datasette on Zeit Now returns http URLs for facet and next links"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/333#issuecomment-405975025", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/333", "id": 405975025, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNTk3NTAyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-18T15:36:11Z", "updated_at": "2018-07-18T15:40:04Z", "author_association": "OWNER", "body": "A `force_https_api_urls` config option would work here - if set, Datasette will ignore the incoming protocol and always use https. The `datasette deploy now` command could then add that as an option passed to `datasette serve`.\r\n\r\nThis is the pattern which is producing incorrect URLs on Zeit Now, because the Sanic `request.url` property is not being correctly set.\r\n\r\nhttps://github.com/simonw/datasette/blob/6e37f091edec35e2706197489f54fff5d890c63c/datasette/views/table.py#L653-L655\r\n\r\nSuggested help text:\r\n\r\n> Always use https:// for URLs output as part of Datasette API responses", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 338768551, "label": "Datasette on Zeit Now returns http URLs for facet and next links"}, "performed_via_github_app": null}