{"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-451415063", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 451415063, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MTQxNTA2Mw==", "user": {"value": 1727065, "label": "ltrgoddard"}, "created_at": "2019-01-04T11:04:08Z", "updated_at": "2019-01-04T11:04:08Z", "author_association": "NONE", "body": "Awesome - will get myself up and running on 0.26", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-451047426", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 451047426, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MTA0NzQyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-03T03:19:04Z", "updated_at": "2019-01-03T03:19:04Z", "author_association": "OWNER", "body": "https://fivethirtyeight.datasettes.com/-/versions is now running 0.26 - so your initial bug demo is now fixed: https://fivethirtyeight.datasettes.com/fivethirtyeight-c300360/classic-rock%2Fclassic-rock-song-list?Release+Year__exact=1989#export", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-451046123", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 451046123, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MTA0NjEyMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-03T03:05:07Z", "updated_at": "2019-01-03T03:05:07Z", "author_association": "OWNER", "body": "The fix was released as part of Datasette 0.26 - you can see the fix working here: https://v0-26.datasette.io/fixtures-dd88475/facetable?_facet=planet_int&planet_int=1#export", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-450944166", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 450944166, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MDk0NDE2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-02T18:32:12Z", "updated_at": "2019-01-02T18:32:12Z", "author_association": "OWNER", "body": "Here's the test that needs updating:\r\n\r\nhttps://github.com/simonw/datasette/blob/8b8ae55e7c8b9e1dceef53f55a330b596ca44d41/tests/test_html.py#L427-L435", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-450943632", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 450943632, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MDk0MzYzMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-02T18:30:20Z", "updated_at": "2019-01-02T18:30:20Z", "author_association": "OWNER", "body": "This is the code which is meant to add those options as hidden form fields:\r\n\r\nhttps://github.com/simonw/datasette/blob/fe5b6ea95a973534fe8a44907c0ea2449aae7602/datasette/templates/table.html#L150-L155\r\n\r\nIt's clearly not working. Need to fix this and add a corresponding unit test.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-450943172", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 450943172, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MDk0MzE3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-02T18:28:43Z", "updated_at": "2019-01-02T18:28:43Z", "author_association": "OWNER", "body": "Definitely a bug, thanks.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null}