{"html_url": "https://github.com/simonw/datasette/pull/404#issuecomment-552735296", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/404", "id": 552735296, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjczNTI5Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T05:02:13Z", "updated_at": "2019-11-12T05:02:13Z", "author_association": "OWNER", "body": "Closing this because it was written against Sanic. #628 tracks future work on this topic.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 403499298, "label": "Experiment: run Jinja in async mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/404#issuecomment-552276277", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/404", "id": 552276277, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjI3NjI3Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-11T03:13:09Z", "updated_at": "2019-11-11T03:13:09Z", "author_association": "OWNER", "body": "#622 will drop 3.5 support.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 403499298, "label": "Experiment: run Jinja in async mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/404#issuecomment-457976864", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/404", "id": 457976864, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1Nzk3Njg2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-28T01:56:55Z", "updated_at": "2019-01-28T01:56:55Z", "author_association": "OWNER", "body": "This failed in Python 3.5:\r\n\r\n```\r\n  File \"/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/jinja2/environment.py\", line 1020, in render_async\r\n    raise NotImplementedError('This feature is not available for this '\r\nNotImplementedError: This feature is not available for this version of Python\r\n```\r\n\r\nIt looks like this is caused by this feature detection code:\r\n\r\nhttps://github.com/pallets/jinja/blob/a7ba0b637805c53d442e975e3864d3ea38d8743f/jinja2/utils.py#L633-L638", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 403499298, "label": "Experiment: run Jinja in async mode"}, "performed_via_github_app": null}