{"html_url": "https://github.com/simonw/sqlite-utils/issues/17#issuecomment-466830869", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/17", "id": 466830869, "node_id": "MDEyOklzc3VlQ29tbWVudDQ2NjgzMDg2OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-02-24T23:45:48Z", "updated_at": "2019-02-24T23:45:48Z", "author_association": "OWNER", "body": "Both projects have been upgraded.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 413868452, "label": "Improve and document foreign_keys=... argument to insert/create/etc"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/17#issuecomment-466828503", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/17", "id": 466828503, "node_id": "MDEyOklzc3VlQ29tbWVudDQ2NjgyODUwMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-02-24T23:15:26Z", "updated_at": "2019-02-24T23:15:26Z", "author_association": "OWNER", "body": "Released: https://sqlite-utils.readthedocs.io/en/latest/changelog.html#v0-14", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 413868452, "label": "Improve and document foreign_keys=... argument to insert/create/etc"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/17#issuecomment-466827533", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/17", "id": 466827533, "node_id": "MDEyOklzc3VlQ29tbWVudDQ2NjgyNzUzMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-02-24T23:03:29Z", "updated_at": "2019-02-24T23:03:29Z", "author_association": "OWNER", "body": "Need to put out a new release of `sqlite-utils` so `db-to-sqlite` can depend on it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 413868452, "label": "Improve and document foreign_keys=... argument to insert/create/etc"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/17#issuecomment-466823422", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/17", "id": 466823422, "node_id": "MDEyOklzc3VlQ29tbWVudDQ2NjgyMzQyMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-02-24T22:20:05Z", "updated_at": "2019-02-24T22:20:05Z", "author_association": "OWNER", "body": "Re-opening this until I've fixed the other two projects.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 413868452, "label": "Improve and document foreign_keys=... argument to insert/create/etc"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/17#issuecomment-466821200", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/17", "id": 466821200, "node_id": "MDEyOklzc3VlQ29tbWVudDQ2NjgyMTIwMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-02-24T21:55:08Z", "updated_at": "2019-02-24T21:55:54Z", "author_association": "OWNER", "body": "This involves a breaking API change. I need to call that out in the README and also fix my two other projects which use the old four-tuple version of `foreign_keys=`:\r\n\r\nhttps://github.com/simonw/db-to-sqlite/blob/c2f8e93bc6bbdfd135de3656ea0f497859ae49ff/db_to_sqlite/cli.py#L30-L42\r\n\r\nAnd\r\n\r\nhttps://github.com/simonw/russian-ira-facebook-ads-datasette/blob/e7106710abdd7bdcae035bedd8bdaba75ae56a12/fetch_and_build_russian_ads.py#L71-L74\r\n\r\nI'll also need to set a minimum version for `sqlite-utils` in the `db-to-sqlite` setup.py:\r\n\r\nhttps://github.com/simonw/db-to-sqlite/blob/c2f8e93bc6bbdfd135de3656ea0f497859ae49ff/setup.py#L25", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 413868452, "label": "Improve and document foreign_keys=... argument to insert/create/etc"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/17#issuecomment-466820188", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/17", "id": 466820188, "node_id": "MDEyOklzc3VlQ29tbWVudDQ2NjgyMDE4OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-02-24T21:42:50Z", "updated_at": "2019-02-24T21:42:50Z", "author_association": "OWNER", "body": "Sanity checking those foreign keys would be worthwhile.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 413868452, "label": "Improve and document foreign_keys=... argument to insert/create/etc"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/17#issuecomment-466820167", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/17", "id": 466820167, "node_id": "MDEyOklzc3VlQ29tbWVudDQ2NjgyMDE2Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-02-24T21:42:33Z", "updated_at": "2019-02-24T21:42:33Z", "author_association": "OWNER", "body": "It looks like the type information isn't actually used for anything at all, so this:\r\n\r\nhttps://github.com/simonw/sqlite-utils/blob/f8d3b7cfe5c1950b0749d40eb2640df50b52f651/tests/test_create.py#L97-L103\r\n\r\nCould actually be written like this:\r\n\r\n```\r\n    fresh_db[\"m2m\"].insert(\r\n        {\"one_id\": 1, \"two_id\": 1},\r\n        foreign_keys=(\r\n            (\"one_id\", \"one\", \"id\"),\r\n            (\"two_id\", \"two\", \"id\"),\r\n        ),\r\n)\r\n```\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 413868452, "label": "Improve and document foreign_keys=... argument to insert/create/etc"}, "performed_via_github_app": null}