{"html_url": "https://github.com/simonw/datasette/issues/435#issuecomment-491541721", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/435", "id": 491541721, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MTU0MTcyMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-11T20:32:21Z", "updated_at": "2019-05-11T20:32:21Z", "author_association": "OWNER", "body": "Demo of the finished feature: https://latest.datasette.io/fixtures/facetable?_trace=1\r\n\r\n<img width=\"1294\" alt=\"image\" src=\"https://user-images.githubusercontent.com/9599/57574617-2ebd9600-73f1-11e9-9a1a-458f1b7d0d66.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 435531034, "label": "Tracing support for seeing what SQL queries were executed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/435#issuecomment-491534162", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/435", "id": 491534162, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MTUzNDE2Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-11T18:33:02Z", "updated_at": "2019-05-11T18:36:33Z", "author_association": "OWNER", "body": "I don't like the shape of the JSON:\r\n\r\n```\r\n  \"_traces\": {\r\n    \"num_traces\": 20,\r\n    \"traces\": {\r\n      \"duration\": 0.015190839767456055,\r\n      \"queries\": [\r\n        [\r\n          \"sql\",\r\n          [\r\n            \"fixtures\",\r\n            \"select 1 from sqlite_master where type='table' and name=?\",\r\n            [\r\n              \"facetable.json\"\r\n            ]\r\n          ],\r\n          1557599406.7231224,\r\n          1557599406.723611,\r\n          0.4887580871582031\r\n        ],\r\n        [\r\n```\r\n\r\nI want this instead:\r\n\r\n```\r\n  \"_traces\": {\r\n    \"num_traces\": 20,\r\n    \"sum_duration_ms\": 0.015190839767456055,\r\n    \"traces\": [\r\n      {\r\n        \"type\": \"sql\",\r\n        \"database\": \"fixtures\",\r\n        \"sql\": \"select 1 from sqlite_master where type='table' and name=?\",\r\n        \"args\": [\"facetable.json\"],\r\n        \"start\": 1557599406.7231224,\r\n        \"end\": 1557599406.723611,\r\n        \"duration_ms\": 0.4887580871582031\r\n      }", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 435531034, "label": "Tracing support for seeing what SQL queries were executed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/435#issuecomment-485270230", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/435", "id": 485270230, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4NTI3MDIzMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-04-21T17:52:03Z", "updated_at": "2019-04-21T17:52:03Z", "author_association": "OWNER", "body": "Demos:\r\n\r\n* https://latest.datasette.io/fixtures/facetable?_trace=1 - SQL dumped at bottom of HTML\r\n* https://latest.datasette.io/fixtures/facetable.json?_trace=1 - SQL in a \"_traces\" key\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 435531034, "label": "Tracing support for seeing what SQL queries were executed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/435#issuecomment-485269362", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/435", "id": 485269362, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4NTI2OTM2Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-04-21T17:38:05Z", "updated_at": "2019-04-21T17:38:05Z", "author_association": "OWNER", "body": "I built a first version of this in https://github.com/simonw/datasette/commit/7d01ca34a10b5f8a993859cfd05790eb2870b94e which dumped SQL queries out to the terminal logs.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 435531034, "label": "Tracing support for seeing what SQL queries were executed"}, "performed_via_github_app": null}