{"html_url": "https://github.com/simonw/sqlite-utils/pull/57#issuecomment-527266798", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/57", "id": 527266798, "node_id": "MDEyOklzc3VlQ29tbWVudDUyNzI2Njc5OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-09-03T01:03:59Z", "updated_at": "2019-09-03T01:03:59Z", "author_association": "OWNER", "body": "Released in 1.11 - thanks again! https://sqlite-utils.readthedocs.io/en/latest/changelog.html#v1-11", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 487987958, "label": "Add triggers while enabling FTS"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/57#issuecomment-527258212", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/57", "id": 527258212, "node_id": "MDEyOklzc3VlQ29tbWVudDUyNzI1ODIxMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-09-02T23:40:56Z", "updated_at": "2019-09-02T23:40:56Z", "author_association": "OWNER", "body": "This is fantastic, thanks so much.\r\n\r\nI spotted a Datasette bug triggered by this: Datasette has its own version of the `detect_fts` function - at https://github.com/simonw/datasette/blob/d224ee2c98ac39c2c6e21a0ac0c62e5c3e1ccd11/datasette/utils/__init__.py#L466-L479 - which fails to pick up FTS tables created using the new escaping pattern.\r\n\r\nIt's a bug in Datasette, not sqlite-utils - so I'll open an issue there.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 487987958, "label": "Add triggers while enabling FTS"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/57#issuecomment-527211047", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/57", "id": 527211047, "node_id": "MDEyOklzc3VlQ29tbWVudDUyNzIxMTA0Nw==", "user": {"value": 49260, "label": "amjith"}, "created_at": "2019-09-02T17:30:43Z", "updated_at": "2019-09-02T17:30:43Z", "author_association": "CONTRIBUTOR", "body": "I have merged the other PR (#56) into this one. \r\n\r\nI have incorporated your suggestions. Cheers!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 487987958, "label": "Add triggers while enabling FTS"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/57#issuecomment-527091278", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/57", "id": 527091278, "node_id": "MDEyOklzc3VlQ29tbWVudDUyNzA5MTI3OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-09-02T10:13:32Z", "updated_at": "2019-09-02T10:13:32Z", "author_association": "OWNER", "body": "This is brilliant!\r\n\r\nOne tiny suggestion: I like `--create-triggers` and `create_triggers=True` better for this as they are shorter but still capture what it dies - especially since the underlying SQL uses `CREATE TRIGGER` statements.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 487987958, "label": "Add triggers while enabling FTS"}, "performed_via_github_app": null}