{"html_url": "https://github.com/simonw/datasette/issues/611#issuecomment-548968034", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/611", "id": 548968034, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODk2ODAzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T22:11:33Z", "updated_at": "2019-11-01T22:11:33Z", "author_association": "OWNER", "body": "Or I could support both `with-hyphens` and `with_underscores` variants of the plugin names? That would provide a painless upgrade path - maybe this is something I could clean up in the backwards compatibility breaking 1.0 version?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 516370822, "label": "Static assets no longer loading for installed plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/611#issuecomment-548967774", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/611", "id": 548967774, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODk2Nzc3NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T22:10:31Z", "updated_at": "2019-11-01T22:10:31Z", "author_association": "OWNER", "body": "The alternative would be to ship brand new fixed versions of all of these plugins and have those fixes require a minimum release of Datasette.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 516370822, "label": "Static assets no longer loading for installed plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/611#issuecomment-548967432", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/611", "id": 548967432, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODk2NzQzMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T22:08:57Z", "updated_at": "2019-11-01T22:09:16Z", "author_association": "OWNER", "body": "Argh this is actually a bug in the already-shipped plugins themselves:\r\n\r\n```python\r\n@hookimpl\r\ndef extra_js_urls():\r\n    return [\r\n        {\r\n            \"url\": \"https://unpkg.com/leaflet@1.5.1/dist/leaflet.js\",\r\n            \"sri\": \"sha512-GffPMF3RvMeYyc1LWMHtK8EbPv0iNZ8/oTtHPx9/cc2ILxQ+u905qIwdpULaqDkyBKgOaB57QTMg7ztg8Jm2Og==\",\r\n        },\r\n        \"/-/static-plugins/datasette_leaflet_geojson/datasette-leaflet-geojson.js\",\r\n    ]\r\n```\r\nhttps://github.com/simonw/datasette-leaflet-geojson/blob/f8b5b1bd797b8c1b9a1771c259037dca258cce40/datasette_leaflet_geojson/__init__.py#L14-L22\r\n\r\nMaybe I should revert #606?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 516370822, "label": "Static assets no longer loading for installed plugins"}, "performed_via_github_app": null}