{"html_url": "https://github.com/simonw/datasette/issues/622#issuecomment-552745890", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/622", "id": 552745890, "node_id": "MDEyOklzc3VlQ29tbWVudDU1Mjc0NTg5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T05:52:49Z", "updated_at": "2019-11-12T05:52:49Z", "author_association": "OWNER", "body": "Released in [Datasette 0.31](https://datasette.readthedocs.io/en/latest/changelog.html#v0-31).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 520715188, "label": "Datasette should work with Python 3.8 (and drop compatibility with Python 3.5)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/622#issuecomment-552731544", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/622", "id": 552731544, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjczMTU0NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T04:41:48Z", "updated_at": "2019-11-12T04:41:48Z", "author_association": "OWNER", "body": "Here's where Python 3.5 started failing: https://travis-ci.org/simonw/datasette/builds/610682852", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 520715188, "label": "Datasette should work with Python 3.8 (and drop compatibility with Python 3.5)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/622#issuecomment-552730304", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/622", "id": 552730304, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjczMDMwNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T04:34:55Z", "updated_at": "2019-11-12T04:34:55Z", "author_association": "OWNER", "body": "Confirmed: upgrading to `uvicorn~=0.10.4` fixed it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 520715188, "label": "Datasette should work with Python 3.8 (and drop compatibility with Python 3.5)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/622#issuecomment-552729978", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/622", "id": 552729978, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjcyOTk3OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T04:33:00Z", "updated_at": "2019-11-12T04:33:00Z", "author_association": "OWNER", "body": "Here's the error I'm getting with Python 3.8 at the moment:\r\n```\r\n~/Dropbox/Development/datasette $ venv-py3.8.0/bin/datasette --memory -p 8055\r\nServe! files=() (immutables=()) on port 8055\r\nTraceback (most recent call last):\r\n  File \"venv-py3.8.0/bin/datasette\", line 11, in <module>\r\n    load_entry_point('datasette', 'console_scripts', 'datasette')()\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py\", line 764, in __call__\r\n    return self.main(*args, **kwargs)\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py\", line 717, in main\r\n    rv = self.invoke(ctx)\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py\", line 1137, in invoke\r\n    return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py\", line 956, in invoke\r\n    return ctx.invoke(self.callback, **ctx.params)\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py\", line 555, in invoke\r\n    return callback(*args, **kwargs)\r\n  File \"/Users/simonw/Dropbox/Development/datasette/datasette/cli.py\", line 365, in serve\r\n    uvicorn.run(ds.app(), host=host, port=port, log_level=\"info\")\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvicorn/main.py\", line 279, in run\r\n    server.run()\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvicorn/main.py\", line 305, in run\r\n    self.config.setup_event_loop()\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvicorn/config.py\", line 218, in setup_event_loop\r\n    loop_setup()\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvicorn/loops/auto.py\", line 3, in auto_loop_setup\r\n    import uvloop\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvloop/__init__.py\", line 7, in <module>\r\n    from .loop import Loop as __BaseLoop  # NOQA\r\n  File \"uvloop/includes/stdlib.pxi\", line 114, in init uvloop.loop\r\nAttributeError: module 'sys' has no attribute 'set_coroutine_wrapper'\r\n```\r\nI'm pretty confident upgrading uvicorn (and uvloop with it) will fix this.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 520715188, "label": "Datasette should work with Python 3.8 (and drop compatibility with Python 3.5)"}, "performed_via_github_app": null}