{"html_url": "https://github.com/simonw/datasette/issues/697#issuecomment-596266233", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/697", "id": 596266233, "node_id": "MDEyOklzc3VlQ29tbWVudDU5NjI2NjIzMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-08T23:33:28Z", "updated_at": "2020-03-08T23:33:28Z", "author_association": "OWNER", "body": "Shipped in [Datasette 0.38](https://datasette.readthedocs.io/en/latest/changelog.html#v0-38).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 577578306, "label": "index.html is not reliably loaded from a plugin"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/697#issuecomment-596264937", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/697", "id": 596264937, "node_id": "MDEyOklzc3VlQ29tbWVudDU5NjI2NDkzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-08T23:18:48Z", "updated_at": "2020-03-08T23:18:48Z", "author_association": "OWNER", "body": "Cancel that plan: I'm pretty sure the Travis configuration that publishes a demo to Zeit Now and builds a Docker image isn't designed to handle releases that don't correspond to current master. I guess I'll release 0.38 instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 577578306, "label": "index.html is not reliably loaded from a plugin"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/697#issuecomment-596264781", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/697", "id": 596264781, "node_id": "MDEyOklzc3VlQ29tbWVudDU5NjI2NDc4MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-08T23:17:01Z", "updated_at": "2020-03-08T23:17:01Z", "author_association": "OWNER", "body": "I'm going to release this as 0.37.2.\r\n\r\nThis is the first time I've released a version NOT from master (since I don't want to ship the `--memory` feature for Cloud Run until 0.38 - #694). So I've cut a `v0.37.2` release branch instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 577578306, "label": "index.html is not reliably loaded from a plugin"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/697#issuecomment-596262197", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/697", "id": 596262197, "node_id": "MDEyOklzc3VlQ29tbWVudDU5NjI2MjE5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-08T22:49:15Z", "updated_at": "2020-03-08T22:49:15Z", "author_association": "OWNER", "body": "I need that code to set `static_path` and `templates_path` to `None` for plugins that ship as part of Datasette.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 577578306, "label": "index.html is not reliably loaded from a plugin"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/697#issuecomment-596262118", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/697", "id": 596262118, "node_id": "MDEyOklzc3VlQ29tbWVudDU5NjI2MjExOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-08T22:48:28Z", "updated_at": "2020-03-08T22:48:28Z", "author_association": "OWNER", "body": "I think the bug is in this code:\r\nhttps://github.com/simonw/datasette/blob/7508477a96492caa1893c52411405656c50d30f9/datasette/utils/__init__.py#L619-L645", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 577578306, "label": "index.html is not reliably loaded from a plugin"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/697#issuecomment-596261973", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/697", "id": 596261973, "node_id": "MDEyOklzc3VlQ29tbWVudDU5NjI2MTk3Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-08T22:46:47Z", "updated_at": "2020-03-08T22:46:47Z", "author_association": "OWNER", "body": "More debugging code shows this:\r\n```\r\n[\r\n    (\r\n        {\r\n            \"name\": \"datasette.facets\",\r\n            \"static_path\": \"/Users/simonw/Dropbox/Development/datasette/datasette/static\",\r\n            \"templates_path\": \"/Users/simonw/Dropbox/Development/datasette/datasette/templates\",\r\n        },\r\n        \"/Users/simonw/Dropbox/Development/datasette/datasette/templates\",\r\n    ),\r\n    (\r\n        {\r\n            \"name\": \"datasette.sql_functions\",\r\n            \"static_path\": \"/Users/simonw/Dropbox/Development/datasette/datasette/static\",\r\n            \"templates_path\": \"/Users/simonw/Dropbox/Development/datasette/datasette/templates\",\r\n        },\r\n        \"/Users/simonw/Dropbox/Development/datasette/datasette/templates\",\r\n    ),\r\n    (\r\n        {\r\n            \"name\": \"datasette-search-all\",\r\n            \"static_path\": None,\r\n            \"templates_path\": \"/Users/simonw/Dropbox/Development/datasette-search-all/datasette_search_all/templates\",\r\n            \"version\": \"0.1\",\r\n        },\r\n        \"/Users/simonw/Dropbox/Development/datasette-search-all/datasette_search_all/templates\",\r\n    ),\r\n]\r\n```\r\nSo the problem is that the default plugins that ship with Datasette are adding a template path to the lookup list!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 577578306, "label": "index.html is not reliably loaded from a plugin"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/697#issuecomment-596261835", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/697", "id": 596261835, "node_id": "MDEyOklzc3VlQ29tbWVudDU5NjI2MTgzNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-08T22:45:03Z", "updated_at": "2020-03-08T22:45:03Z", "author_association": "OWNER", "body": "I think the bug is in this code:\r\nhttps://github.com/simonw/datasette/blob/7508477a96492caa1893c52411405656c50d30f9/datasette/app.py#L612-L623\r\nI added some debug logging to it and found that the bit that returns the `plugin[\"templates_path\"]` list is producing this:\r\n```\r\nplugin_template_paths: [\r\n  '/Users/simonw/Dropbox/Development/datasette/datasette/templates',\r\n  '/Users/simonw/Dropbox/Development/datasette/datasette/templates',\r\n  '/Users/simonw/Dropbox/Development/datasette-search-all/datasette_search_all/templates'\r\n]\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 577578306, "label": "index.html is not reliably loaded from a plugin"}, "performed_via_github_app": null}