{"html_url": "https://github.com/simonw/datasette/issues/724#issuecomment-612156367", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/724", "id": 612156367, "node_id": "MDEyOklzc3VlQ29tbWVudDYxMjE1NjM2Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-10T18:23:39Z", "updated_at": "2020-04-10T18:23:39Z", "author_association": "OWNER", "body": "I think I'll use https://github.com/clarketm/mergedeep (MIT license)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 598013965, "label": "--plugin-secret over-rides existing metadata.json plugin config"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/724#issuecomment-612155297", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/724", "id": 612155297, "node_id": "MDEyOklzc3VlQ29tbWVudDYxMjE1NTI5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-10T18:20:53Z", "updated_at": "2020-04-10T18:20:53Z", "author_association": "OWNER", "body": "Lot's of recipes for deep dictionary merge on https://stackoverflow.com/q/7204805/6083", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 598013965, "label": "--plugin-secret over-rides existing metadata.json plugin config"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/724#issuecomment-612154749", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/724", "id": 612154749, "node_id": "MDEyOklzc3VlQ29tbWVudDYxMjE1NDc0OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-10T18:19:31Z", "updated_at": "2020-04-10T18:19:31Z", "author_association": "OWNER", "body": "Actually that code isn't the problem, since `extra_metadata` has not yet been read from `metadata.json` at that point.\r\n\r\nThe bug is here: https://github.com/simonw/datasette/blob/d55fe8cdfc2ce7bc6960bf2507766c1fcd1d31a7/datasette/utils/__init__.py#L362-L368\r\n\r\nI need to merge dictionaries in a smarter way.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 598013965, "label": "--plugin-secret over-rides existing metadata.json plugin config"}, "performed_via_github_app": null}