{"html_url": "https://github.com/simonw/datasette/issues/770#issuecomment-634880090", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/770", "id": 634880090, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNDg4MDA5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-27T19:10:57Z", "updated_at": "2020-05-28T04:22:47Z", "author_association": "OWNER", "body": "This `can_render` callback should take the same arguments as the redesigned `render` (previously called `callback`): https://github.com/simonw/datasette/issues/581#issuecomment-634879258\r\n\r\n- `datasette` - a Datasette instance\r\n- `columns` - the list of columns\r\n- `rows` - the list of rows (each one a SQLite `Row` object)\r\n- `sql` - the SQL query being executed\r\n- `query_name` - the name of the canned query, if this is one\r\n- `database` - the database name\r\n- `table` - the table or view name\r\n- `request` - the request object (to be documented in #706)\r\n- `view_name` - the name of the view", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 625930207, "label": "register_output_renderer can_render mechanism"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/770#issuecomment-635056520", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/770", "id": 635056520, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTA1NjUyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T02:28:00Z", "updated_at": "2020-05-28T02:28:00Z", "author_association": "OWNER", "body": "This should be optionally awaitable, as in #776", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 625930207, "label": "register_output_renderer can_render mechanism"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/770#issuecomment-634980179", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/770", "id": 634980179, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNDk4MDE3OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-27T22:37:19Z", "updated_at": "2020-05-27T22:37:19Z", "author_association": "OWNER", "body": "Can I come up with a better name than `should_suggest`?\r\n\r\nIt's a check that sees if the current query is supported by the renderer plugin. Some options:\r\n\r\n- `can_render`\r\n- `supports_query`\r\n- `is_supported`\r\n\r\nI like `can_render`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 625930207, "label": "register_output_renderer can_render mechanism"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/770#issuecomment-634880474", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/770", "id": 634880474, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNDg4MDQ3NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-27T19:11:39Z", "updated_at": "2020-05-27T19:11:39Z", "author_association": "OWNER", "body": "I'm going to rename `callback` to `render` but continue supporting `callback` until Datasette 1.0.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 625930207, "label": "register_output_renderer can_render mechanism"}, "performed_via_github_app": null}