{"html_url": "https://github.com/simonw/datasette/issues/781#issuecomment-635494730", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/781", "id": 635494730, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTQ5NDczMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T17:39:54Z", "updated_at": "2020-05-28T17:39:54Z", "author_association": "OWNER", "body": "https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.niche-museums.com%2Fbrowse%2Ffeed.atom validates now!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626663119, "label": "request.url and request.scheme should obey force_https_urls config setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/781#issuecomment-635471007", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/781", "id": 635471007, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTQ3MTAwNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T16:58:47Z", "updated_at": "2020-05-28T16:58:47Z", "author_association": "OWNER", "body": "I'm inclined to do this at the earliest possible moment. I think that's probably in the `DatasetteRouter` class, which should see every `scope` first and be able to apply that setting to it. It already has some special case logic to deal with the `base_url` setting here:\r\n\r\nhttps://github.com/simonw/datasette/blob/40885ef24e32d91502b6b8bbad1c7376f50f2830/datasette/app.py#L779-L789", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626663119, "label": "request.url and request.scheme should obey force_https_urls config setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/781#issuecomment-635468994", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/781", "id": 635468994, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTQ2ODk5NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T16:55:35Z", "updated_at": "2020-05-28T16:55:35Z", "author_association": "OWNER", "body": "I think the right way to fix this is to modify the `scope[\"scheme\"]` ASGI key before the Request object is constructed - otherwise that Request class will have to gain knowledge of Datasette's configuration mechanism.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626663119, "label": "request.url and request.scheme should obey force_https_urls config setting"}, "performed_via_github_app": null}