{"html_url": "https://github.com/simonw/datasette/issues/823#issuecomment-641353186", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/823", "id": 641353186, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MTM1MzE4Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-09T14:58:36Z", "updated_at": "2020-06-09T14:58:36Z", "author_association": "OWNER", "body": "Docs now say:\r\n>  The actor dictionary can be any shape - the design of that data structure is left up to the plugins. A useful convention is to include an `\"id\"` string, as demonstrated by the \"root\" actor below.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 635107393, "label": "Documentation is inconsistent about \"id\" as required field on actor"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/823#issuecomment-641059221", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/823", "id": 641059221, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MTA1OTIyMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-09T06:23:51Z", "updated_at": "2020-06-09T06:24:09Z", "author_association": "OWNER", "body": "I don't like the \"id\" requirement.\r\n\r\nI can think of plenty of situations where a unique ID might not be available:\r\n\r\n- auth against an external token - an email address or a phone number for example\r\n- auth using encrypted tokens - where decrypting the token tells you exactly what permissions that token should have, like in https://blog.thea.codes/building-a-stateless-api-proxy/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 635107393, "label": "Documentation is inconsistent about \"id\" as required field on actor"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/823#issuecomment-641025760", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/823", "id": 641025760, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MTAyNTc2MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-09T04:48:40Z", "updated_at": "2020-06-09T04:48:40Z", "author_association": "OWNER", "body": "I should assert that `\"id\"` exists and is a string in the code that calls the `actor_from_request` hook.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 635107393, "label": "Documentation is inconsistent about \"id\" as required field on actor"}, "performed_via_github_app": null}