{"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643681747", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643681747, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzY4MTc0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T21:38:46Z", "updated_at": "2020-06-13T21:38:46Z", "author_association": "OWNER", "body": "Closing this because I've researched feasibility. I may start a milestone in the future to help me get to 100%.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643661125", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643661125, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzY2MTEyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T18:35:30Z", "updated_at": "2020-06-13T18:36:50Z", "author_association": "OWNER", "body": "I ran export CODECOV_TOKEN=\"f7935cad...\", then ran this:\r\n```\r\ndatasette $ bash <(curl -s https://codecov.io/bash) \r\n _____ _\r\n / ____| | |\r\n| | ___ __| | ___ ___ _____ __\r\n| | / _ \\ / _` |/ _ \\/ __/ _ \\ \\ / /\r\n| |___| (_) | (_| | __/ (_| (_) \\ V /\r\n \\_____\\___/ \\__,_|\\___|\\___\\___/ \\_/\r\n Bash-20200602-f809a24\r\n\r\n\r\nx> No CI provider detected.\r\n Testing inside Docker? http://docs.codecov.io/docs/testing-with-docker\r\n Testing with Tox? https://docs.codecov.io/docs/python#section-testing-with-tox\r\n project root: .\r\n--> token set from env\r\n Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml\r\n==> Running gcov in . (disable via -X gcov)\r\n==> Searching for coverage reports in:\r\n + .\r\n -> Found 1 reports\r\n==> Detecting git/mercurial file structure\r\n==> Reading reports\r\n + ./coverage.xml bytes=139174\r\n==> Appending adjustments\r\n https://docs.codecov.io/docs/fixing-reports\r\n -> No adjustments found\r\n==> Gzipping contents\r\n==> Uploading reports\r\n url: https://codecov.io\r\n query: branch=master&commit=0e49842e227a0f1f69d48108c87d17fe0379e548&build=&build_url=&name=&tag=&slug=simonw%2Fdatasette&service=&flags=&pr=&job=\r\n -> Pinging Codecov\r\nhttps://codecov.io/upload/v4?package=bash-20200602-f809a24&token=secret&branch=master&commit=0e49842e227a0f1f69d48108c87d17fe0379e548&build=&build_url=&name=&tag=&slug=simonw%2Fdatasette&service=&flags=&pr=&job=\r\n -> Uploading\r\n -> View reports at https://codecov.io/github/simonw/datasette/commit/0e49842e227a0f1f69d48108c87d17fe0379e548\r\n```\r\nBut https://codecov.io/github/simonw/datasette/commit/0e49842e227a0f1f69d48108c87d17fe0379e548 is a 404, so it doesn't seem to have worked?\r\n\r\nUPDATE: It works now, took about 30 seconds before the report showed up at that URL.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643660757", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643660757, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzY2MDc1Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T18:32:20Z", "updated_at": "2020-06-13T18:32:20Z", "author_association": "OWNER", "body": "Looking at options for publishing coverage reports:\r\n\r\n* https://github.com/codecov/codecov-action\r\n* https://github.com/coveralls-clients/coveralls-python\r\n\r\nI'm going to try https://codecov.io/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643660427", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643660427, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzY2MDQyNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T18:29:30Z", "updated_at": "2020-06-13T18:29:36Z", "author_association": "OWNER", "body": "This one looks easy enough to fix:\r\n\r\n\"Coverage_for_datasette_actor_auth_cookie_py__84_\"", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643658036", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643658036, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzY1ODAzNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T18:08:13Z", "updated_at": "2020-06-13T18:08:13Z", "author_association": "OWNER", "body": "From digging through that report it looks like the majority stuff that isn't fully covered is corner-cases... which are the kind of things I really do want the tests to catch.\r\n\r\nI'm not entirely ready to commit to 100%, but I'm going to start digging through and seeing how close I can get. If I can get to 98% (I'm on 91% already) I may as well push all the way to 100.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643657287", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643657287, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzY1NzI4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T18:01:39Z", "updated_at": "2020-06-13T18:01:39Z", "author_association": "OWNER", "body": "Added `--cov-report html` and got this report: https://static.simonwillison.net/static/2020/htmlcov-issue-841/index.html", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643656053", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643656053, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzY1NjA1Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T17:50:34Z", "updated_at": "2020-06-13T17:50:34Z", "author_association": "OWNER", "body": "Added a `.coveragerc` file:\r\n```\r\n[run]\r\nomit = datasette/_version.py, datasette/utils/shutil_backport.py\r\n```\r\nAnd ran again: `pytest --cov=datasette --cov-config=.coveragerc`\r\n```\r\nName Stmts Miss Cover\r\n------------------------------------------------------\r\ndatasette/__init__.py 3 0 100%\r\ndatasette/__main__.py 3 3 0%\r\ndatasette/actor_auth_cookie.py 19 3 84%\r\ndatasette/app.py 499 27 95%\r\ndatasette/cli.py 157 45 71%\r\ndatasette/database.py 233 17 93%\r\ndatasette/default_permissions.py 39 0 100%\r\ndatasette/facets.py 209 24 89%\r\ndatasette/filters.py 122 7 94%\r\ndatasette/hookspecs.py 19 0 100%\r\ndatasette/inspect.py 37 23 38%\r\ndatasette/plugins.py 34 6 82%\r\ndatasette/publish/__init__.py 0 0 100%\r\ndatasette/publish/cloudrun.py 55 2 96%\r\ndatasette/publish/common.py 19 1 95%\r\ndatasette/publish/heroku.py 95 13 86%\r\ndatasette/renderer.py 63 4 94%\r\ndatasette/sql_functions.py 4 0 100%\r\ndatasette/tracer.py 85 16 81%\r\ndatasette/utils/__init__.py 503 31 94%\r\ndatasette/utils/asgi.py 253 25 90%\r\ndatasette/version.py 4 0 100%\r\ndatasette/views/__init__.py 0 0 100%\r\ndatasette/views/base.py 288 19 93%\r\ndatasette/views/database.py 120 2 98%\r\ndatasette/views/index.py 57 2 96%\r\ndatasette/views/special.py 72 16 78%\r\ndatasette/views/table.py 418 18 96%\r\n------------------------------------------------------\r\nTOTAL 3410 304 91%\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643655108", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643655108, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzY1NTEwOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T17:43:15Z", "updated_at": "2020-06-13T17:43:15Z", "author_association": "OWNER", "body": "Using https://pypi.org/project/pytest-cov/ and running `pytest --cov=datasette`:\r\n```\r\n---------- coverage: platform darwin, python 3.7.7-final-0 -----------\r\nName Stmts Miss Cover\r\n--------------------------------------------------------\r\ndatasette/__init__.py 3 0 100%\r\ndatasette/__main__.py 3 3 0%\r\ndatasette/_version.py 277 152 45%\r\ndatasette/actor_auth_cookie.py 19 3 84%\r\ndatasette/app.py 499 27 95%\r\ndatasette/cli.py 157 45 71%\r\ndatasette/database.py 233 17 93%\r\ndatasette/default_permissions.py 39 0 100%\r\ndatasette/facets.py 209 24 89%\r\ndatasette/filters.py 122 7 94%\r\ndatasette/hookspecs.py 19 0 100%\r\ndatasette/inspect.py 37 23 38%\r\ndatasette/plugins.py 34 6 82%\r\ndatasette/publish/__init__.py 0 0 100%\r\ndatasette/publish/cloudrun.py 55 2 96%\r\ndatasette/publish/common.py 19 1 95%\r\ndatasette/publish/heroku.py 95 13 86%\r\ndatasette/renderer.py 63 4 94%\r\ndatasette/sql_functions.py 4 0 100%\r\ndatasette/tracer.py 85 16 81%\r\ndatasette/utils/__init__.py 503 31 94%\r\ndatasette/utils/asgi.py 253 25 90%\r\ndatasette/utils/shutil_backport.py 44 40 9%\r\ndatasette/version.py 4 0 100%\r\ndatasette/views/__init__.py 0 0 100%\r\ndatasette/views/base.py 288 19 93%\r\ndatasette/views/database.py 120 2 98%\r\ndatasette/views/index.py 57 2 96%\r\ndatasette/views/special.py 72 16 78%\r\ndatasette/views/table.py 418 18 96%\r\n--------------------------------------------------------\r\nTOTAL 3731 496 87%\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/841#issuecomment-643576372", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/841", "id": 643576372, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MzU3NjM3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-13T06:08:34Z", "updated_at": "2020-06-13T06:08:34Z", "author_association": "OWNER", "body": "Starlette achieves this. https://github.com/encode/starlette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 638104520, "label": "Research feasibility of 100% test coverage"}, "performed_via_github_app": null}