{"html_url": "https://github.com/simonw/datasette/issues/938#issuecomment-674558631", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/938", "id": 674558631, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU1ODYzMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T18:10:23Z", "updated_at": "2020-08-16T18:10:23Z", "author_association": "OWNER", "body": "Documentation: https://github.com/simonw/datasette/blob/3a4c8ed36aa97211e46849d32a09f2f386f342dd/docs/plugin_hooks.rst#extra-template-vars-template-database-table-columns-view-name-request-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679700269, "label": "Pass columns to extra CSS/JS/etc plugin hooks"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/938#issuecomment-674551826", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/938", "id": 674551826, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU1MTgyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T17:07:57Z", "updated_at": "2020-08-16T17:07:57Z", "author_association": "OWNER", "body": "extra_tenplate_vars should he documented first and should be the only one to document the arguments and the async return feature. Others should refer back to it rather than duplicating that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679700269, "label": "Pass columns to extra CSS/JS/etc plugin hooks"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/938#issuecomment-674544691", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/938", "id": 674544691, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU0NDY5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T16:03:52Z", "updated_at": "2020-08-16T16:03:52Z", "author_association": "OWNER", "body": "Four plugin hooks need this extra `columns` argument:\r\n\r\n- `extra_css_urls(template, database, table, datasette)`\r\n- `extra_js_urls(template, database, table, datasette)`\r\n- `extra_body_script(template, database, table, view_name, datasette)`\r\n- `extra_template_vars(template, database, table, view_name, request, datasette)`\r\n\r\nIt's weird that these take different arguments. I should fix that too.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679700269, "label": "Pass columns to extra CSS/JS/etc plugin hooks"}, "performed_via_github_app": null}