{"html_url": "https://github.com/simonw/sqlite-utils/pull/174#issuecomment-698400790", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/174", "id": 698400790, "node_id": "MDEyOklzc3VlQ29tbWVudDY5ODQwMDc5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-24T14:59:50Z", "updated_at": "2020-09-24T14:59:50Z", "author_association": "OWNER", "body": "For reusing the lookup table: I'm going to raise an error if a lookup table exists but without the correct columns. The caller can then add those columns and try again.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707944044, "label": "Much, much faster extract() implementation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/174#issuecomment-698184166", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/174", "id": 698184166, "node_id": "MDEyOklzc3VlQ29tbWVudDY5ODE4NDE2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-24T08:01:07Z", "updated_at": "2020-09-24T08:01:07Z", "author_association": "OWNER", "body": "I may revert the now unnecessary undocumented tweaks to the `.update()` method made in 66d506587eba9f0715267d6560b97c1fa44cc781 as well.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707944044, "label": "Much, much faster extract() implementation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/174#issuecomment-698182656", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/174", "id": 698182656, "node_id": "MDEyOklzc3VlQ29tbWVudDY5ODE4MjY1Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-24T07:58:08Z", "updated_at": "2020-09-24T07:58:08Z", "author_association": "OWNER", "body": "The way the lookup table works here differs from the previous implementation. In the previous implementation the usage of `.lookup()` meant that an existing table would be modified to fit the new purpose. That no longer happens in this version. Need to make a design decision about how this should work.\r\n\r\nIt should definitely be possible to use an existing lookup table - imagine a database where several tables have a \"Departments\" column and we want to extract all of those values out to a single shared \"Departments\" table.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707944044, "label": "Much, much faster extract() implementation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/174#issuecomment-698182037", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/174", "id": 698182037, "node_id": "MDEyOklzc3VlQ29tbWVudDY5ODE4MjAzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-24T07:56:50Z", "updated_at": "2020-09-24T07:56:50Z", "author_association": "OWNER", "body": "I could also be a bit smarter about transaction handling. I think it may be possible to run this entire operation in a single transaction now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707944044, "label": "Much, much faster extract() implementation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/174#issuecomment-698181478", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/174", "id": 698181478, "node_id": "MDEyOklzc3VlQ29tbWVudDY5ODE4MTQ3OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-24T07:55:45Z", "updated_at": "2020-09-24T07:55:45Z", "author_association": "OWNER", "body": "`import functools` is no longer needed.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707944044, "label": "Much, much faster extract() implementation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/174#issuecomment-698180705", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/174", "id": 698180705, "node_id": "MDEyOklzc3VlQ29tbWVudDY5ODE4MDcwNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-24T07:54:10Z", "updated_at": "2020-09-24T07:54:10Z", "author_association": "OWNER", "body": "After running through the steps in https://simonwillison.net/2020/Sep/23/sqlite-utils-extract/ I get a table that looks like this:\r\n\r\n<img width=\"1699\" alt=\"salaries__salaries__683_558_rows\" src=\"https://user-images.githubusercontent.com/9599/94116875-666b8900-fe00-11ea-9e97-2b9ccbfeae29.png\">\r\n\r\nThe foreign key columns are all at the end of the table. It would be nicer if they were arranged in the same order as the columns they replaced.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707944044, "label": "Much, much faster extract() implementation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/174#issuecomment-698180113", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/174", "id": 698180113, "node_id": "MDEyOklzc3VlQ29tbWVudDY5ODE4MDExMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-24T07:53:03Z", "updated_at": "2020-09-24T07:53:03Z", "author_association": "OWNER", "body": "This could do with a little bit more testing - I'm worried there may be column or table name edge cases that are not covered yet. I also need to remove the progress bar code since that no longer makes sense for this implementation.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707944044, "label": "Much, much faster extract() implementation"}, "performed_via_github_app": null}