{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701668526", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701668526, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY2ODUyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T21:57:22Z", "updated_at": "2020-09-30T21:57:22Z", "author_association": "OWNER", "body": "A bunch of things to fix:\r\n\r\n- It clobbers existing querystring parameters - it needs to leave these alone (but replace the current sort order)\r\n- Facet option should not show up if you are already faceting by that column\r\n- There's no way to close the menu once it has opened!\r\n- Accessibility: SVG icon doesn't even have an alt attribute yet. Should use ARIA when the thing appears.\r\n\r\nIt's also not visible on mobile, need to think about how that will work.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701615291", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701615291, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTYxNTI5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T20:04:34Z", "updated_at": "2020-09-30T20:05:37Z", "author_association": "OWNER", "body": "Another potential action:\r\n\r\n* Show rows where this is not blank (equivalent to `is not blank` filter)\r\n\r\nThis could be displayed conditionally based on if the column is detected to have any blank rows in it?\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701679729", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701679729, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY3OTcyOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T22:26:33Z", "updated_at": "2020-09-30T22:26:33Z", "author_association": "OWNER", "body": "Bug: https://latest.datasette.io/fixtures/sortable?_sort=sortable\r\n\r\n![sort-bug](https://user-images.githubusercontent.com/9599/94746304-4e7c9380-0331-11eb-8e81-7245529c4654.gif)\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701153822", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701153822, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTE1MzgyMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T04:47:10Z", "updated_at": "2020-09-30T04:47:10Z", "author_association": "OWNER", "body": "Future version could have expanding out nested side menus that let you do things like \"calculate sum/avg for this column against this-other-column\".", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701697918", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701697918, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY5NzkxOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T23:24:14Z", "updated_at": "2020-09-30T23:25:28Z", "author_association": "OWNER", "body": "I could provide the \"Show non-blank values\" option only for columns where there are blank values visible on the current page.\r\n\r\nThis could be a bit confusing though, since the absence of that option could suggest that there are no blank values at all when that's actually not true.\r\n\r\nOne option: run a separate `fetch()` call that figures out if any of the columns contain blank values, which gets a bit of extra time to execute. Only show the \"Show non-blank values\" option in the menu once that has returned.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701642448", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701642448, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY0MjQ0OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T20:59:33Z", "updated_at": "2020-09-30T20:59:33Z", "author_association": "OWNER", "body": "I think I've got everything I need to implement this now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701153982", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701153982, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTE1Mzk4Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T04:47:54Z", "updated_at": "2020-09-30T04:47:54Z", "author_association": "OWNER", "body": "I think the accessible way to do this is with absolute positioning - have a menu icon in the `