{"html_url": "https://github.com/simonw/datasette/issues/1041#issuecomment-719986800", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1041", "id": 719986800, "node_id": "MDEyOklzc3VlQ29tbWVudDcxOTk4NjgwMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-31T20:49:28Z", "updated_at": "2020-10-31T20:49:28Z", "author_association": "OWNER", "body": "Implemented in a4ca26a2659d21779adf625183061d8879954c15", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 727627923, "label": "extra_js_urls and extra_css_urls should respect base_url setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1041#issuecomment-714683801", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1041", "id": 714683801, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDY4MzgwMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T18:37:47Z", "updated_at": "2020-10-22T18:37:47Z", "author_association": "OWNER", "body": "I think I'll do this by looking for URLs that start with `/` - since it's also possible to have full `https://...` URLs in that setting.\r\n```json\r\n{\r\n    \"extra_css_urls\": [\r\n        \"/static/styles.css\"\r\n    ],\r\n    \"extra_js_urls\": [\r\n        \"/static/app.js\"\r\n    ]\r\n}\r\n```\r\nI need to think about the `extra_css_urls` and `extra_js_urls` plugin hooks too: https://docs.datasette.io/en/stable/plugin_hooks.html#extra-css-urls-template-database-table-columns-view-name-request-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 727627923, "label": "extra_js_urls and extra_css_urls should respect base_url setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1041#issuecomment-714682825", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1041", "id": 714682825, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDY4MjgyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T18:36:10Z", "updated_at": "2020-10-22T18:36:10Z", "author_association": "OWNER", "body": "I'll need to update these docs once there's a solution for this in place: https://docs.datasette.io/en/latest/custom_templates.html#serving-static-files", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 727627923, "label": "extra_js_urls and extra_css_urls should respect base_url setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1041#issuecomment-714682288", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1041", "id": 714682288, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDY4MjI4OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T18:35:15Z", "updated_at": "2020-10-22T18:35:15Z", "author_association": "OWNER", "body": "@psychemedia said: https://github.com/simonw/datasette/issues/1033#issuecomment-714657366\r\n\r\n> How does `/-/static` relate to [current guidance docs around `static`](https://docs.datasette.io/en/latest/custom_templates.html?highlight=static#serving-static-files) regarding the `--static option` and metadata formulations such as `\"extra_js_urls\": [ \"/static/app.js\"]` (I've not managed to get this to work in a Jupyter server proxied set up; the [datasette / jupyter server proxy repo](https://github.com/simonw/jupyterserverproxy-datasette-demo) may provide a useful test example, eg via MyBinder, for folk to crib from?)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 727627923, "label": "extra_js_urls and extra_css_urls should respect base_url setting"}, "performed_via_github_app": null}