{"html_url": "https://github.com/simonw/datasette/pull/1049#issuecomment-718528252", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1049", "id": 718528252, "node_id": "MDEyOklzc3VlQ29tbWVudDcxODUyODI1Mg==", "user": {"value": 82988, "label": "psychemedia"}, "created_at": "2020-10-29T09:20:34Z", "updated_at": "2020-10-29T09:20:34Z", "author_association": "CONTRIBUTOR", "body": "That workaround is probably fine. I was trying to work out whether there might be other situations where a pre-external package load might be useful but couldn't offhand bring any other examples to mind. The static plugins option also looks interesting.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729017519, "label": "Add template block prior to extra URL loaders"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1049#issuecomment-718340847", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1049", "id": 718340847, "node_id": "MDEyOklzc3VlQ29tbWVudDcxODM0MDg0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-29T03:45:47Z", "updated_at": "2020-10-29T03:48:26Z", "author_association": "OWNER", "body": "[thebe](https://thebelab.readthedocs.io/en/latest/examples/minimal_example.html) is the first time I've seen a library that requires you to set up some global JavaScript configuration before loading the script itself.\r\n\r\nI'm hesitant to add an extra template block just to cover that one case since it's such a rare pattern. But it's important that `thebelab` can be used with Datasette.\r\n\r\nWould this pattern work for you instead?\r\n\r\n```html+jinja\r\n{% block extra_head %}\r\n<script type=\"text/x-thebe-config\">\r\n  {\r\n    requestKernel: true,\r\n    binderOptions: {\r\n      repo: \"binder-examples/requirements\",\r\n    },\r\n  }\r\n</script>\r\n<script src=\"https://unpkg.com/thebelab@latest/lib/index.js\"></script>\r\n{% endblock %}\r\n```\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729017519, "label": "Add template block prior to extra URL loaders"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1049#issuecomment-718341542", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1049", "id": 718341542, "node_id": "MDEyOklzc3VlQ29tbWVudDcxODM0MTU0Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-29T03:48:12Z", "updated_at": "2020-10-29T03:48:12Z", "author_association": "OWNER", "body": "You could use Datasette's new `{{ urls.static_plugins(...) }}` template option - see https://docs.datasette.io/en/latest/internals.html#internals-datasette-urls - to generate a link to code that was bundled with the plugin:\r\n\r\n```html+jinja\r\n{% block extra_head %}\r\n<script type=\"text/x-thebe-config\">\r\n  {\r\n    requestKernel: true,\r\n    binderOptions: {\r\n      repo: \"binder-examples/requirements\",\r\n    },\r\n  }\r\n</script>\r\n<script src=\"{{ urls.static_plugins(\"datasette-thebelab-plugin\", \"thebelab-index.js\")\"></script>\r\n{% endblock %}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729017519, "label": "Add template block prior to extra URL loaders"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1049#issuecomment-716146238", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1049", "id": 716146238, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNjE0NjIzOA==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2020-10-25T13:13:32Z", "updated_at": "2020-10-25T13:13:32Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1049?src=pr&el=h1) Report\n> Merging [#1049](https://codecov.io/gh/simonw/datasette/pull/1049?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/42f4851e3e7885f1092f104d6c883cea40b12f02?el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1049/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1049?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##             main    #1049   +/-   ##\n=======================================\n  Coverage   84.72%   84.72%           \n=======================================\n  Files          28       28           \n  Lines        3942     3942           \n=======================================\n  Hits         3340     3340           \n  Misses        602      602           \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1049?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute <relative> (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1049?src=pr&el=footer). Last update [42f4851...50a743a](https://codecov.io/gh/simonw/datasette/pull/1049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729017519, "label": "Add template block prior to extra URL loaders"}, "performed_via_github_app": null}