{"html_url": "https://github.com/simonw/sqlite-utils/pull/195#issuecomment-723148906", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/195", "id": 723148906, "node_id": "MDEyOklzc3VlQ29tbWVudDcyMzE0ODkwNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-06T15:43:51Z", "updated_at": "2020-11-06T15:43:51Z", "author_association": "OWNER", "body": "Thanks to #198 (introducing a `rank_bm25()` custom function for FTS4) this feature will be able to offer relevance search for both FTS5 AND FTS4 tables.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 735663855, "label": "table.search() improvements plus sqlite-utils search command"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/195#issuecomment-722542895", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/195", "id": 722542895, "node_id": "MDEyOklzc3VlQ29tbWVudDcyMjU0Mjg5NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-05T18:01:33Z", "updated_at": "2020-11-05T18:01:33Z", "author_association": "OWNER", "body": "Latest test failure:\r\n```\r\n114  ->\t        assert [(\"racoons are biting trash pandas\", \"USA\", \"bar\")] == table.search(\r\n115  \t            \"bite\", order=\"rowid\"\r\n116  \t        )\r\n117  \t\r\n118  \t\r\n119  \tdef test_optimize_fts(fresh_db):\r\n(Pdb) table.search(\"bite\")\r\n[(2, 'racoons are biting trash pandas', 'USA', 'bar', -9.641434262948206e-07)]\r\n```\r\nThe problem here is that the `table.search()` method now behaves differently for FTS4 v.s. FTS5 tables.\r\n\r\nWith FTS4 you get back just the table columns.\r\n\r\nWith FTS5 you also get back the `rowid` as the first column and the `rank` score as the last column.\r\n\r\nThis is weird. It also makes me question whether having `.search()` return a list of tuples is the right API design.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 735663855, "label": "table.search() improvements plus sqlite-utils search command"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/195#issuecomment-721397665", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/195", "id": 721397665, "node_id": "MDEyOklzc3VlQ29tbWVudDcyMTM5NzY2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-03T22:02:57Z", "updated_at": "2020-11-03T22:02:57Z", "author_association": "OWNER", "body": "Documentation so far: https://github.com/simonw/sqlite-utils/blob/6cadc6103ff1ba58c6409ce7fba74259e72965d9/docs/cli.rst#executing-searches", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 735663855, "label": "table.search() improvements plus sqlite-utils search command"}, "performed_via_github_app": null}