{"html_url": "https://github.com/simonw/datasette/issues/1107#issuecomment-733261501", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1107", "id": 733261501, "node_id": "MDEyOklzc3VlQ29tbWVudDczMzI2MTUwMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-24T22:09:11Z", "updated_at": "2020-11-24T22:09:11Z", "author_association": "OWNER", "body": "Documentation: https://docs.datasette.io/en/latest/internals.html#setting-key", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 750079085, "label": "Rename datasette.config() method to datasette.setting()"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1107#issuecomment-733257071", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1107", "id": 733257071, "node_id": "MDEyOklzc3VlQ29tbWVudDczMzI1NzA3MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-24T21:59:32Z", "updated_at": "2020-11-24T21:59:32Z", "author_association": "OWNER", "body": "I'm going to make this a documented method in https://docs.datasette.io/en/latest/internals.html#datasette-class", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 750079085, "label": "Rename datasette.config() method to datasette.setting()"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1107#issuecomment-733245097", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1107", "id": 733245097, "node_id": "MDEyOklzc3VlQ29tbWVudDczMzI0NTA5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-24T21:31:10Z", "updated_at": "2020-11-24T21:31:10Z", "author_association": "OWNER", "body": "Most of these use `plugin_config` which is unaffected. It looks like the only code I need to worry about is this trick in `datasette-graphl`: https://github.com/simonw/datasette-graphql/blob/483c9a9e203bb90365def3df8b8f01dda1e75865/datasette_graphql/utils.py#L456-L460\r\n\r\n```python\r\nclass DatasetteSpecialConfig(wrapt.ObjectProxy):\r\n    def config(self, key):\r\n        if key == \"suggest_facets\":\r\n            return False\r\n        return self.__wrapped__.config(key)\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 750079085, "label": "Rename datasette.config() method to datasette.setting()"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1107#issuecomment-733244471", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1107", "id": 733244471, "node_id": "MDEyOklzc3VlQ29tbWVudDczMzI0NDQ3MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-24T21:29:59Z", "updated_at": "2020-11-24T21:29:59Z", "author_association": "OWNER", "body": "I ran `rg '.config\\(' datasette-*/` in my top-level directory:\r\n```\r\ndatasette-sentry/test_datasette_sentry.py:    def plugin_config(self, name):\r\ndatasette-sentry/datasette_sentry.py:    config = datasette.plugin_config(\"datasette-sentry\") or {}\r\ndatasette-render-markdown/datasette_render_markdown/__init__.py:        datasette.plugin_config(\r\ndatasette-render-images/datasette_render_images.py:        plugin_config = datasette.plugin_config(\"datasette-render-images\") or {}\r\ndatasette-render-html/datasette_render_html.py:    config = datasette.plugin_config(\r\ndatasette-render-timestamps/datasette_render_timestamps/__init__.py:        datasette.plugin_config(\r\ndatasette-permissions-sql/datasette_permissions_sql/__init__.py:        for rule in datasette.plugin_config(\"datasette-permissions-sql\") or []:\r\ndatasette-mask-columns/datasette_mask_columns/__init__.py:            datasette.plugin_config(\"datasette-mask-columns\", database=database) or {}\r\ndatasette-mask-columns/datasette_mask_columns/__init__.py:    masks = datasette.plugin_config(\"datasette-mask-columns\", database=database) or {}\r\ndatasette-media/datasette_media/__init__.py:    plugin_config = datasette.plugin_config(\"datasette-media\") or {}\r\ndatasette-insert/datasette_insert/__init__.py:    plugin_config = datasette.plugin_config(\"datasette-insert\") or {}\r\ndatasette-indieauth/datasette_indieauth/__init__.py:    plugin_config = datasette.plugin_config(\"datasette-indieauth\") or {}\r\ndatasette-graphql/datasette_graphql/__init__.py:    config = datasette.plugin_config(\"datasette-graphql\") or {}\r\ndatasette-graphql/datasette_graphql/__init__.py:    config = datasette.plugin_config(\"datasette-graphql\") or {}\r\ndatasette-graphql/datasette_graphql/utils.py:            auto_camelcase=(datasette.plugin_config(\"datasette-graphql\") or {}).get(\r\ndatasette-graphql/datasette_graphql/utils.py:    table_plugin_config = datasette.plugin_config(\r\ndatasette-graphql/datasette_graphql/utils.py:    def config(self, key):\r\ndatasette-graphql/datasette_graphql/utils.py:        return self.__wrapped__.config(key)\r\ndatasette-init/datasette_init/__init__.py:        config = datasette.plugin_config(\"datasette-init\")\r\ndatasette-edit-templates/datasette_edit_templates/__init__.py:    plugin_config = datasette.plugin_config(\"datasette-edit-templates\") or {}\r\ndatasette-cors/datasette_cors.py:    config = datasette.plugin_config(\"datasette-cors\") or {}\r\ndatasette-cluster-map-old/build/lib/datasette_cluster_map/__init__.py:        datasette.plugin_config(\"datasette-cluster-map\", database=database, table=table)\r\ndatasette-cluster-map/datasette_cluster_map/__init__.py:        datasette.plugin_config(\"datasette-cluster-map\", database=database, table=table)\r\ndatasette-cluster-map/datasette_cluster_map/__init__.py:        datasette.plugin_config(\"datasette-cluster-map\", database=database, table=table)\r\ndatasette-cluster-map/tests/test_cluster_map.py:async def test_plugin_config(db_path, config, table, expected_fragments):\r\ndatasette-configure-asgi/datasette_configure_asgi.py:        configs = datasette.plugin_config(\"datasette-configure-asgi\") or []\r\ndatasette-configure-asgi/test_datasette_configure_asgi.py:    def plugin_config(self, name):\r\ndatasette-cluster-map-old/datasette_cluster_map/__init__.py:        datasette.plugin_config(\"datasette-cluster-map\", database=database, table=table)\r\ndatasette-auth-passwords/datasette_auth_passwords/__init__.py:    config = datasette.plugin_config(\"datasette-auth-passwords\") or {}\r\ndatasette-auth-github/datasette_auth_github/views.py:def verify_config(config):\r\ndatasette-auth-github/datasette_auth_github/views.py:    config = datasette.plugin_config(\"datasette-auth-github\")\r\ndatasette-auth-github/datasette_auth_github/views.py:    verify_config(config)\r\ndatasette-auth-github/datasette_auth_github/views.py:    config = datasette.plugin_config(\"datasette-auth-github\")\r\ndatasette-auth-github/datasette_auth_github/views.py:    verify_config(config)\r\ndatasette-atom/datasette_atom/__init__.py:        plugin_config = datasette.plugin_config(\"datasette-atom\")\r\ndatasette-auth-google/datasette_auth_google/__init__.py:    config = datasette.plugin_config(\"datasette-auth-github\") or {}\r\ndatasette-auth-existing-cookies/test_datasette_auth_existing_cookies.py:    def plugin_config(self, name):\r\ndatasette-auth-passwords/build/lib/datasette_auth_passwords/__init__.py:    config = datasette.plugin_config(\"datasette-auth-passwords\") or {}\r\ndatasette-annotate/datasette_annotate/utils.py:    plugin_config = datasette.plugin_config(\"datasette-annotate\") or {}\r\ndatasette-auth-existing-cookies/datasette_auth_existing_cookies/__init__.py:    config = datasette.plugin_config(\"datasette-auth-existing-cookies\") or {}\r\ndatasette-auth-simple/datasette_auth_simple/__init__.py:datasette.plugin_config(\"datasette-auth-simple\")\r\ndatasette-auth-tokens/datasette_auth_tokens/__init__.py:        config = datasette.plugin_config(\"datasette-auth-tokens\") or {}\r\ndatasette-block-robots/datasette_block_robots/__init__.py:    config = datasette.plugin_config(\"datasette-block-robots\") or {}\r\ndatasette-block-robots/datasette_block_robots/__init__.py:    config = datasette.plugin_config(\"datasette-block-robots\") or {}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 750079085, "label": "Rename datasette.config() method to datasette.setting()"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1107#issuecomment-733241949", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1107", "id": 733241949, "node_id": "MDEyOklzc3VlQ29tbWVudDczMzI0MTk0OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-24T21:24:26Z", "updated_at": "2020-11-24T21:24:26Z", "author_association": "OWNER", "body": "Are there any plugins that use this API even though it isn't documented?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 750079085, "label": "Rename datasette.config() method to datasette.setting()"}, "performed_via_github_app": null}