{"html_url": "https://github.com/simonw/datasette/issues/1337#issuecomment-849762735", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1337", "id": 849762735, "node_id": "MDEyOklzc3VlQ29tbWVudDg0OTc2MjczNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-27T16:14:14Z", "updated_at": "2021-05-27T16:14:14Z", "author_association": "OWNER", "body": "Here's a demo showing that once you get above 1,000 results you still get the \"...\" but it no longer links to anything: https://fivethirtyeight.datasettes.com/fivethirtyeight/births%2FUS_births_2000-2014_SSA?_facet=births&_facet_size=max", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 898904402, "label": "\"More\" link for facets that shows _facet_size=max results"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1337#issuecomment-849761508", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1337", "id": 849761508, "node_id": "MDEyOklzc3VlQ29tbWVudDg0OTc2MTUwOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-27T16:12:31Z", "updated_at": "2021-05-27T16:12:31Z", "author_association": "OWNER", "body": "More exciting demo: https://fivethirtyeight.datasettes.com/fivethirtyeight/antiquities-act%2Factions_under_antiquities_act?_facet=states&_facet=current_agency&_facet=pres_or_congress", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 898904402, "label": "\"More\" link for facets that shows _facet_size=max results"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1337#issuecomment-849759440", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1337", "id": 849759440, "node_id": "MDEyOklzc3VlQ29tbWVudDg0OTc1OTQ0MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-27T16:09:34Z", "updated_at": "2021-05-27T16:09:34Z", "author_association": "OWNER", "body": "Demo: https://latest.datasette.io/fixtures/facetable?_facet_size=2&_facet=state&_facet=city_id\r\n\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 898904402, "label": "\"More\" link for facets that shows _facet_size=max results"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1337#issuecomment-849725291", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1337", "id": 849725291, "node_id": "MDEyOklzc3VlQ29tbWVudDg0OTcyNTI5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-27T15:23:33Z", "updated_at": "2021-05-27T15:23:33Z", "author_association": "OWNER", "body": "Turns out `path_with_replaced_args()` is already exposed to the `table.html` template context: https://github.com/simonw/datasette/blob/f1c29fd6a184254aa68efadf096bcf21e848f921/datasette/views/table.py#L897-L900", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 898904402, "label": "\"More\" link for facets that shows _facet_size=max results"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1337#issuecomment-849721280", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1337", "id": 849721280, "node_id": "MDEyOklzc3VlQ29tbWVudDg0OTcyMTI4MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-27T15:18:08Z", "updated_at": "2021-05-27T15:18:08Z", "author_association": "OWNER", "body": "In order to cleanly implement this I need to expose the `path_with_replaced_args` utility function to Datasette's template engine. This is the first time this will become an exposed (and hence should-by-documented) API and I don't like its shape much.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 898904402, "label": "\"More\" link for facets that shows _facet_size=max results"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1337#issuecomment-849695117", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1337", "id": 849695117, "node_id": "MDEyOklzc3VlQ29tbWVudDg0OTY5NTExNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-27T14:44:13Z", "updated_at": "2021-05-27T14:44:13Z", "author_association": "OWNER", "body": "Here's a much easier way to implement this: implement `?_facet_size=max` (sets it to `max_returned_rows`, default 1000) and then link to that from the ellipsis.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 898904402, "label": "\"More\" link for facets that shows _facet_size=max results"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1337#issuecomment-846481896", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1337", "id": 846481896, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NjQ4MTg5Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-23T00:37:52Z", "updated_at": "2021-05-23T00:37:52Z", "author_association": "OWNER", "body": "The tricky thing about this is that ideally I'd like this to link to a paginated set of results - but arbitrary SQL queries do not yet support pagination, see #856.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 898904402, "label": "\"More\" link for facets that shows _facet_size=max results"}, "performed_via_github_app": null}