{"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896154028", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896154028, "node_id": "IC_kwDOCGYnMM41ajms", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T17:01:06Z", "updated_at": "2021-08-10T17:01:06Z", "author_association": "OWNER", "body": "On Python 3.6:\r\n\r\n```\r\nsqlite_utils/db.py:366: in Database\r\n def tables(self) -> List[Table]:\r\nE NameError: name 'Table' is not defined\r\n```\r\nPython 3.7 can fix this with `from __future__ import annotations` but since we still support 3.6 I'll have to use a string instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896156971", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896156971, "node_id": "IC_kwDOCGYnMM41akUr", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T17:04:22Z", "updated_at": "2021-08-10T17:05:59Z", "author_association": "OWNER", "body": "I'm going to get Read The Docs to build the docs for this branch too - on https://readthedocs.org/projects/sqlite-utils/versions/ I am clicking this button:\r\n\r\n\"Versions___Read_the_Docs\"\r\n\r\nI then set it to \"active\" (so pushes to the branch will build it) and \"hidden\" (so it wouldn't show up in search or in the navigation menu). https://docs.readthedocs.io/en/stable/versions.html#version-states\r\n\r\n\"autodoc_-_sqlite-utils___Read_the_Docs\"\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896162082", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896162082, "node_id": "IC_kwDOCGYnMM41alki", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-08-10T17:10:39Z", "updated_at": "2021-08-10T23:07:35Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#312](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (43bc064) into [main](https://codecov.io/gh/simonw/sqlite-utils/commit/ee469e3122d6f5973ec2584c1580d930daca2e7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (ee469e3) will **decrease** coverage by `0.02%`.\n> The diff coverage is `96.84%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/sqlite-utils/pull/312/graphs/tree.svg?width=650&height=150&src=pr&token=O0X3703L9P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@ Coverage Diff @@\n## main #312 +/- ##\n==========================================\n- Coverage 96.30% 96.28% -0.03% \n==========================================\n Files 5 5 \n Lines 2168 2179 +11 \n==========================================\n+ Hits 2088 2098 +10 \n- Misses 80 81 +1 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [sqlite\\_utils/db.py](https://codecov.io/gh/simonw/sqlite-utils/pull/312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-c3FsaXRlX3V0aWxzL2RiLnB5) | `97.91% <96.84%> (-0.08%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [ee469e3...43bc064](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896174456", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896174456, "node_id": "IC_kwDOCGYnMM41aol4", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T17:27:01Z", "updated_at": "2021-08-10T17:27:01Z", "author_association": "OWNER", "body": "Docs are now building at https://sqlite-utils.datasette.io/en/autodoc/reference.html\r\n\r\nBut there's a problem! The page is semi-blank:\r\n\r\n\"Reference_\u2014_sqlite-utils_3_15-6-gc11ff89_documentation\"\r\n\r\nI need to teach Read The Docs how to ensure `sqlite_utils` is available for introspection.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896175438", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896175438, "node_id": "IC_kwDOCGYnMM41ao1O", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T17:28:19Z", "updated_at": "2021-08-10T17:28:19Z", "author_association": "OWNER", "body": "https://sphinx-rtd-tutorial.readthedocs.io/en/latest/sphinx-config.html#autodoc-configuration says do something like this at the top of `conf.py`:\r\n\r\n```python\r\nimport os\r\nimport sys\r\nsys.path.insert(0, os.path.abspath('../../simpleble/'))\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896180956", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896180956, "node_id": "IC_kwDOCGYnMM41aqLc", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T17:35:51Z", "updated_at": "2021-08-10T17:35:51Z", "author_association": "OWNER", "body": "Reading the rest of https://sphinx-rtd-tutorial.readthedocs.io/en/latest/sphinx-config.html#autodoc-configuration it suggests using a `requirements.txt` file to install dependencies - but I use `setup.py` for that so I need to figure out a different pattern here.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896182934", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896182934, "node_id": "IC_kwDOCGYnMM41aqqW", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T17:38:44Z", "updated_at": "2021-08-10T17:38:44Z", "author_association": "OWNER", "body": "From https://docs.readthedocs.io/en/stable/config-file/v2.html#packages it looks like I can tell Read The Docs to run `pip install -e .` using a `.readthedocs.yaml` configuration:\r\n\r\n```yaml\r\nversion: 2\r\n\r\nsphinx:\r\n configuration: docs/conf.py\r\n\r\npython:\r\n version: \"3.9\"\r\n install:\r\n - method: pip\r\n path: .\r\n extra_requirements:\r\n - docs\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896186025", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896186025, "node_id": "IC_kwDOCGYnMM41arap", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T17:42:51Z", "updated_at": "2021-08-10T17:42:51Z", "author_association": "OWNER", "body": "That worked! https://sqlite-utils.datasette.io/en/autodoc/reference.html", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896200682", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896200682, "node_id": "IC_kwDOCGYnMM41au_q", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T18:03:40Z", "updated_at": "2021-08-10T18:03:40Z", "author_association": "OWNER", "body": "Adding type signatures to `create_table()` and `.create_table_sql()` is a bit too involved, I'll do that in a separate issue.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896284722", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/312", "id": 896284722, "node_id": "IC_kwDOCGYnMM41bDgy", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-10T20:08:03Z", "updated_at": "2021-08-10T20:08:21Z", "author_association": "OWNER", "body": "Spotted a rogue backtick:\r\n\r\n![A0147E27-7506-49B0-BEFB-20D99BBFEBAD](https://user-images.githubusercontent.com/9599/128927930-b3333dee-a385-409b-a945-f108e6ea40df.jpeg)\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 965143346, "label": "Add reference page to documentation using Sphinx autodoc"}, "performed_via_github_app": null}