{"html_url": "https://github.com/simonw/datasette/issues/1214#issuecomment-771992628", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1214", "id": 771992628, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MTk5MjYyOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-02-02T21:15:18Z", "updated_at": "2021-02-02T21:15:18Z", "author_association": "OWNER", "body": "The cause of this bug is form fields which begin with `_` but ARE displayed as form inputs on the page - hence should not be duplicated in an `<input type=\"hidden\">` element.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 799693777, "label": "Re-submitting filter form duplicates _x querystring arguments"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1214#issuecomment-771992025", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1214", "id": 771992025, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MTk5MjAyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-02-02T21:14:16Z", "updated_at": "2021-02-02T21:14:16Z", "author_association": "OWNER", "body": "As a result, navigating to https://github-to-sqlite.dogsheep.net/github/labels?_search=help and clearing out the `_search` field then submitting the form does NOT clear the search term.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 799693777, "label": "Re-submitting filter form duplicates _x querystring arguments"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1212#issuecomment-771976561", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1212", "id": 771976561, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MTk3NjU2MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-02-02T20:53:27Z", "updated_at": "2021-02-02T20:53:27Z", "author_association": "OWNER", "body": "It would be great if we could get `python-xdist` to run too - I tried it in the past and gave up when I ran into those race conditions, but I've not done any further digging to see if there's a way to fix that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 797651831, "label": "Tests are very slow. "}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1212#issuecomment-771975941", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1212", "id": 771975941, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MTk3NTk0MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-02-02T20:52:36Z", "updated_at": "2021-02-02T20:52:36Z", "author_association": "OWNER", "body": "37 minutes, wow! They're a little slow for me (4-5 minutes perhaps) but not nearly that bad.\r\n\r\nThanks for running that profile. I think you're right: figuring out how to use more session scopes would definitely help.\r\n\r\nThe `:memory:` idea is interesting too. The new `memory_name=` feature added in #1151 (released in Datasette 0.54) could help a lot here, since it allows Datasette instances to share the same in-memory database across multiple HTTP requests and connections.\r\n\r\nNote that `memory_name=` also persists within test runs themselves, independently of any `scope=` options on the fixtures. That might actually help us here!\r\n\r\nI'd be delighted if you explored this issue further, especially the option of using `memory_name=` for the fixtures databases used by the tests.\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 797651831, "label": "Tests are very slow. "}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1213#issuecomment-771968675", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1213", "id": 771968675, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MTk2ODY3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-02-02T20:41:55Z", "updated_at": "2021-02-02T20:41:55Z", "author_association": "OWNER", "body": "So maybe I could a special response header which ASGI middleware can pick up that means \"Don't attempt to gzip this, just stream it through\".", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 799663959, "label": "gzip support for HTML (and JSON) responses"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1213#issuecomment-771968177", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1213", "id": 771968177, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MTk2ODE3Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-02-02T20:41:13Z", "updated_at": "2021-02-02T20:41:13Z", "author_association": "OWNER", "body": "Starlette accumulates the full response body in a `body` variable and then does this:\r\n```python\r\n        elif message_type == \"http.response.body\":\r\n            # Remaining body in streaming GZip response.\r\n            body = message.get(\"body\", b\"\")\r\n            more_body = message.get(\"more_body\", False)\r\n\r\n            self.gzip_file.write(body)\r\n            if not more_body:\r\n                self.gzip_file.close()\r\n\r\n            message[\"body\"] = self.gzip_buffer.getvalue()\r\n            self.gzip_buffer.seek(0)\r\n            self.gzip_buffer.truncate()\r\n\r\n            await self.send(message)\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 799663959, "label": "gzip support for HTML (and JSON) responses"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1213#issuecomment-771965281", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1213", "id": 771965281, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MTk2NTI4MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-02-02T20:37:08Z", "updated_at": "2021-02-02T20:39:24Z", "author_association": "OWNER", "body": "Starlette's gzip middleware implementation is here: https://github.com/encode/starlette/blob/0.14.2/starlette/middleware/gzip.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 799663959, "label": "gzip support for HTML (and JSON) responses"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1211#issuecomment-771127458", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1211", "id": 771127458, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MTEyNzQ1OA==", "user": {"value": 4488943, "label": "kbaikov"}, "created_at": "2021-02-01T20:13:39Z", "updated_at": "2021-02-01T20:13:39Z", "author_association": "CONTRIBUTOR", "body": "Ping @simonw ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 797649915, "label": "Use context manager instead of plain open"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1159#issuecomment-770865698", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1159", "id": 770865698, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MDg2NTY5OA==", "user": {"value": 552629, "label": "lovasoa"}, "created_at": "2021-02-01T13:42:29Z", "updated_at": "2021-02-01T13:42:29Z", "author_association": "NONE", "body": "@simonw : Could you have a look at this ? I think this really improves readability.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 774332247, "label": "Improve the display of facets information"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1211#issuecomment-770343684", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1211", "id": 770343684, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MDM0MzY4NA==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-01-31T08:03:40Z", "updated_at": "2021-01-31T08:03:40Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1211?src=pr&el=h1) Report\n> Merging [#1211](https://codecov.io/gh/simonw/datasette/pull/1211?src=pr&el=desc) (e33ccaa) into [main](https://codecov.io/gh/simonw/datasette/commit/dde3c500c73ace33529672f7d862b76753d309cc?el=desc) (dde3c50) will **decrease** coverage by `0.00%`.\n> The diff coverage is `92.85%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1211/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1211?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##             main    #1211      +/-   ##\n==========================================\n- Coverage   91.54%   91.53%   -0.01%     \n==========================================\n  Files          32       32              \n  Lines        3948     3959      +11     \n==========================================\n+ Hits         3614     3624      +10     \n- Misses        334      335       +1     \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1211?src=pr&el=tree) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/cli.py](https://codecov.io/gh/simonw/datasette/pull/1211/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2NsaS5weQ==) | `77.29% <66.66%> (-0.31%)` | :arrow_down: |\n| [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/1211/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `95.62% <100.00%> (+<0.01%)` | :arrow_up: |\n| [datasette/publish/cloudrun.py](https://codecov.io/gh/simonw/datasette/pull/1211/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3B1Ymxpc2gvY2xvdWRydW4ucHk=) | `96.96% <100.00%> (+0.09%)` | :arrow_up: |\n| [datasette/publish/heroku.py](https://codecov.io/gh/simonw/datasette/pull/1211/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3B1Ymxpc2gvaGVyb2t1LnB5) | `87.73% <100.00%> (+0.60%)` | :arrow_up: |\n| [datasette/utils/\\_\\_init\\_\\_.py](https://codecov.io/gh/simonw/datasette/pull/1211/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `94.13% <100.00%> (+0.02%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1211?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute <relative> (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1211?src=pr&el=footer). Last update [dde3c50...e33ccaa](https://codecov.io/gh/simonw/datasette/pull/1211?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 797649915, "label": "Use context manager instead of plain open"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/github-to-sqlite/issues/51#issuecomment-770150526", "issue_url": "https://api.github.com/repos/dogsheep/github-to-sqlite/issues/51", "id": 770150526, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MDE1MDUyNg==", "user": {"value": 22578954, "label": "daniel-butler"}, "created_at": "2021-01-30T03:44:19Z", "updated_at": "2021-01-30T03:47:24Z", "author_association": "CONTRIBUTOR", "body": "I don't have much experience with github's rate limiting. In my day job we use the [tenacity library](https://github.com/jd/tenacity) to handle http errors we get.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 703246031, "label": "github-to-sqlite should handle rate limits better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/github-to-sqlite/issues/60#issuecomment-770112248", "issue_url": "https://api.github.com/repos/dogsheep/github-to-sqlite/issues/60", "id": 770112248, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MDExMjI0OA==", "user": {"value": 22578954, "label": "daniel-butler"}, "created_at": "2021-01-30T00:01:03Z", "updated_at": "2021-01-30T01:14:42Z", "author_association": "CONTRIBUTOR", "body": "Yes that would be cool! I wouldn't mind helping. Is this the meat of it? https://github.com/dogsheep/twitter-to-sqlite/blob/21fc1cad6dd6348c67acff90a785b458d3a81275/twitter_to_sqlite/utils.py#L512\r\n\r\nIt looks like the cli option is added with this decorator : https://github.com/dogsheep/twitter-to-sqlite/blob/21fc1cad6dd6348c67acff90a785b458d3a81275/twitter_to_sqlite/cli.py#L14\r\n\r\nI looked a bit at utils.py in the GitHub repository. I was surprised at the amount of manual mapping of the API response you had to do to get this to work.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 797097140, "label": "Use Data from SQLite in other commands"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/github-to-sqlite/issues/60#issuecomment-770071568", "issue_url": "https://api.github.com/repos/dogsheep/github-to-sqlite/issues/60", "id": 770071568, "node_id": "MDEyOklzc3VlQ29tbWVudDc3MDA3MTU2OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-29T21:56:15Z", "updated_at": "2021-01-29T21:56:15Z", "author_association": "MEMBER", "body": "I really like the way you're using pipes here - really smart. It's similar to how I build the demo database in this GitHub Actions workflow:\r\n\r\nhttps://github.com/dogsheep/github-to-sqlite/blob/62dfd3bc4014b108200001ef4bc746feb6f33b45/.github/workflows/deploy-demo.yml#L52-L82\r\n\r\n`twitter-to-sqlite` actually has a mechanism for doing this kind of thing, documented at https://github.com/dogsheep/twitter-to-sqlite#providing-input-from-a-sql-query-with---sql-and---attach\r\n\r\nIt lets you do things like:\r\n\r\n```\r\n$ twitter-to-sqlite users-lookup my.db --sql=\"select follower_id from following\" --ids\r\n```\r\nMaybe I should add something similar to `github-to-sqlite`? Feels like it could be really useful.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 797097140, "label": "Use Data from SQLite in other commands"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/twitter-to-sqlite/issues/56#issuecomment-769973212", "issue_url": "https://api.github.com/repos/dogsheep/twitter-to-sqlite/issues/56", "id": 769973212, "node_id": "MDEyOklzc3VlQ29tbWVudDc2OTk3MzIxMg==", "user": {"value": 42315895, "label": "gsajko"}, "created_at": "2021-01-29T18:29:02Z", "updated_at": "2021-01-29T18:31:55Z", "author_association": "NONE", "body": "I think it was with `twitter-to-sqlite home-timeline home.db -a  auth.json --since`\r\nand Im using only this command to grab tweets \r\n\r\nfrom cron tab\r\n`2,7,12,17,22,27,32,37,42,47,52,57 * * * * run-one /home/gsajko/miniconda3/bin/twitter-to-sqlite home-timeline /home/gsajko/work/custom_twitter_feed/home.db -a /home/gsajko/work/custom_twitter_feed/auth/auth.json --since`\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 796736607, "label": "Not all quoted statuses get fetched?"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/twitter-to-sqlite/issues/56#issuecomment-769957751", "issue_url": "https://api.github.com/repos/dogsheep/twitter-to-sqlite/issues/56", "id": 769957751, "node_id": "MDEyOklzc3VlQ29tbWVudDc2OTk1Nzc1MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-29T17:59:40Z", "updated_at": "2021-01-29T17:59:40Z", "author_association": "MEMBER", "body": "This is interesting - how did you create that initial table? Was this using the `twitter-to-sqlite import archive.db ~/Downloads/twitter-2019-06-25-b31f2.zip` command, or something else?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 796736607, "label": "Not all quoted statuses get fetched?"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1207#issuecomment-769534187", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1207", "id": 769534187, "node_id": "MDEyOklzc3VlQ29tbWVudDc2OTUzNDE4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-29T02:37:19Z", "updated_at": "2021-01-29T02:37:19Z", "author_association": "OWNER", "body": "https://docs.datasette.io/en/latest/testing_plugins.html#using-pdb-for-errors-thrown-inside-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793881756, "label": "Document the Datasette(..., pdb=True) testing pattern"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1209#issuecomment-769455370", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1209", "id": 769455370, "node_id": "MDEyOklzc3VlQ29tbWVudDc2OTQ1NTM3MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-28T23:00:21Z", "updated_at": "2021-01-28T23:00:21Z", "author_association": "OWNER", "body": "Good catch on the workaround here. The root problem is that `datasette-template-sql` looks for the first available databsae if you don't provide it with a `database=` argument, and in Datasette 0.54 the first available database changed to being the new `_internal` database.\r\n\r\nIs this a bug? I think it is - because the documented behaviour on https://docs.datasette.io/en/stable/internals.html#get-database-name is this:\r\n\r\n> `name` - string, optional\r\n>\r\n> The name to be used for this database - this will be used in the URL path, e.g. `/dbname`. If not specified Datasette will pick one based on the filename or memory name.\r\n\r\nSince the new behaviour differs from what was in the documentation I'm going to treat this as a bug and fix it.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 795367402, "label": "v0.54 500 error from sql query in custom template; code worked in v0.53; found a workaround"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1205#issuecomment-769453074", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1205", "id": 769453074, "node_id": "MDEyOklzc3VlQ29tbWVudDc2OTQ1MzA3NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-28T22:54:49Z", "updated_at": "2021-01-28T22:55:02Z", "author_association": "OWNER", "body": "\r\nI also checked that the following works:\r\n\r\n    echo '{\"foo\": \"bar\"}' | sqlite-utils insert _memory.db demo -\r\n    datasette _memory.db --memory\r\n\r\nSure enough, it results in the following Datasette homepage - thanks to #509\r\n\r\n<img width=\"274\" alt=\"Datasette___memory___memory_2\" src=\"https://user-images.githubusercontent.com/9599/106208790-c8564980-6178-11eb-8b8b-053a9f1d0193.png\">", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793027837, "label": "Rename /:memory: to /_memory"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1205#issuecomment-769452084", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1205", "id": 769452084, "node_id": "MDEyOklzc3VlQ29tbWVudDc2OTQ1MjA4NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-28T22:52:23Z", "updated_at": "2021-01-28T22:52:23Z", "author_association": "OWNER", "body": "Here are the redirect tests: https://github.com/simonw/datasette/blob/1600d2a3ec3ada1f6fb5b1eb73bdaeccb5f80530/tests/test_api.py#L635-L648", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793027837, "label": "Rename /:memory: to /_memory"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1205#issuecomment-769442165", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1205", "id": 769442165, "node_id": "MDEyOklzc3VlQ29tbWVudDc2OTQ0MjE2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-28T22:30:16Z", "updated_at": "2021-01-28T22:30:27Z", "author_association": "OWNER", "body": "I'm going to do this, with redirects from `/:memory:*`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793027837, "label": "Rename /:memory: to /_memory"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1210#issuecomment-769274591", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1210", "id": 769274591, "node_id": "MDEyOklzc3VlQ29tbWVudDc2OTI3NDU5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-28T18:10:02Z", "updated_at": "2021-01-28T18:10:02Z", "author_association": "OWNER", "body": "That definitely sounds like a bug! Can you provide a copy of your `metadata.JSON` and the command-line you are using to launch Datasette?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 796234313, "label": "Immutable Database w/ Canned Queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/twitter-to-sqlite/issues/54#issuecomment-767888743", "issue_url": "https://api.github.com/repos/dogsheep/twitter-to-sqlite/issues/54", "id": 767888743, "node_id": "MDEyOklzc3VlQ29tbWVudDc2Nzg4ODc0Mw==", "user": {"value": 19328961, "label": "henry501"}, "created_at": "2021-01-26T23:07:41Z", "updated_at": "2021-01-26T23:07:41Z", "author_association": "NONE", "body": "My import got much further with the applied fixes than 0.21.3, but not 100%. I do appear to have all of the tweets imported at least. \r\nNot sure when I'll have a chance to look further to try to fix or see what didn't make it into the import.\r\n\r\nHere's my output:\r\n\r\n```\r\ndirect-messages-group: not yet implemented\r\nbranch-links: not yet implemented\r\nperiscope-expired-broadcasts: not yet implemented\r\ndirect-messages: not yet implemented\r\nmute: not yet implemented\r\nperiscope-comments-made-by-user: not yet implemented\r\nperiscope-ban-information: not yet implemented\r\nperiscope-profile-description: not yet implemented\r\nscreen-name-change: not yet implemented\r\nmanifest: not yet implemented\r\nfleet: not yet implemented\r\nuser-link-clicks: not yet implemented\r\nperiscope-broadcast-metadata: not yet implemented\r\ncontact: not yet implemented\r\nfleet-mute: not yet implemented\r\ndevice-token: not yet implemented\r\nprotected-history: not yet implemented\r\ndirect-message-mute: not yet implemented\r\nTraceback (most recent call last):\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/bin/twitter-to-sqlite\", line 33, in <module>\r\n    sys.exit(load_entry_point('twitter-to-sqlite==0.21.3', 'console_scripts', 'twitter-to-sqlite')())\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/click/core.py\", line 829, in __call__\r\n    return self.main(*args, **kwargs)\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/click/core.py\", line 782, in main\r\n    rv = self.invoke(ctx)\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/click/core.py\", line 1259, in invoke\r\n    return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/click/core.py\", line 1066, in invoke\r\n    return ctx.invoke(self.callback, **ctx.params)\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/click/core.py\", line 610, in invoke\r\n    return callback(*args, **kwargs)\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/twitter_to_sqlite/cli.py\", line 772, in import_\r\n    archive.import_from_file(db, filepath.name, open(filepath, \"rb\").read())\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/twitter_to_sqlite/archive.py\", line 233, in import_from_file\r\n    to_insert = transformer(data)\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/twitter_to_sqlite/archive.py\", line 21, in callback\r\n    return {filename: [fn(item) for item in data]}\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/twitter_to_sqlite/archive.py\", line 21, in <listcomp>\r\n    return {filename: [fn(item) for item in data]}\r\n  File \"/Users/henry/.local/share/virtualenvs/python-sqlite-testing-mF3G2xKl/lib/python3.9/site-packages/twitter_to_sqlite/archive.py\", line 88, in ageinfo\r\n    return item[\"ageMeta\"][\"ageInfo\"]\r\nKeyError: 'ageInfo'\r\n\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 779088071, "label": "Archive import appears to be broken on recent exports"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1208#issuecomment-767823684", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1208", "id": 767823684, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NzgyMzY4NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-26T20:58:51Z", "updated_at": "2021-01-26T20:58:51Z", "author_association": "OWNER", "body": "This is a good catch - I've been lazy about this, but you're right that it's an issue that needs cleaning up.  Would be very happy to apply a PR, thanks!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 794554881, "label": "A lot of open(file) functions are used without a context manager thus producing ResourceWarning: unclosed file <_io.TextIOWrapper"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1151#issuecomment-767762551", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1151", "id": 767762551, "node_id": "MDEyOklzc3VlQ29tbWVudDc2Nzc2MjU1MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-26T19:07:44Z", "updated_at": "2021-01-26T19:07:44Z", "author_association": "OWNER", "body": "Mentioned in https://simonwillison.net/2021/Jan/25/datasette/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 770448622, "label": "Database class mechanism for cross-connection in-memory databases"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/991#issuecomment-767761155", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/991", "id": 767761155, "node_id": "MDEyOklzc3VlQ29tbWVudDc2Nzc2MTE1NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-26T19:05:21Z", "updated_at": "2021-01-26T19:06:36Z", "author_association": "OWNER", "body": "Idea: implement this using the existing table view, with a custom template called `table-internal-bb0ec0-tables.html` - that's the custom template listed in the HTML comments at the bottom of https://latest.datasette.io/_internal/tables", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 714377268, "label": "Redesign application homepage"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1201#issuecomment-766991680", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1201", "id": 766991680, "node_id": "MDEyOklzc3VlQ29tbWVudDc2Njk5MTY4MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T17:42:21Z", "updated_at": "2021-01-25T17:42:21Z", "author_association": "OWNER", "body": "https://docs.datasette.io/en/stable/changelog.html#v0-54", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792904595, "label": "Release notes for Datasette 0.54"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1206#issuecomment-766589070", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1206", "id": 766589070, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjU4OTA3MA==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-01-25T06:50:30Z", "updated_at": "2021-01-25T17:31:11Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1206?src=pr&el=h1) Report\n> Merging [#1206](https://codecov.io/gh/simonw/datasette/pull/1206?src=pr&el=desc) (06480e1) into [main](https://codecov.io/gh/simonw/datasette/commit/a5ede3cdd455e2bb1a1fb2f4e1b5a9855caf5179?el=desc) (a5ede3c) will **not change** coverage.\n> The diff coverage is `100.00%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1206/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1206?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##             main    #1206   +/-   ##\n=======================================\n  Coverage   91.53%   91.53%           \n=======================================\n  Files          32       32           \n  Lines        3947     3947           \n=======================================\n  Hits         3613     3613           \n  Misses        334      334           \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1206?src=pr&el=tree) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/version.py](https://codecov.io/gh/simonw/datasette/pull/1206/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (\u00f8)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1206?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute <relative> (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1206?src=pr&el=footer). Last update [a5ede3c...571476d](https://codecov.io/gh/simonw/datasette/pull/1206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793086333, "label": "Release 0.54"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1206#issuecomment-766588371", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1206", "id": 766588371, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjU4ODM3MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T06:49:06Z", "updated_at": "2021-01-25T06:49:06Z", "author_association": "OWNER", "body": "Last thing to do: write up the annotated version of these release notes, assign it a URL on my blog and link to it from the release notes here so I can publish them simultaneously.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793086333, "label": "Release 0.54"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1206#issuecomment-766588020", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1206", "id": 766588020, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjU4ODAyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T06:48:20Z", "updated_at": "2021-01-25T06:48:20Z", "author_association": "OWNER", "body": "Issues to reference in the commit message: #509, #1091, #1150, #1151, #1166, #1167, #1178, #1181, #1182, #1184, #1185, #1186, #1187, #1194, #1198", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793086333, "label": "Release 0.54"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1201#issuecomment-766586151", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1201", "id": 766586151, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjU4NjE1MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T06:44:43Z", "updated_at": "2021-01-25T06:44:43Z", "author_association": "OWNER", "body": "OK, release notes are ready to merge from that branch. I'll ship the release in the morning, to give me time to write the accompanying annotated release notes.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792904595, "label": "Release notes for Datasette 0.54"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1201#issuecomment-766545604", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1201", "id": 766545604, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjU0NTYwNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T05:14:31Z", "updated_at": "2021-01-25T05:14:31Z", "author_association": "OWNER", "body": "The two big ticket items are `<script type=\"module\">` support and the new `_internal` mechanism.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792904595, "label": "Release notes for Datasette 0.54"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1201#issuecomment-766545442", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1201", "id": 766545442, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjU0NTQ0Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T05:13:59Z", "updated_at": "2021-01-25T05:13:59Z", "author_association": "OWNER", "body": "The big stuff:\r\n\r\n- Database(memory_name=) for shared in-memory databases, closes #1151 \r\n- The `_internal` database -  #1150\r\n-  script type=module support, closes #1186 , #1187\r\n- Improved design for the `.add_database()` method 8919f99c2f7f245aca7f94bd53d5ac9d04aa42b5 - which means databases with the same stem can now be opened, #509\r\n- Adopted Prettier #1166 \r\n\r\nSmaller:\r\n\r\n- force_https_urls on for publish cloudrun, refs #1178 \r\n- Fixed bug in example nginx config, refs #1091 \r\n-  Shrunk ecosystem docs in favour of datasette.io, closes #1182 \r\n-  request.full_path property, closes #1184 \r\n-  Better PRAGMA error message, closes #1185 \r\n-  publish heroku now uses python-3.8.7 \r\n-  Plugin testing documentation on using pytest-httpx Closes #1198\r\n-  Contributing docs for Black and Prettier, closes #1167 \r\n-  All ?_ parameters now copied to hidden form fields, closes #1194 \r\n- Fixed bug loading database called 'test-database (1).sqlite' - Closes #1181.\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792904595, "label": "Release notes for Datasette 0.54"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1201#issuecomment-766543387", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1201", "id": 766543387, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjU0MzM4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T05:07:40Z", "updated_at": "2021-01-25T05:13:29Z", "author_association": "OWNER", "body": "Changes: https://github.com/simonw/datasette/compare/0.53...a5ede3cdd455e2bb1a1fb2f4e1b5a9855caf5179", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792904595, "label": "Release notes for Datasette 0.54"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/983#issuecomment-766536076", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/983", "id": 766536076, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjUzNjA3Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T04:43:53Z", "updated_at": "2021-01-25T04:43:53Z", "author_association": "OWNER", "body": "... actually not going to include this in 0.54, I need to write a couple of plugins myself using it before I even make it available in preview.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712260429, "label": "JavaScript plugin hooks mechanism similar to pluggy"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1195#issuecomment-766535046", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1195", "id": 766535046, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjUzNTA0Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T04:40:08Z", "updated_at": "2021-01-25T04:40:08Z", "author_association": "OWNER", "body": "Also: should the view name really be the same for both of these pages?\r\n\r\n- https://latest.datasette.io/fixtures?sql=select+*+from+facetable\r\n- https://latest.datasette.io/fixtures/neighborhood_search\r\n\r\nWhere one of them is a canned query and the other is an arbitrary query?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 789336592, "label": "view_name = \"query\" for the query page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1195#issuecomment-766534748", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1195", "id": 766534748, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjUzNDc0OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T04:38:56Z", "updated_at": "2021-01-25T04:38:56Z", "author_association": "OWNER", "body": "Here's a diff showing how far I got before I abandoned this particular effort:\r\n\r\n```diff\r\ndiff --git a/datasette/views/base.py b/datasette/views/base.py\r\nindex a21b929..04e4aa9 100644\r\n--- a/datasette/views/base.py\r\n+++ b/datasette/views/base.py\r\n@@ -120,7 +120,7 @@ class BaseView:\r\n         handler = getattr(self, request.method.lower(), None)\r\n         return await handler(request, *args, **kwargs)\r\n \r\n-    async def render(self, templates, request, context=None):\r\n+    async def render(self, templates, request, context=None, view_name=None):\r\n         context = context or {}\r\n         template = self.ds.jinja_env.select_template(templates)\r\n         template_context = {\r\n@@ -135,7 +135,7 @@ class BaseView:\r\n         }\r\n         return Response.html(\r\n             await self.ds.render_template(\r\n-                template, template_context, request=request, view_name=self.name\r\n+                template, template_context, request=request, view_name=view_name\r\n             )\r\n         )\r\n \r\n@@ -155,7 +155,7 @@ class BaseView:\r\n \r\n \r\n class DataView(BaseView):\r\n-    name = \"\"\r\n+    view_name = \"no-view-name\"\r\n     re_named_parameter = re.compile(\":([a-zA-Z0-9_]+)\")\r\n \r\n     async def options(self, request, *args, **kwargs):\r\n@@ -414,6 +414,10 @@ class DataView(BaseView):\r\n             args[\"table\"] = urllib.parse.unquote_plus(args[\"table\"])\r\n         return _format, args\r\n \r\n+    async def get_view_name(self, request, database, hash, **kwargs):\r\n+        # Defaults to self.view_name, but can be over-ridden by subclasses\r\n+        return self.view_name\r\n+\r\n     async def view_get(self, request, database, hash, correct_hash_provided, **kwargs):\r\n         _format, kwargs = await self.get_format(request, database, kwargs)\r\n \r\n@@ -424,6 +428,8 @@ class DataView(BaseView):\r\n             # HTML views default to expanding all foreign key labels\r\n             kwargs[\"default_labels\"] = True\r\n \r\n+        view_name = await self.get_view_name(request, database, hash, **kwargs)\r\n+\r\n         extra_template_data = {}\r\n         start = time.perf_counter()\r\n         status_code = 200\r\n@@ -489,7 +495,7 @@ class DataView(BaseView):\r\n                 database=database,\r\n                 table=data.get(\"table\"),\r\n                 request=request,\r\n-                view_name=self.name,\r\n+                view_name=view_name,\r\n                 # These will be deprecated in Datasette 1.0:\r\n                 args=request.args,\r\n                 data=data,\r\n@@ -533,7 +539,7 @@ class DataView(BaseView):\r\n                     database=database,\r\n                     table=data.get(\"table\"),\r\n                     request=request,\r\n-                    view_name=self.name,\r\n+                    view_name=view_name,\r\n                 )\r\n                 it_can_render = await await_me_maybe(it_can_render)\r\n                 if it_can_render:\r\n@@ -565,7 +571,7 @@ class DataView(BaseView):\r\n             }\r\n             if \"metadata\" not in context:\r\n                 context[\"metadata\"] = self.ds.metadata\r\n-            r = await self.render(templates, request=request, context=context)\r\n+            r = await self.render(templates, request=request, context=context, view_name=view_name)\r\n             r.status = status_code\r\n \r\n         ttl = request.args.get(\"_ttl\", None)\r\ndiff --git a/datasette/views/database.py b/datasette/views/database.py\r\nindex f6fd579..e425213 100644\r\n--- a/datasette/views/database.py\r\n+++ b/datasette/views/database.py\r\n@@ -23,7 +23,11 @@ from .base import DatasetteError, DataView\r\n \r\n \r\n class DatabaseView(DataView):\r\n-    name = \"database\"\r\n+    async def get_view_name(self, request, db_name, table_and_format):\r\n+        if request.args.get(\"sql\"):\r\n+            return \"query\"\r\n+        else:\r\n+            return \"database\"\r\n \r\n     async def data(self, request, database, hash, default_labels=False, _size=None):\r\n         await self.check_permissions(\r\n@@ -145,7 +149,7 @@ class DatabaseView(DataView):\r\n \r\n \r\n class DatabaseDownload(DataView):\r\n-    name = \"database_download\"\r\n+    view_name = \"database_download\"\r\n \r\n     async def view_get(self, request, database, hash, correct_hash_present, **kwargs):\r\n         await self.check_permissions(\r\ndiff --git a/datasette/views/index.py b/datasette/views/index.py\r\nindex b6b8cbe..d750e3d 100644\r\n--- a/datasette/views/index.py\r\n+++ b/datasette/views/index.py\r\n@@ -16,7 +16,7 @@ COUNT_DB_SIZE_LIMIT = 100 * 1024 * 1024\r\n \r\n \r\n class IndexView(BaseView):\r\n-    name = \"index\"\r\n+    view_name = \"index\"\r\n \r\n     async def get(self, request, as_format):\r\n         await self.check_permission(request, \"view-instance\")\r\ndiff --git a/datasette/views/special.py b/datasette/views/special.py\r\nindex 9750dd0..dbd1e00 100644\r\n--- a/datasette/views/special.py\r\n+++ b/datasette/views/special.py\r\n@@ -6,7 +6,7 @@ import secrets\r\n \r\n \r\n class JsonDataView(BaseView):\r\n-    name = \"json_data\"\r\n+    view_name = \"json_data\"\r\n \r\n     def __init__(self, datasette, filename, data_callback, needs_request=False):\r\n         self.ds = datasette\r\n@@ -42,7 +42,7 @@ class JsonDataView(BaseView):\r\n \r\n \r\n class PatternPortfolioView(BaseView):\r\n-    name = \"patterns\"\r\n+    view_name = \"patterns\"\r\n \r\n     async def get(self, request):\r\n         await self.check_permission(request, \"view-instance\")\r\n@@ -50,7 +50,7 @@ class PatternPortfolioView(BaseView):\r\n \r\n \r\n class AuthTokenView(BaseView):\r\n-    name = \"auth_token\"\r\n+    view_name = \"auth_token\"\r\n \r\n     async def get(self, request):\r\n         token = request.args.get(\"token\") or \"\"\r\n@@ -68,7 +68,7 @@ class AuthTokenView(BaseView):\r\n \r\n \r\n class LogoutView(BaseView):\r\n-    name = \"logout\"\r\n+    view_name = \"logout\"\r\n \r\n     async def get(self, request):\r\n         if not request.actor:\r\n@@ -87,7 +87,7 @@ class LogoutView(BaseView):\r\n \r\n \r\n class PermissionsDebugView(BaseView):\r\n-    name = \"permissions_debug\"\r\n+    view_name = \"permissions_debug\"\r\n \r\n     async def get(self, request):\r\n         await self.check_permission(request, \"view-instance\")\r\n@@ -102,7 +102,7 @@ class PermissionsDebugView(BaseView):\r\n \r\n \r\n class AllowDebugView(BaseView):\r\n-    name = \"allow_debug\"\r\n+    view_name = \"allow_debug\"\r\n \r\n     async def get(self, request):\r\n         errors = []\r\n@@ -136,7 +136,7 @@ class AllowDebugView(BaseView):\r\n \r\n \r\n class MessagesDebugView(BaseView):\r\n-    name = \"messages_debug\"\r\n+    view_name = \"messages_debug\"\r\n \r\n     async def get(self, request):\r\n         await self.check_permission(request, \"view-instance\")\r\ndiff --git a/datasette/views/table.py b/datasette/views/table.py\r\nindex 0a3504b..45d298a 100644\r\n--- a/datasette/views/table.py\r\n+++ b/datasette/views/table.py\r\n@@ -257,7 +257,16 @@ class RowTableShared(DataView):\r\n \r\n \r\n class TableView(RowTableShared):\r\n-    name = \"table\"\r\n+    view_name = \"table\"\r\n+\r\n+    async def get_view_name(self, request, db_name, table_and_format):\r\n+        canned_query = await self.ds.get_canned_query(\r\n+            db_name, table_and_format, request.actor\r\n+        )\r\n+        if canned_query:\r\n+            return \"query\"\r\n+        else:\r\n+            return \"table\"\r\n \r\n     async def post(self, request, db_name, table_and_format):\r\n         # Handle POST to a canned query\r\n@@ -923,7 +932,7 @@ async def _sql_params_pks(db, table, pk_values):\r\n \r\n \r\n class RowView(RowTableShared):\r\n-    name = \"row\"\r\n+    view_name = \"row\"\r\n \r\n     async def data(self, request, database, hash, table, pk_path, default_labels=False):\r\n         await self.check_permissions(\r\ndiff --git a/tests/test_plugins.py b/tests/test_plugins.py\r\nindex 715c7c1..7ce2b1b 100644\r\n--- a/tests/test_plugins.py\r\n+++ b/tests/test_plugins.py\r\n@@ -252,7 +252,7 @@ def test_plugin_config_file(app_client):\r\n             },\r\n         ),\r\n         (\r\n-            \"/fixtures/\",\r\n+            \"/fixtures\",\r\n             {\r\n                 \"template\": \"database.html\",\r\n                 \"database\": \"fixtures\",\r\n@@ -285,6 +285,38 @@ def test_plugin_config_file(app_client):\r\n                 ],\r\n             },\r\n         ),\r\n+        (\r\n+            \"/fixtures?sql=select+1+as+one\",\r\n+            {\r\n+                \"template\": \"query.html\",\r\n+                \"database\": \"fixtures\",\r\n+                \"table\": None,\r\n+                \"config\": {\"depth\": \"database\"},\r\n+                \"view_name\": \"query\",\r\n+                \"request_path\": \"/fixtures\",\r\n+                \"added\": 15,\r\n+                \"columns\": [\r\n+                    \"one\",\r\n+                ],\r\n+            },\r\n+        ),\r\n+        (\r\n+            \"/fixtures/neighborhood_search\",\r\n+            {\r\n+                \"template\": \"query.html\",\r\n+                \"database\": \"fixtures\",\r\n+                \"table\": None,\r\n+                \"config\": {\"depth\": \"database\"},\r\n+                \"view_name\": \"query\",\r\n+                \"request_path\": \"/fixtures/neighborhood_search\",\r\n+                \"added\": 15,\r\n+                \"columns\": [\r\n+                    \"neighborhood\",\r\n+                    \"name\",\r\n+                    \"state\",\r\n+                ],\r\n+            },\r\n+        ),\r\n     ],\r\n )\r\n def test_hook_extra_body_script(app_client, path, expected_extra_body_script):\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 789336592, "label": "view_name = \"query\" for the query page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1195#issuecomment-766534634", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1195", "id": 766534634, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjUzNDYzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T04:38:30Z", "updated_at": "2021-01-25T04:38:30Z", "author_association": "OWNER", "body": "This has proved surprisingly difficult to implement, due to the weird way the QueryView is actually called. The class itself isn't used like other view classes - instead, the `.data()` methods of both `DatabaseView` and `TableView` dispatch out to `QueryView.data()` when they need to:\r\n\r\nhttps://github.com/simonw/datasette/blob/07e163561592c743e4117f72102fcd350a600909/datasette/views/table.py#L259-L270\r\n\r\nhttps://github.com/simonw/datasette/blob/07e163561592c743e4117f72102fcd350a600909/datasette/views/table.py#L290-L294\r\n\r\nhttps://github.com/simonw/datasette/blob/07e163561592c743e4117f72102fcd350a600909/datasette/views/database.py#L39-L44\r\n\r\nIt turns out this is a bad pattern because it makes changes like this one WAY harder than they should be.\r\n\r\nI think I should clean this up as part of #878.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 789336592, "label": "view_name = \"query\" for the query page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1204#issuecomment-766525337", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1204", "id": 766525337, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjUyNTMzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T04:04:28Z", "updated_at": "2021-01-25T04:04:28Z", "author_association": "OWNER", "body": "Writing the tests will be a bit tricky since we need to confirm that the `include_table_top(datasette, database, actor, table)` arguments were all passed correctly but the only thing we get back from the plugin is a list of templates. Maybe encode those values into the template names somehow?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793002853, "label": "WIP: Plugin includes"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/987#issuecomment-766524141", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/987", "id": 766524141, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjUyNDE0MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T03:59:55Z", "updated_at": "2021-01-25T03:59:55Z", "author_association": "OWNER", "body": "This is joined with #1191 now, which I've bumped from 0.54.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712984738, "label": "Documented HTML hooks for JavaScript plugin authors"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-766524016", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 766524016, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjUyNDAxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T03:59:17Z", "updated_at": "2021-01-25T03:59:17Z", "author_association": "OWNER", "body": "More work can happen in the PR: #1204", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-766523866", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 766523866, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjUyMzg2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T03:58:34Z", "updated_at": "2021-01-25T03:58:34Z", "author_association": "OWNER", "body": "I've got a good prototype working now, but I'm dropping this from the Datasette 0.54 milestone because it requires a bunch of additional work to make sure it is really well tested and documented.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1194#issuecomment-766491911", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1194", "id": 766491911, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ5MTkxMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T02:02:15Z", "updated_at": "2021-01-25T02:02:15Z", "author_association": "OWNER", "body": "I'm going to copy across anything starting with an underscore.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 788447787, "label": "?_size= argument is not persisted by hidden form fields in the table filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1167#issuecomment-766491566", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1167", "id": 766491566, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ5MTU2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T02:01:19Z", "updated_at": "2021-01-25T02:01:19Z", "author_association": "OWNER", "body": "New documentation section here (I documented Black as well): https://docs.datasette.io/en/latest/contributing.html#code-formatting", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 777145954, "label": "Add Prettier to contributing documentation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1167#issuecomment-766487520", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1167", "id": 766487520, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ4NzUyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T01:44:43Z", "updated_at": "2021-01-25T01:44:43Z", "author_association": "OWNER", "body": "Thanks @benpickles, I just merged that in. I'll use it in the documentation.\r\n\r\n    # To check code is conformant\r\n    npm run prettier -- --check\r\n    # To fix it if it isn't\r\n    npm run fix\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 777145954, "label": "Add Prettier to contributing documentation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/983#issuecomment-766484915", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/983", "id": 766484915, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ4NDkxNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T01:33:29Z", "updated_at": "2021-01-25T01:33:29Z", "author_association": "OWNER", "body": "I'm going to ship a version of this in Datasette 0.54 with a warning that the interface should be considered unstable (see #1202) so that we can start trying this out.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712260429, "label": "JavaScript plugin hooks mechanism similar to pluggy"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1179#issuecomment-766484435", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1179", "id": 766484435, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ4NDQzNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T01:31:36Z", "updated_at": "2021-01-25T01:31:36Z", "author_association": "OWNER", "body": "Relevant existing tests: https://github.com/simonw/datasette/blob/461670a0b87efa953141b449a9a261919864ceb3/tests/test_utils.py#L365-L398", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 780278550, "label": "Make original path available to render hooks"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1179#issuecomment-766484257", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1179", "id": 766484257, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ4NDI1Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T01:30:57Z", "updated_at": "2021-01-25T01:30:57Z", "author_association": "OWNER", "body": "The challenge here is figuring out what the original path, without the `.format`, actually was - while taking into account that Datasette has a special case for tables that themselves end in a `.something`.\r\n\r\nThe `path_with_format()` function nearly does what we need here:\r\n\r\nhttps://github.com/simonw/datasette/blob/b6a7b58fa01af0cd5a5e94bd17d686d283a46819/datasette/utils/__init__.py#L710-L729\r\n\r\nIt can be called with `replace_format=\"csv\"` to REMOVE the `.csv` format and replace it with something else.\r\n\r\nProblem is, we want to use it to get rid of the format entirely.\r\n\r\nWe could update `path_with_format()` to accept `format=''` to mean \"remove the format entirely\", but it's a bit messy. It may be better to reconsider the design of `path_with_format()` and related utility functions entirely.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 780278550, "label": "Make original path available to render hooks"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-766466030", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 766466030, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ2NjAzMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T00:11:04Z", "updated_at": "2021-01-25T00:11:04Z", "author_association": "OWNER", "body": "I can combine this with #987 - each of these areas of the page can be wrapped in a `<div>` with a class that matches the name of the plugin hook, that way JavaScript plugins can append their content in the same place as Python plugins.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1154#issuecomment-766465719", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1154", "id": 766465719, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ2NTcxOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T00:09:22Z", "updated_at": "2021-01-25T00:09:22Z", "author_association": "OWNER", "body": "https://docs.datasette.io/en/latest/internals.html#the-internal-database\r\n\r\n<img width=\"738\" alt=\"Internals_for_plugins_\u2014_Datasette_documentation\" src=\"https://user-images.githubusercontent.com/9599/105648087-76eb4900-5e5e-11eb-9c73-c00ba37b7b10.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 771208009, "label": "Documentation for new _internal database and tables"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1202#issuecomment-766464136", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1202", "id": 766464136, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ2NDEzNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-25T00:01:02Z", "updated_at": "2021-01-25T00:01:02Z", "author_association": "OWNER", "body": "I'm going to use the existing `.. warning::` pattern for this.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792931244, "label": "Documentation convention for marking unstable APIs."}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1090#issuecomment-766463496", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1090", "id": 766463496, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ2MzQ5Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-24T23:57:00Z", "updated_at": "2021-01-24T23:57:00Z", "author_association": "OWNER", "body": "Related: I built [datasette-leaflet-freedraw](https://datasette.io/plugins/datasette-leaflet-freedraw) which turns any canned query field called `freedraw` or `something_freedraw` into an interactive map that you can draw on to create a GeoJSON MultiPolygon.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 741862364, "label": "Custom widgets for canned query forms"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1202#issuecomment-766462475", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1202", "id": 766462475, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ2MjQ3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-24T23:49:28Z", "updated_at": "2021-01-24T23:50:33Z", "author_association": "OWNER", "body": "Can use an \"admonition\" similar to this:\r\n```sphinx\r\n.. warning::\r\n    Restricting access to tables and views in this way will NOT prevent users from querying them using arbitrary SQL queries, `like this <https://latest.datasette.io/fixtures?sql=select+*+from+facetable>`__ for example.\r\n```\r\nAs seen on https://docs.datasette.io/en/stable/authentication.html#controlling-access-to-specific-tables-and-views\r\n\r\nDocumentation: https://docutils.sourceforge.io/docs/ref/rst/directives.html#specific-admonitions", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792931244, "label": "Documentation convention for marking unstable APIs."}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1154#issuecomment-766462197", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1154", "id": 766462197, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQ2MjE5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-24T23:47:06Z", "updated_at": "2021-01-24T23:47:06Z", "author_association": "OWNER", "body": "I'm going to document this but mark it as unstable, using a new documentation convention for marking unstable APIs.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 771208009, "label": "Documentation for new _internal database and tables"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1179#issuecomment-766434629", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1179", "id": 766434629, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQzNDYyOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-24T21:23:47Z", "updated_at": "2021-01-24T21:23:47Z", "author_association": "OWNER", "body": "I'm just going to do `path` and `full_path` (which includes the querystring)`. The `datasette.absolute_url()` method can be used by plugins that need the full URL.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 780278550, "label": "Make original path available to render hooks"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1190#issuecomment-766433153", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1190", "id": 766433153, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQzMzE1Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-24T21:13:25Z", "updated_at": "2021-01-24T21:13:25Z", "author_association": "OWNER", "body": "This ties in to a bunch of other ideas that are in flight at the moment.\r\n\r\nIf you're publishing databases by uploading them, how do you attach metadata? Ideally by baking it into the database file itself, using the mechanism from #1169.\r\n\r\nHow could this interact with the `datasette insert` concept from #1163? Could you pass a CSV file to the `upload` command and have that converted and uploaded for you, or would you create the database file locally using `datasette insert` and then upload it as a separate `datasette upload` step?\r\n\r\nLots to think about here.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098146, "label": "`datasette publish upload` mechanism for uploading databases to an existing Datasette instance"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1190#issuecomment-766430644", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1190", "id": 766430644, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQzMDY0NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-24T20:57:03Z", "updated_at": "2021-01-24T20:57:03Z", "author_association": "OWNER", "body": "I really like this idea. It feels like an opportunity for a plugin that adds two things: an API endpoint to Datasette for accepting uploaded databases, and a `datasette publish upload` subcommand which can upload files to that endpoint (with some kind of authentication mechanism).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098146, "label": "`datasette publish upload` mechanism for uploading databases to an existing Datasette instance"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1197#issuecomment-766430111", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1197", "id": 766430111, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQzMDExMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-24T20:53:40Z", "updated_at": "2021-01-24T20:53:40Z", "author_association": "OWNER", "body": "https://devcenter.heroku.com/articles/slug-compiler#slug-size says that the maximum allowed size is 500MB - my hunch is that the Datasette application itself weighs in at only a dozen or so MB but I haven't measured it. So I would imagine anything up to around 450MB should work OK on Heroku.\r\n\r\nCloud Run works for up to about 2GB in my experience.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 791381623, "label": "DB size limit for publishing with Heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1198#issuecomment-766428183", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1198", "id": 766428183, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjQyODE4Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-24T20:40:37Z", "updated_at": "2021-01-24T20:40:37Z", "author_association": "OWNER", "body": "https://docs.datasette.io/en/latest/testing_plugins.html#testing-outbound-http-calls-with-pytest-httpx", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792625812, "label": "Plugin testing documentation on using pytest-httpx"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1199#issuecomment-766181628", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1199", "id": 766181628, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NjE4MTYyOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-23T21:25:18Z", "updated_at": "2021-01-23T21:25:18Z", "author_association": "OWNER", "body": "Comment thread here: https://news.ycombinator.com/item?id=25881911 - cperciva says:\r\n\r\n>  There's an even better reason for databases to not write to memory mapped pages: Pages get synched out to disk at the kernel's leisure. This can be ok for a cache but it's definitely not what you want for a database!\r\n\r\nBut... Datasette is often used in read-only mode, so that disadvantage often doesn't apply.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792652391, "label": "Experiment with PRAGMA mmap_size=N"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/224#issuecomment-765678057", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/224", "id": 765678057, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTY3ODA1Nw==", "user": {"value": 37962604, "label": "polyrand"}, "created_at": "2021-01-22T20:53:06Z", "updated_at": "2021-01-23T20:13:27Z", "author_association": "NONE", "body": "I'm using the FTS methods in sqlite-utils for this website: [drwn.io](https://drwn.io/). I wanted to get pagination to have some kind of infinite scrolling in the landing page, and I ended up using that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 792297010, "label": "Add fts offset docs."}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-765757433", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 765757433, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTc1NzQzMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-22T23:43:43Z", "updated_at": "2021-01-22T23:43:43Z", "author_association": "OWNER", "body": "Another potential use for this: plugins that provide authentication (like `datasette-auth-passwords` and `datasette-auth-github`) could use it to add a chunk of HTML to the \"permission denied\" page that links to their mechanism of authenticating.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1196#issuecomment-765639968", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1196", "id": 765639968, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTYzOTk2OA==", "user": {"value": 2826376, "label": "QAInsights"}, "created_at": "2021-01-22T19:37:15Z", "updated_at": "2021-01-22T19:37:15Z", "author_association": "NONE", "body": "I tried deployment in WSL. It is working fine https://jmeter.vercel.app/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 791237799, "label": "Access Denied Error in Windows"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/genome-to-sqlite/issues/1#issuecomment-765525338", "issue_url": "https://api.github.com/repos/dogsheep/genome-to-sqlite/issues/1", "id": 765525338, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTUyNTMzOA==", "user": {"value": 25372415, "label": "cobiadigital"}, "created_at": "2021-01-22T16:22:44Z", "updated_at": "2021-01-22T16:22:44Z", "author_association": "NONE", "body": "rs1333049 associated with coronary artery disease\r\nhttps://www.snpedia.com/index.php/Rs1333049\r\n```\r\n\r\nselect rsid, genotype, case genotype\r\n  when 'CC' then '1.9x increased risk for coronary artery disease'\r\n  when 'CG' then '1.5x increased risk for CAD'\r\n  when 'GG' then 'normal'\r\nend as interpretation from genome where rsid = 'rs1333049'\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 496415321, "label": "Figure out some interesting example SQL queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/genome-to-sqlite/issues/1#issuecomment-765523517", "issue_url": "https://api.github.com/repos/dogsheep/genome-to-sqlite/issues/1", "id": 765523517, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTUyMzUxNw==", "user": {"value": 25372415, "label": "cobiadigital"}, "created_at": "2021-01-22T16:20:25Z", "updated_at": "2021-01-22T16:20:25Z", "author_association": "NONE", "body": "rs53576: the oxytocin receptor (OXTR) gene\r\n\r\n```\r\nselect rsid, genotype, case genotype\r\n  when 'AA' then 'Lack of empathy?'\r\n  when 'AG' then 'Lack of empathy?'\r\n  when 'GG' then 'Optimistic and empathetic; handle stress well'\r\nend as interpretation from genome where rsid = 'rs53576'\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 496415321, "label": "Figure out some interesting example SQL queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/genome-to-sqlite/issues/1#issuecomment-765506901", "issue_url": "https://api.github.com/repos/dogsheep/genome-to-sqlite/issues/1", "id": 765506901, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTUwNjkwMQ==", "user": {"value": 25372415, "label": "cobiadigital"}, "created_at": "2021-01-22T15:58:41Z", "updated_at": "2021-01-22T15:58:58Z", "author_association": "NONE", "body": "Both rs10757274 and rs2383206 can both indicate higher risks of heart disease\r\nhttps://www.snpedia.com/index.php/Rs2383206\r\n\r\n```\r\nselect rsid, genotype, case genotype\r\n  when 'AA' then 'Normal'\r\n  when 'AG' then '~1.2x increased risk for heart disease'\r\n  when 'GG' then '~1.3x increased risk for heart disease'\r\nend as interpretation from genome where rsid = 'rs10757274'\r\n```\r\n\r\n```\r\nselect rsid, genotype, case genotype\r\n  when 'AA' then 'Normal'\r\n  when 'AG' then '1.4x increased risk for heart disease'\r\n  when 'GG' then '1.7x increased risk for heart disease'\r\nend as interpretation from genome where rsid = 'rs2383206'\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 496415321, "label": "Figure out some interesting example SQL queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/genome-to-sqlite/issues/1#issuecomment-765502845", "issue_url": "https://api.github.com/repos/dogsheep/genome-to-sqlite/issues/1", "id": 765502845, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTUwMjg0NQ==", "user": {"value": 25372415, "label": "cobiadigital"}, "created_at": "2021-01-22T15:53:19Z", "updated_at": "2021-01-22T15:53:19Z", "author_association": "NONE", "body": "rs7903146 Influences risk of Type-2 diabetes\r\nhttps://www.snpedia.com/index.php/Rs7903146\r\n```\r\nselect rsid, genotype, case genotype\r\n  when 'CC' then 'Normal (lower) risk of Type 2 Diabetes and Gestational Diabetes.'\r\n  when 'CT' then '1.4x increased risk for diabetes (and perhaps colon cancer).'\r\n  when 'TT' then '2x increased risk for Type-2 diabetes'\r\nend as interpretation from genome where rsid = 'rs7903146'\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 496415321, "label": "Figure out some interesting example SQL queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/genome-to-sqlite/issues/1#issuecomment-765498984", "issue_url": "https://api.github.com/repos/dogsheep/genome-to-sqlite/issues/1", "id": 765498984, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTQ5ODk4NA==", "user": {"value": 25372415, "label": "cobiadigital"}, "created_at": "2021-01-22T15:48:25Z", "updated_at": "2021-01-22T15:49:33Z", "author_association": "NONE", "body": "The \"Warrior Gene\" https://www.snpedia.com/index.php/Rs4680\r\n\r\n```\r\nselect rsid, genotype, case genotype\r\n  when 'AA' then '(worrier) advantage in memory and attention tasks'\r\n  when 'AG' then 'Intermediate dopamine levels, other effects'\r\n  when 'GG' then '(warrior) multiple associations, see details'\r\nend as interpretation from genome where rsid = 'rs4680'\r\n```\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 496415321, "label": "Figure out some interesting example SQL queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/genome-to-sqlite/issues/1#issuecomment-765495861", "issue_url": "https://api.github.com/repos/dogsheep/genome-to-sqlite/issues/1", "id": 765495861, "node_id": "MDEyOklzc3VlQ29tbWVudDc2NTQ5NTg2MQ==", "user": {"value": 25372415, "label": "cobiadigital"}, "created_at": "2021-01-22T15:44:00Z", "updated_at": "2021-01-22T15:44:00Z", "author_association": "NONE", "body": "Risk of autoimmune disorders: https://www.snpedia.com/index.php/Genotype\r\n```\r\nselect rsid, genotype, case genotype\r\n  when 'AA' then '2x risk of rheumatoid arthritis and other autoimmune diseases'\r\n  when 'GG' then 'Normal risk for autoimmune disorders'\r\nend as interpretation from genome where rsid = 'rs2476601'\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 496415321, "label": "Figure out some interesting example SQL queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1195#issuecomment-763108730", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1195", "id": 763108730, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MzEwODczMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-19T20:22:37Z", "updated_at": "2021-01-19T20:22:37Z", "author_association": "OWNER", "body": "I can use this test: https://github.com/simonw/datasette/blob/c38c42948cbfddd587729413fd6082ba352eaece/tests/test_plugins.py#L238-L294", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 789336592, "label": "view_name = \"query\" for the query page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/223#issuecomment-762540514", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/223", "id": 762540514, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MjU0MDUxNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-19T01:14:58Z", "updated_at": "2021-01-19T01:15:54Z", "author_association": "OWNER", "body": "Example from https://docs.python.org/3/library/csv.html#csv.reader\r\n```pycon\r\n>>> import csv\r\n>>> with open('eggs.csv', newline='') as csvfile:\r\n...     spamreader = csv.reader(csvfile, delimiter=' ', quotechar='|')\r\n...     for row in spamreader:\r\n...         print(', '.join(row))\r\nSpam, Spam, Spam, Spam, Spam, Baked Beans\r\nSpam, Lovely Spam, Wonderful Spam\r\n```\r\nI'm going to add `--quotechar` as well as `--delimiter`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 788527932, "label": "--delimiter option for CSV import"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1175#issuecomment-762488336", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1175", "id": 762488336, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MjQ4ODMzNg==", "user": {"value": 758858, "label": "hannseman"}, "created_at": "2021-01-18T21:59:28Z", "updated_at": "2021-01-18T22:00:31Z", "author_association": "NONE", "body": "I encountered your issue when trying to find a solution and came up with the following, maybe it can help.\r\n\r\n```python\r\nimport logging.config\r\nfrom typing import Tuple\r\n\r\nimport structlog\r\nimport uvicorn\r\n\r\nfrom example.config import settings\r\n\r\nshared_processors: Tuple[structlog.types.Processor, ...] = (\r\n    structlog.contextvars.merge_contextvars,\r\n    structlog.stdlib.add_logger_name,\r\n    structlog.stdlib.add_log_level,\r\n    structlog.processors.TimeStamper(fmt=\"iso\"),\r\n)\r\n\r\nlogging_config = {\r\n    \"version\": 1,\r\n    \"disable_existing_loggers\": False,\r\n    \"formatters\": {\r\n        \"json\": {\r\n            \"()\": structlog.stdlib.ProcessorFormatter,\r\n            \"processor\": structlog.processors.JSONRenderer(),\r\n            \"foreign_pre_chain\": shared_processors,\r\n        },\r\n        \"console\": {\r\n            \"()\": structlog.stdlib.ProcessorFormatter,\r\n            \"processor\": structlog.dev.ConsoleRenderer(),\r\n            \"foreign_pre_chain\": shared_processors,\r\n        },\r\n        **uvicorn.config.LOGGING_CONFIG[\"formatters\"],\r\n    },\r\n    \"handlers\": {\r\n        \"default\": {\r\n            \"level\": \"DEBUG\",\r\n            \"class\": \"logging.StreamHandler\",\r\n            \"formatter\": \"json\" if not settings.debug else \"console\",\r\n        },\r\n        \"uvicorn.access\": {\r\n            \"level\": \"INFO\",\r\n            \"class\": \"logging.StreamHandler\",\r\n            \"formatter\": \"access\",\r\n        },\r\n        \"uvicorn.default\": {\r\n            \"level\": \"INFO\",\r\n            \"class\": \"logging.StreamHandler\",\r\n            \"formatter\": \"default\",\r\n        },\r\n    },\r\n    \"loggers\": {\r\n        \"\": {\"handlers\": [\"default\"], \"level\": \"INFO\"},\r\n        \"uvicorn.error\": {\r\n            \"handlers\": [\"default\" if not settings.debug else \"uvicorn.default\"],\r\n            \"level\": \"INFO\",\r\n            \"propagate\": False,\r\n        },\r\n        \"uvicorn.access\": {\r\n            \"handlers\": [\"default\" if not settings.debug else \"uvicorn.access\"],\r\n            \"level\": \"INFO\",\r\n            \"propagate\": False,\r\n        },\r\n    },\r\n}\r\n\r\n\r\ndef setup_logging() -> None:\r\n    structlog.configure(\r\n        processors=[\r\n            structlog.stdlib.filter_by_level,\r\n            *shared_processors,\r\n            structlog.stdlib.PositionalArgumentsFormatter(),\r\n            structlog.processors.StackInfoRenderer(),\r\n            structlog.processors.format_exc_info,\r\n            structlog.stdlib.ProcessorFormatter.wrap_for_formatter,\r\n        ],\r\n        context_class=dict,\r\n        logger_factory=structlog.stdlib.LoggerFactory(),\r\n        wrapper_class=structlog.stdlib.AsyncBoundLogger,\r\n        cache_logger_on_first_use=True,\r\n    )\r\n    logging.config.dictConfig(logging_config)\r\n```\r\n\r\nAnd then it'll be run on the startup event:\r\n```python\r\n@app.on_event(\"startup\")\r\nasync def startup_event() -> None:\r\n    setup_logging()\r\n```\r\n\r\nIt depends on a setting called `debug` which controls if it should output the regular uvicorn logging or json. ", "reactions": "{\"total_count\": 15, \"+1\": 7, \"-1\": 0, \"laugh\": 1, \"hooray\": 1, \"confused\": 0, \"heart\": 5, \"rocket\": 1, \"eyes\": 0}", "issue": {"value": 779156520, "label": "Use structlog for logging"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1036#issuecomment-762391426", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1036", "id": 762391426, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MjM5MTQyNg==", "user": {"value": 4997607, "label": "philshem"}, "created_at": "2021-01-18T17:45:00Z", "updated_at": "2021-01-18T17:45:00Z", "author_association": "NONE", "body": "It might be possible with this library: https://docs.python.org/3/library/imghdr.html\r\n\r\nquick test of the downloaded blob:\r\n\r\n```\r\n>>> import imghdr\r\n>>> imghdr.what('material_culture-1-image.blob')\r\n'jpeg'\r\n```\r\n\r\nThe output plugin would be cool. I'll look into making my first datasette plugin.  I'm also imagining displaying the image in the browser -- but that would be a step 2.\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 725996507, "label": "Make it possible to download BLOB data from the Datasette UI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1194#issuecomment-762390568", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1194", "id": 762390568, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MjM5MDU2OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-18T17:43:03Z", "updated_at": "2021-01-18T17:43:03Z", "author_association": "OWNER", "body": "Should I just blanket copy over any query string argument that starts with an underscore? Any reason _not_ to do that?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 788447787, "label": "?_size= argument is not persisted by hidden form fields in the table filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1194#issuecomment-762390401", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1194", "id": 762390401, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MjM5MDQwMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-18T17:42:38Z", "updated_at": "2021-01-18T17:42:38Z", "author_association": "OWNER", "body": "Relevant code: https://github.com/simonw/datasette/blob/a882d679626438ba0d809944f06f239bcba8ee96/datasette/views/table.py#L815-L827\r\n\r\nIt looks like there are other arguments that may not be persisted too.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 788447787, "label": "?_size= argument is not persisted by hidden form fields in the table filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1036#issuecomment-762387875", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1036", "id": 762387875, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MjM4Nzg3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-18T17:36:36Z", "updated_at": "2021-01-18T17:36:36Z", "author_association": "OWNER", "body": "As you can see, I'm pretty paranoid about serving content with `Content-Type` HTTP headers because I'm so worried about execution vulnerabilities. I'm much more comfortable exploring that kind of thing in plugins, since that way people can opt-in to riskier features.\r\n\r\nYou found `datasette-media` which is my most comprehensive exploration of that idea so far - but there's definitely lots of room for more plugins along those lines.\r\n\r\nMaybe even an output plugin? `.jpg` as an export format which returns the `BLOB` column for a row as a JPEG image with the correct `content-type` header (but first verifies that the binary content does indeed look like a real JPEG) could be interesting.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 725996507, "label": "Make it possible to download BLOB data from the Datasette UI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1036#issuecomment-762385981", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1036", "id": 762385981, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MjM4NTk4MQ==", "user": {"value": 4997607, "label": "philshem"}, "created_at": "2021-01-18T17:32:13Z", "updated_at": "2021-01-18T17:34:50Z", "author_association": "NONE", "body": "Hi Simon\r\n\r\nJust finding this old issue regarding downloading blobs. Nice work!\r\n\r\n<img width=\"212\" alt=\"image\" src=\"https://user-images.githubusercontent.com/4997607/104946741-df4bad80-59ba-11eb-96e3-727c85cc4dc6.png\">\r\n\r\nAs a feature request, maybe it would be possible to assign a blob column as a certain data type (e.g. `.jpg`) and then each blob could be downloaded as that type of file (perhaps if the file types were constrained to normal blobs that people store in sqlite databases, this could avoid the execution stuff mentioned above).\r\n\r\nI guess the column blob-type definition could fit into this dropdown selection:\r\n\r\n<img width=\"201\" alt=\"image\" src=\"https://user-images.githubusercontent.com/4997607/104947000-479a8f00-59bb-11eb-87d9-1644e5940894.png\">\r\n\r\nLet me know if I should open a new issue with a feature request. (This could slowly go in the direction of displaying image blob-types in the browser.)\r\n\r\nThanks for the great tool!\r\n\r\n\r\n---\r\n\r\nedit: just reading the rest of the twitter thread: https://twitter.com/simonw/status/1318685933256855552\r\n\r\nperhaps this is already possible in some form with the plugin datasette-media: https://github.com/simonw/datasette-media", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 725996507, "label": "Make it possible to download BLOB data from the Datasette UI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/swarm-to-sqlite/issues/11#issuecomment-761967094", "issue_url": "https://api.github.com/repos/dogsheep/swarm-to-sqlite/issues/11", "id": 761967094, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTk2NzA5NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-18T04:11:13Z", "updated_at": "2021-01-18T04:11:13Z", "author_association": "MEMBER", "body": "I just got a similar error:\r\n\r\n```\r\n  File \"/home/dogsheep/datasette-venv/lib/python3.8/site-packages/swarm_to_sqlite/utils.py\", line 79, in save_checkin\r\n    checkins_table.m2m(\"users\", user, m2m_table=\"with\", pk=\"id\")\r\n  File \"/home/dogsheep/datasette-venv/lib/python3.8/site-packages/sqlite_utils/db.py\", line 2048, in m2m\r\n    id = other_table.insert(record, pk=pk, replace=True).last_pk\r\n  File \"/home/dogsheep/datasette-venv/lib/python3.8/site-packages/sqlite_utils/db.py\", line 1781, in insert\r\n    return self.insert_all(\r\n  File \"/home/dogsheep/datasette-venv/lib/python3.8/site-packages/sqlite_utils/db.py\", line 1899, in insert_all\r\n    self.insert_chunk(\r\n  File \"/home/dogsheep/datasette-venv/lib/python3.8/site-packages/sqlite_utils/db.py\", line 1709, in insert_chunk\r\n    result = self.db.execute(query, params)\r\n  File \"/home/dogsheep/datasette-venv/lib/python3.8/site-packages/sqlite_utils/db.py\", line 226, in execute\r\n    return self.conn.execute(sql, parameters)\r\npysqlite3.dbapi2.OperationalError: table users has no column named countryCode\r\n\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 743400216, "label": "Error thrown: sqlite3.OperationalError: table users has no column named lastName"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-761705076", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 761705076, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTcwNTA3Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-17T00:35:13Z", "updated_at": "2021-01-17T00:37:51Z", "author_association": "OWNER", "body": "I'm going to try using Jinja macros to implement this: https://jinja.palletsprojects.com/en/2.11.x/templates/#macros\r\n\r\nMaybe using one of these tricks to auto-load the macro? http://codyaray.com/2015/05/auto-load-jinja2-macros", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1181#issuecomment-761703555", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1181", "id": 761703555, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTcwMzU1NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-17T00:24:20Z", "updated_at": "2021-01-17T00:24:40Z", "author_association": "OWNER", "body": "Here's the incomplete sketch of a test - to go at the bottom of `test_cli.py`.\r\n\r\n```python\r\n@pytest.mark.parametrize(\r\n    \"filename\", [\"test-database (1).sqlite\", \"database (1).sqlite\"]\r\n)\r\ndef test_weird_database_names(ensure_eventloop, tmpdir, filename):\r\n    # https://github.com/simonw/datasette/issues/1181\r\n    runner = CliRunner()\r\n    db_path = str(tmpdir / filename)\r\n    sqlite3.connect(db_path).execute(\"vacuum\")\r\n    result1 = runner.invoke(cli, [db_path, \"--get\", \"/\"])\r\n    assert result1.exit_code == 0, result1.output\r\n    homepage_html = result1.output\r\n    assert False\r\n```\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 781262510, "label": "Certain database names results in 404: \"Database not found: None\""}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-761703368", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 761703368, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTcwMzM2OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-17T00:22:46Z", "updated_at": "2021-01-17T00:22:46Z", "author_association": "OWNER", "body": "I'm going to prototype this in a branch.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-761703232", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 761703232, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTcwMzIzMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-17T00:21:31Z", "updated_at": "2021-01-17T00:21:54Z", "author_association": "OWNER", "body": "I think this ends up being a whole collection of new plugin hooks, something like:\r\n\r\n- `include_table_top`\r\n- `include_table_bottom`\r\n- `include_row_top`\r\n- `include_row_bottom`\r\n- `include_database_top`\r\n- `include_database_bottom`\r\n- `include_query_bottom`\r\n- `include_query_bottom`\r\n- `include_index_bottom`\r\n- `include_index_bottom`", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-761703022", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 761703022, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTcwMzAyMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-17T00:20:00Z", "updated_at": "2021-01-17T00:20:00Z", "author_association": "OWNER", "body": "Plugins that want to provide extra context to the template can already do so using the `extra_template_vars()` plugin hook.\r\n\r\nSo this hook could work by returning a list of template filenames to be included. Those templates can be bundled with the plugin. Since they are included they will have access to the template context and to any `extra_template_vars()` values.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/657#issuecomment-761179229", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/657", "id": 761179229, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTE3OTIyOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-15T20:24:35Z", "updated_at": "2021-01-15T20:24:35Z", "author_association": "OWNER", "body": "I'm not sure how I missed this issue but it's almost a year later and I'm finally taking a look at your Parquet work.\r\n\r\nThis is yet more evidence that allowing plugins to provide their own custom `Database` objects would be a good idea.\r\n\r\nI started exploring what Datasette would like on PostgreSQL in #670 - my concern was that I would need to add a large amount of database abstraction code which would dramatically increase the complexity of the core project, but my thinking now is that it might be tractable - Datasette doesn't actually construct SQL in complex ways anywhere outside of the `TableView` class so abstracting away just that bit should be feasible.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 548591089, "label": "Allow creation of virtual tables at startup"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-761103910", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 761103910, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTEwMzkxMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-15T18:19:29Z", "updated_at": "2021-01-15T18:19:29Z", "author_association": "OWNER", "body": "This relates to #987 (documented HTML hooks for JavaScript plugins) but is not quite the same thing.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/657#issuecomment-761101878", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/657", "id": 761101878, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTEwMTg3OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-15T18:16:01Z", "updated_at": "2021-01-15T18:16:01Z", "author_association": "OWNER", "body": "I think the `startup()` plugin hook at https://docs.datasette.io/en/stable/plugin_hooks.html#startup-datasette should be able to fit this. You can write a plugin which uses that hook to execute `CREATE VIRTUAL TABLE` against  one or more databases when Datasette first starts running.\r\n\r\nWould that work here?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 548591089, "label": "Allow creation of virtual tables at startup"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/220#issuecomment-761015218", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/220", "id": 761015218, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTAxNTIxOA==", "user": {"value": 649467, "label": "mhalle"}, "created_at": "2021-01-15T15:40:08Z", "updated_at": "2021-01-15T15:40:08Z", "author_association": "NONE", "body": "Make sense. If you're coming from the sqlite3 side of things, rather than the datasette side, wanting the fts methods to work for views makes more sense. sqlite3 allows fts5 tables on views, so I was looking for CLI functionality to build the fts virtual tables. Ultimately, though, sharing fts virtual tables across tables and derivative views is likely more efficient. \r\n\r\nMaybe an explicit error message like, \"fts is not supported for views\" rather than just throwing an exception that the method doesn't exist\" might be helpful.  Not critical though.\r\n\r\nThanks.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 783778672, "label": "Better error message for *_fts methods against views"}, "performed_via_github_app": null}
{"html_url": "https://github.com/dogsheep/twitter-to-sqlite/pull/55#issuecomment-760950128", "issue_url": "https://api.github.com/repos/dogsheep/twitter-to-sqlite/issues/55", "id": 760950128, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MDk1MDEyOA==", "user": {"value": 21148, "label": "jacobian"}, "created_at": "2021-01-15T13:44:52Z", "updated_at": "2021-01-15T13:44:52Z", "author_association": "CONTRIBUTOR", "body": "I found and fixed another bug, this one around importing the tweets table. @simonw let me know if you'd prefer this broken out into multiple PRs, happy to do that if it makes review/merging easier.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 779211940, "label": "Fix archive imports"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1187#issuecomment-759875239", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1187", "id": 759875239, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTg3NTIzOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-14T02:02:24Z", "updated_at": "2021-01-14T02:02:31Z", "author_association": "OWNER", "body": "This plugin hook currently returns a string of JavaScript. It could optionally return this instead of a string:\r\n```json\r\n{\r\n  \"script\": \"string of JavaScript goes here\",\r\n  \"module\": true\r\n}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 785588942, "label": "extra_body_script() support for script type=\"module\""}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1186#issuecomment-759874332", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1186", "id": 759874332, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTg3NDMzMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-14T01:59:35Z", "updated_at": "2021-01-14T01:59:35Z", "author_association": "OWNER", "body": "Updated documentation: https://docs.datasette.io/en/latest/custom_templates.html#custom-css-and-javascript and https://docs.datasette.io/en/latest/plugin_hooks.html#extra-js-urls-template-database-table-columns-view-name-request-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 785573793, "label": "script type=\"module\" support"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1159#issuecomment-759306228", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1159", "id": 759306228, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTMwNjIyOA==", "user": {"value": 552629, "label": "lovasoa"}, "created_at": "2021-01-13T08:59:31Z", "updated_at": "2021-01-13T08:59:31Z", "author_association": "NONE", "body": "@simonw : Did you have the time to take a look at this ?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 774332247, "label": "Improve the display of facets information"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/220#issuecomment-759098964", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/220", "id": 759098964, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTA5ODk2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T23:19:55Z", "updated_at": "2021-01-12T23:19:55Z", "author_association": "OWNER", "body": "I don't think it makes sense to call `.enable_fts()` on a view does it? When I'm working with views and FTS I tend to write my queries against a FTS table for one of the tables that is used by the view - https://docs.datasette.io/en/stable/full_text_search.html#configuring-full-text-search-for-a-table-or-view describes how I do that in Datasette for example.\r\n\r\nCan you expand on your use-case for FTS and views? I'm ready to be convinced otherwise, but I don't see how it would work right now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 783778672, "label": "Better error message for *_fts methods against views"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1185#issuecomment-759069342", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1185", "id": 759069342, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTA2OTM0Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T22:13:18Z", "updated_at": "2021-01-12T22:13:18Z", "author_association": "OWNER", "body": "I'm going to change the error message to list the allowed pragmas.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 784628163, "label": "\"Statement may not contain PRAGMA\" error is not strictly true"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1185#issuecomment-759067427", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1185", "id": 759067427, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTA2NzQyNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T22:09:21Z", "updated_at": "2021-01-12T22:09:21Z", "author_association": "OWNER", "body": "That allow-list was added in #761 but is not currently documented. It's here in the code:\r\n\r\nhttps://github.com/simonw/datasette/blob/8e8fc5cee5c78da8334495c6d6257d5612c40792/datasette/utils/__init__.py#L173-L186", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 784628163, "label": "\"Statement may not contain PRAGMA\" error is not strictly true"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1185#issuecomment-759066777", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1185", "id": 759066777, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTA2Njc3Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T22:07:58Z", "updated_at": "2021-01-12T22:07:58Z", "author_association": "OWNER", "body": "https://docs.datasette.io/en/stable/sql_queries.html?highlight=pragma#named-parameters documentation is out-of-date as well:\r\n\r\n> Datasette disallows custom SQL containing the string PRAGMA, as SQLite pragma statements can be used to change database settings at runtime. If you need to include the string \"pragma\" in a query you can do so safely using a named parameter.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 784628163, "label": "\"Statement may not contain PRAGMA\" error is not strictly true"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-758668359", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 758668359, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODY2ODM1OQ==", "user": {"value": 6739646, "label": "tballison"}, "created_at": "2021-01-12T13:52:29Z", "updated_at": "2021-01-12T13:52:29Z", "author_association": "NONE", "body": "Y, thank you to both of you!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-758448525", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 758448525, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODQ0ODUyNQ==", "user": {"value": 19328961, "label": "henry501"}, "created_at": "2021-01-12T06:55:08Z", "updated_at": "2021-01-12T06:55:08Z", "author_association": "NONE", "body": "Great, really happy I could help! Reverse proxies get tricky.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1183#issuecomment-758356640", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1183", "id": 758356640, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODM1NjY0MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T02:42:08Z", "updated_at": "2021-01-12T02:42:08Z", "author_association": "OWNER", "body": "Should Datasette have subcommands for this? `datasette enable-counts data.db` and `datasette disable-counts data.db` and `datasette reset-counts data.db` commands?\r\n\r\nMaybe. The `sqlite-utils` CLI tool could be used here instead, but that won't be easily available if Datasette was installed as a standalone binary or using `brew install datasette` or `pipx install datasette`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 782708469, "label": "Take advantage of sqlite-utils cached table counts, if available"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1183#issuecomment-758356097", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1183", "id": 758356097, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODM1NjA5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T02:40:30Z", "updated_at": "2021-01-12T02:40:30Z", "author_association": "OWNER", "body": "So how would this work?\r\n\r\nI think I'm going to automatically use these values if the `_counts` table exists, unless a `ignore_counts_table` boolean setting has been set. I won't bother looking to see if the triggers have been created.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 782708469, "label": "Take advantage of sqlite-utils cached table counts, if available"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-758283074", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 758283074, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODI4MzA3NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-11T23:12:46Z", "updated_at": "2021-01-11T23:12:46Z", "author_association": "OWNER", "body": "Fantastic!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-758280611", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 758280611, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODI4MDYxMQ==", "user": {"value": 6739646, "label": "tballison"}, "created_at": "2021-01-11T23:06:10Z", "updated_at": "2021-01-11T23:06:10Z", "author_association": "NONE", "body": "+1\r\n\r\nYep!  Fixes it.  If I navigate to https://corpora.tika.apache.org/datasette, I get a 404 (database not found: datasette), but if I navigate to https://corpora.tika.apache.org/datasette/file_profiles/, everything WORKS!\r\n\r\nThank you!", "reactions": "{\"total_count\": 1, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 1, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null}