{"html_url": "https://github.com/simonw/datasette/issues/2214#issuecomment-1844819002", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2214", "id": 1844819002, "node_id": "IC_kwDOBm6k_c5t9bQ6", "user": {"value": 2874, "label": "precipice"}, "created_at": "2023-12-07T07:36:33Z", "updated_at": "2023-12-07T07:36:33Z", "author_association": "NONE", "body": "If I uncheck `expand labels` in the Advanced CSV export dialog, the error does not occur. Re-checking that box and re-running the export does cause the error to occur.\r\n\r\n![CleanShot 2023-12-06 at 23 34 58@2x](https://github.com/simonw/datasette/assets/2874/12c6c241-35ce-4ded-8dc7-fc250d809ed9)\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 2029908157, "label": "CSV export fails for some `text` foreign key references"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/606#issuecomment-1843579184", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/606", "id": 1843579184, "node_id": "IC_kwDOCGYnMM5t4skw", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-12-06T19:43:55Z", "updated_at": "2023-12-06T19:43:55Z", "author_association": "OWNER", "body": "Updated documentation:\r\n- https://sqlite-utils.datasette.io/en/latest/cli.html#cli-add-column\r\n- https://sqlite-utils.datasette.io/en/latest/cli-reference.html#add-column", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 2029161033, "label": "str and int as aliases for text and integer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/606#issuecomment-1843465748", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/606", "id": 1843465748, "node_id": "IC_kwDOCGYnMM5t4Q4U", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-12-06T18:36:51Z", "updated_at": "2023-12-06T18:36:51Z", "author_association": "OWNER", "body": "I'll add `bytes` too - `float` already works. This makes sense because when you are working with the Python API you use `str` and `float` and `bytes` and `int` to specify column types.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 2029161033, "label": "str and int as aliases for text and integer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2213#issuecomment-1843072926", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2213", "id": 1843072926, "node_id": "IC_kwDOBm6k_c5t2w-e", "user": {"value": 536941, "label": "fgregg"}, "created_at": "2023-12-06T15:05:44Z", "updated_at": "2023-12-06T15:05:44Z", "author_association": "CONTRIBUTOR", "body": "it probably does not make sense to gzip large sqlite database files on the fly. it can take many seconds to gzip a large file and you either have to have this big thing in memory, or write it to disk, which some deployment environments will not like.\r\n\r\ni wonder if it would make sense to gzip the databases as part of the datasette publish process. it would be very cool to statically serve those as if they dynamically zipped (i.e. serve the filename example.db, not example.db.zip, and rely on the browser to expand).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 2028698018, "label": "feature request: gzip compression of database downloads"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/605#issuecomment-1846554637", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/605", "id": 1846554637, "node_id": "IC_kwDOCGYnMM5uEDAN", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-12-08T05:07:54Z", "updated_at": "2023-12-08T05:07:54Z", "author_association": "OWNER", "body": "Thanks for opening an issue - this should help future Google searchers figure out what's going on here.\r\n\r\nAnother approach here could be to store large integers as `TEXT` in SQLite (or even as `BLOB`).\r\n\r\nBoth storing as `REAL` and storing as `TEXT/BLOB` feel nasty to me, but it looks like SQLite has a hard upper limit of 9223372036854775807 for integers.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 2007893839, "label": "Insert fails with `Error: Python int too large to convert to SQLite INTEGER`; can we use `NUMERIC` here?"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/604#issuecomment-1846560096", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/604", "id": 1846560096, "node_id": "IC_kwDOCGYnMM5uEEVg", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-12-08T05:16:44Z", "updated_at": "2023-12-08T05:17:20Z", "author_association": "OWNER", "body": "Also tested this manually like so:\r\n\r\n```bash\r\nsqlite-utils create-table strict.db strictint id integer size integer --strict\r\nsqlite-utils create-table strict.db notstrictint id integer size integer \r\nsqlite-utils install sqlite-utils-shell\r\nsqlite-utils shell strict.db \r\n```\r\n```\r\nAttached to strict.db\r\nType 'exit' to exit.\r\nsqlite-utils> insert into strictint (size) values (4);\r\n1 row affected\r\nsqlite-utils> insert into strictint (size) values ('four');\r\nAn error occurred: cannot store TEXT value in INTEGER column strictint.size\r\nsqlite-utils> insert into notstrictint (size) values ('four');\r\n1 row affected\r\nsqlite-utils> commit;\r\nDone\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 2001006157, "label": "Add more STRICT table support"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/604#issuecomment-1843975536", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/604", "id": 1843975536, "node_id": "IC_kwDOCGYnMM5t6NVw", "user": {"value": 16437338, "label": "tkhattra"}, "created_at": "2023-12-07T01:17:05Z", "updated_at": "2023-12-07T01:17:05Z", "author_association": "CONTRIBUTOR", "body": "Apologies - I pushed a fix that addresses the mypy failures.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 2001006157, "label": "Add more STRICT table support"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/604#issuecomment-1843586503", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/604", "id": 1843586503, "node_id": "IC_kwDOCGYnMM5t4uXH", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-12-06T19:49:10Z", "updated_at": "2023-12-06T19:49:29Z", "author_association": "OWNER", "body": "This looks really great on first glance - design is good, implementation is solid, tests and documentation look great.\r\n\r\nLooks like a couple of `mypy` failures in the tests at the moment:\r\n\r\n```\r\n mypy sqlite_utils tests\r\n\r\nsqlite_utils/db.py:543: error: Incompatible types in assignment (expression has type \"type[Table]\", variable has type \"type[View]\") [assignment]\r\ntests/test_lookup.py:156: error: Name \"test_lookup_new_table\" already defined on line 5 [no-redef]\r\nFound 2 errors in 2 files (checked 54 source files)\r\nError: Process completed with exit code 1.\r\n```\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 2001006157, "label": "Add more STRICT table support"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/604#issuecomment-1843585454", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/604", "id": 1843585454, "node_id": "IC_kwDOCGYnMM5t4uGu", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2023-12-06T19:48:26Z", "updated_at": "2023-12-08T05:05:03Z", "author_association": "NONE", "body": "## [Codecov](https://app.codecov.io/gh/simonw/sqlite-utils/pull/604?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\nAll modified and coverable lines are covered by tests :white_check_mark:\n> Comparison is base [(`9286c1b`)](https://app.codecov.io/gh/simonw/sqlite-utils/commit/9286c1ba432e890b1bb4b2a1f847b15364c1fa18?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 95.77% compared to head [(`1698a9d`)](https://app.codecov.io/gh/simonw/sqlite-utils/pull/604?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 95.72%.\n> Report is 1 commits behind head on main.\n\n> :exclamation: Current head 1698a9d differs from pull request most recent head 61c6e26. Consider uploading reports for the commit 61c6e26 to get more accurate results\n\n\nAdditional details and impacted files
\n\n\n```diff\n@@ Coverage Diff @@\n## main #604 +/- ##\n==========================================\n- Coverage 95.77% 95.72% -0.06% \n==========================================\n Files 8 8 \n Lines 2842 2852 +10 \n==========================================\n+ Hits 2722 2730 +8 \n- Misses 120 122 +2 \n```\n\n\n\nAdditional details and impacted files
\n\n\n```diff\n@@ Coverage Diff @@\n## main #2209 +/- ##\n=======================================\n Coverage 92.69% 92.69% \n=======================================\n Files 40 40 \n Lines 6047 6047 \n=======================================\n Hits 5605 5605 \n Misses 442 442 \n```\n\n\n\n