{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-1012653109", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 1012653109, "node_id": "IC_kwDOBm6k_c48W9w1", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-14T00:57:08Z", "updated_at": "2022-01-14T00:57:08Z", "author_association": "OWNER", "body": "Bug is fixed on https://latest.datasette.io/fixtures/facetable?_sort=pk&_city_id__gt=1", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-1012635696", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 1012635696, "node_id": "IC_kwDOBm6k_c48W5gw", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-14T00:19:10Z", "updated_at": "2022-01-14T00:20:36Z", "author_association": "OWNER", "body": "Oh! This is because `_city_id` has a leading underscore (for testing purposes). I think I need to filter out any keys that contain `__` in that case.\r\n\r\nWhat happens to columns that contain a `__`? They shouldn't be reflected in the hidden arguments either - this code is really only supposed to catch things like `_where` and `_m2m_through=` and `_col` - basically most of the list on https://docs.datasette.io/en/stable/json_api.html#special-table-arguments", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-1012634659", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 1012634659, "node_id": "IC_kwDOBm6k_c48W5Qj", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-14T00:17:00Z", "updated_at": "2022-01-14T00:18:11Z", "author_association": "OWNER", "body": "That's because that page has this unnecessary hidden form field:\r\n```html\r\n<input type=\"hidden\" name=\"_city_id__gt\" value=\"1\">\r\n```\r\nThat field is added by this bit in the template: https://github.com/simonw/datasette/blob/515f8d38ebae203efc15ca79a8b42848276b35e5/datasette/templates/table.html#L119-L122\r\n\r\nWhich is populated here:  https://github.com/simonw/datasette/blob/ace86566b28280091b3844cf5fbecd20158e9004/datasette/views/table.py#L813-L821\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-988154238", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 988154238, "node_id": "IC_kwDOBm6k_c465gl-", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-07T18:05:26Z", "updated_at": "2021-12-07T18:05:26Z", "author_association": "OWNER", "body": "Found a new case of this bug: click the \"Apply\" button on https://latest.datasette.io/fixtures/facetable?_sort=pk&_city_id__gt=1\r\n\r\n![apply-bug](https://user-images.githubusercontent.com/9599/145082760-6947c769-480f-45c7-9916-b6cc7f5834f8.gif)\r\n\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-982318745", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 982318745, "node_id": "IC_kwDOBm6k_c46jP6Z", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-30T06:11:21Z", "updated_at": "2021-11-30T06:11:21Z", "author_association": "OWNER", "body": "Manually tested this too, looks like that fixed it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-982235541", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 982235541, "node_id": "IC_kwDOBm6k_c46i7mV", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-30T02:57:34Z", "updated_at": "2021-11-30T02:58:44Z", "author_association": "OWNER", "body": "I started fiddling with a test for this which extracts the `<select>` options and ALL of the `<input>` fields, but I probably won't use it:\r\n```python\r\ndef test_exact_parameter_results_in_correct_hidden_fields(app_client):\r\n    # https://github.com/simonw/datasette/issues/1527\r\n    response = app_client.get(\r\n        \"/fixtures/facetable?_facet=_neighborhood&_neighborhood__exact=Downtown\"\r\n    )\r\n    # In this case we should NOT have a hidden _neighborhood__exact=Downtown field\r\n    form = Soup(response.body, \"html.parser\").find(\"form\")\r\n    selects = [\r\n        {\r\n            \"name\": select[\"name\"],\r\n            \"value\": select.select(\"option[selected]\")[0].text\r\n            if select.select(\"option[selected]\")\r\n            else \"\",\r\n        }\r\n        for select in form.findAll(\"select\")\r\n    ]\r\n    inputs = [input.attrs for input in form.findAll(\"input\")]\r\n    # Turn those both into a {name: (value, type)} array\r\n    form_inputs = {}\r\n    form_inputs.update(\r\n        {select[\"name\"]: (select[\"value\"], \"select\") for select in selects}\r\n    )\r\n    form_inputs.update(\r\n        {\r\n            input[\"name\"]: (input.get(\"value\"), input[\"type\"])\r\n            for input in inputs\r\n            if input.get(\"name\")\r\n        }\r\n    )\r\n    assert form_inputs == {\r\n        \"_filter_column_1\": (\"_neighborhood\", \"select\"),\r\n        \"_filter_op_1\": (\"=\", \"select\"),\r\n        \"_filter_value_1\": (\"Downtown\", \"text\"),\r\n        \"_filter_column\": (\"\", \"select\"),\r\n        \"_filter_op\": (\"\", \"select\"),\r\n        \"_filter_value\": (None, \"text\"),\r\n        \"_sort\": (\"Sort by pk\", \"select\"),\r\n        \"_sort_by_desc\": (None, \"checkbox\"),\r\n        \"_facet\": (\"_neighborhood\", \"hidden\"),\r\n        \"_neighborhood__exact\": (\"Downtown\", \"hidden\"),\r\n    }\r\n```\r\nThe problem is that last hidden field, `_neighborhood__exact=Downtown` - which should not be there.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-974979785", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 974979785, "node_id": "IC_kwDOBm6k_c46HQLJ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-22T01:02:57Z", "updated_at": "2021-11-22T01:03:19Z", "author_association": "OWNER", "body": "I think the root cause is this hidden form field on https://latest.datasette.io/fixtures/facetable?_facet=_neighborhood&_neighborhood__exact=Downtown\r\n```html\r\n            <input type=\"hidden\" name=\"_facet\" value=\"_neighborhood\">\r\n            <input type=\"hidden\" name=\"_neighborhood__exact\" value=\"Downtown\">\r\n        <input type=\"submit\" value=\"Apply\">\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}