{"html_url": "https://github.com/simonw/datasette/pull/1842#issuecomment-1288311852", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1842", "id": 1288311852, "node_id": "IC_kwDOBm6k_c5MyhQs", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-10-24T02:11:12Z", "updated_at": "2022-10-24T02:11:12Z", "author_association": "OWNER", "body": "I'm going to construct a `metadata.yml` which makes various databases and tables visible or invisible, then browse them using the root user.\r\n\r\n`block-instance.yml`:\r\n\r\n```yaml\r\nallow:\r\n id: root\r\n```\r\n`block-database.yml`:\r\n```yaml\r\ndatabases:\r\n fixtures:\r\n allow:\r\n id: root\r\n```\r\n`block-table.yml`:\r\n```yaml\r\ndatabases:\r\n fixtures:\r\n tables:\r\n searchable:\r\n allow:\r\n id: root\r\n```\r\n`block-query.yml`:\r\n```yaml\r\ndatabases:\r\n fixtures:\r\n queries:\r\n two:\r\n sql: select 1 + 1\r\n allow:\r\n id: root\r\n```\r\nhttps://gist.github.com/simonw/2d007ebe43de46d44499c77a2a291756 - checkout that Gist to get all four.\r\n\r\nI manually tested all four scenarios with root and non-root users and confirmed that they worked correctly and padlocks were shown in the right places.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1408561039, "label": "check_visibility can now take multiple permissions into account"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1842#issuecomment-1278306180", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1842", "id": 1278306180, "node_id": "IC_kwDOBm6k_c5MMWeE", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2022-10-14T00:11:46Z", "updated_at": "2022-10-24T02:04:52Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\nBase: **92.52**% // Head: **92.54**% // Increases project coverage by **`+0.02%`** :tada:\n> Coverage data is based on head [(`3623475`)](https://codecov.io/gh/simonw/datasette/pull/1842?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) compared to base [(`79aa0de`)](https://codecov.io/gh/simonw/datasette/commit/79aa0de083d38a9975915d5a4cc68ca6c74fbe3d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> Patch coverage: 100.00% of modified lines in pull request are covered.\n\nAdditional details and impacted files
\n\n\n```diff\n@@ Coverage Diff @@\n## main #1842 +/- ##\n==========================================\n+ Coverage 92.52% 92.54% +0.02% \n==========================================\n Files 35 35 \n Lines 4415 4428 +13 \n==========================================\n+ Hits 4085 4098 +13 \n Misses 330 330 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `94.28% <100.00%> (+0.05%)` | :arrow_up: |\n| [datasette/views/database.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL2RhdGFiYXNlLnB5) | `95.29% <100.00%> (+0.06%)` | :arrow_up: |\n| [datasette/views/index.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL2luZGV4LnB5) | `96.49% <100.00%> (\u00f8)` | |\n| [datasette/views/row.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3Jvdy5weQ==) | `88.70% <100.00%> (+0.37%)` | :arrow_up: |\n| [datasette/views/table.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3RhYmxlLnB5) | `95.20% <100.00%> (+0.01%)` | :arrow_up: |\n\nHelp us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n