{"html_url": "https://github.com/simonw/datasette/issues/69#issuecomment-344048656", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/69", "id": 344048656, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NDA0ODY1Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-13T20:32:47Z", "updated_at": "2017-11-13T20:32:47Z", "author_association": "OWNER", "body": "<img width=\"908\" alt=\"ak\" src=\"https://user-images.githubusercontent.com/9599/32745247-071aa764-c867-11e7-9748-88e22f5eee57.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273248366, "label": "Enforce pagination (or at least limits) for arbitrary custom SQL"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/69#issuecomment-344019631", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/69", "id": 344019631, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NDAxOTYzMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-13T18:53:13Z", "updated_at": "2017-11-13T18:53:13Z", "author_association": "OWNER", "body": "I'm going with a page size of 100 and a max limit of 1000", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273248366, "label": "Enforce pagination (or at least limits) for arbitrary custom SQL"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/69#issuecomment-343780039", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/69", "id": 343780039, "node_id": "MDEyOklzc3VlQ29tbWVudDM0Mzc4MDAzOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-13T00:05:27Z", "updated_at": "2017-11-13T00:05:27Z", "author_association": "OWNER", "body": "I think the only safe way to do this is using SQLite `.fetchmany(1000)` - I can't guarantee that the user has not entered SQL that will outfox a limit in some way. So instead of attempting to edit their SQL, I'll always return 1001 records and let them know if they went over 1000 or not.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273248366, "label": "Enforce pagination (or at least limits) for arbitrary custom SQL"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/69#issuecomment-343752579", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/69", "id": 343752579, "node_id": "MDEyOklzc3VlQ29tbWVudDM0Mzc1MjU3OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-12T17:22:39Z", "updated_at": "2017-11-12T17:22:39Z", "author_association": "OWNER", "body": "By default I'll allow LIMIT and OFFSET up to a maximum of X (where X is let's say 50,000 to start with, but can be custom configured to a larger number or set to None for no limit).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273248366, "label": "Enforce pagination (or at least limits) for arbitrary custom SQL"}, "performed_via_github_app": null}