{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-344667202", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 344667202, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NDY2NzIwMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-15T17:29:38Z", "updated_at": "2017-11-15T17:29:38Z", "author_association": "OWNER", "body": "@jacobian points out that a buildpack may be a better fit than a Docker container for implementing this: https://twitter.com/jacobian/status/930849058465255424", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-344680385", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 344680385, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NDY4MDM4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-15T18:14:11Z", "updated_at": "2017-11-15T18:14:11Z", "author_association": "OWNER", "body": "Maybe we don\u2019t even need a buildpack... we could create a temporary directory, set up a classic heroku app with the datasette serve command in the Procfile and then git push to deploy.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-344686483", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 344686483, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NDY4NjQ4Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-15T18:36:23Z", "updated_at": "2017-11-15T18:36:23Z", "author_association": "OWNER", "body": "The \u201cdatasette build\u201d command would need to run in a bin/post_compile script eg https://github.com/simonw/simonwillisonblog/blob/cloudflare-ips/bin/post_compile", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-344687328", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 344687328, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NDY4NzMyOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-15T18:39:14Z", "updated_at": "2017-11-15T18:39:49Z", "author_association": "OWNER", "body": "By default the command could use a temporary directory that gets cleaned up after the deploy, but we could allow users to opt in to keeping the generated directory like so:\r\n\r\n    datasette publish heroku mydb.py -d ~/dev/my-heroku-app\r\n\r\nThis would create the my-heroku-app folder so you can later execute further git deploys from there.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-346161985", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 346161985, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NjE2MTk4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-21T21:10:22Z", "updated_at": "2017-11-21T21:10:22Z", "author_association": "OWNER", "body": "Woohoo!\r\n\r\nI've found one tiny issue: right now, the following doesn't work:\r\n\r\n    datasette publish heroku ../demo-databses/google-trends.db\r\n\r\nIt results in this error in the Heroku logs:\r\n\r\n    2017-11-21T21:03:29.210511+00:00 app[web.1]: Usage: datasette serve [OPTIONS] [FILES]...\r\n    2017-11-21T21:03:29.210524+00:00 app[web.1]: \r\n    2017-11-21T21:03:29.210555+00:00 app[web.1]: Error: Invalid value for \"files\": Path \"../demo-databses/google-trends.db\" does not exist.\r\n\r\nThe command works fine if you run it in the same directory as the database file you are publishing.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-346163513", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 346163513, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NjE2MzUxMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-21T21:16:16Z", "updated_at": "2017-11-21T21:16:16Z", "author_association": "OWNER", "body": "The reason relative paths work for `publish now` is that the `make_dockerfile()` function is called by passing the file names, not the full file paths:\r\n\r\nhttps://github.com/simonw/datasette/blob/e47117ce1d15f11246a3120aa49de70205713d05/datasette/utils.py#L166\r\n\r\nClearly the correct thing to do here is for us to refactor the shared code between heroku/package/now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-350521711", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 350521711, "node_id": "MDEyOklzc3VlQ29tbWVudDM1MDUyMTcxMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-12-10T03:05:48Z", "updated_at": "2017-12-10T03:05:48Z", "author_association": "OWNER", "body": "I fixed that last issue in c195ee4d46f2577b1943836a8270d84c8341d138", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-350521736", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 350521736, "node_id": "MDEyOklzc3VlQ29tbWVudDM1MDUyMTczNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-12-10T03:06:34Z", "updated_at": "2017-12-10T03:06:34Z", "author_association": "OWNER", "body": "Heroku is now in the README as of 6bdfcf60760c27e29ff34692d06e62b36aeecc56", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}