{"html_url": "https://github.com/simonw/datasette/issues/189#issuecomment-377547265", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/189", "id": 377547265, "node_id": "MDEyOklzc3VlQ29tbWVudDM3NzU0NzI2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-03-30T15:16:43Z", "updated_at": "2018-03-30T15:16:43Z", "author_association": "OWNER", "body": "I think this is the right incantation for a \"next\" link: https://datasette-column-sort-wip.now.sh/sortable-4bbaa6f?sql=select+*+from+sortable%0D%0Awhere+sortable+%3C%3D+94%0D%0Aand+%28%0D%0A++%28pk1+%3E+%27d%27%29%0D%0A++or%0D%0A++%28pk1+%3D+%27d%27+and+pk2+%3E+%27w%27%29%0D%0A%29%0D%0Aorder+by+sortable+desc%2C+pk1%2C+pk2%0D%0Alimit+7", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 309471814, "label": "Ability to sort (and paginate) by column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/189#issuecomment-377459579", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/189", "id": 377459579, "node_id": "MDEyOklzc3VlQ29tbWVudDM3NzQ1OTU3OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-03-30T06:47:52Z", "updated_at": "2018-03-30T06:47:52Z", "author_association": "OWNER", "body": "I'm not entirely sure how to get `_next=` pagination working against sorted collections when a tie-breaker is needed.\r\n\r\nConsider this data:\r\n\r\nhttps://fivethirtyeight.datasettes.com/fivethirtyeight-2628db9?sql=select+rowid%2C+*+from+%5Bnfl-wide-receivers%2Fadvanced-historical%5D%0D%0Aorder+by+case+when+career_ranypa+is+null+then+1+else+0+end%2C+career_ranypa%2C+rowid+limit+11\r\n\r\n\r\n\r\nIf the page size was set to 9 rather than 11, the page divide would be between those two rows with the same value in the `career_ranypa` column. What would the `?_next=` token look like such that the correct row would be returned?\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 309471814, "label": "Ability to sort (and paginate) by column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/189#issuecomment-377462334", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/189", "id": 377462334, "node_id": "MDEyOklzc3VlQ29tbWVudDM3NzQ2MjMzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-03-30T07:06:21Z", "updated_at": "2018-03-30T07:06:21Z", "author_association": "OWNER", "body": "Maybe the answer here is that anything that's encoded in the next token is treated as >= with the exception of columns known to be primary keys, which are treated as >", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 309471814, "label": "Ability to sort (and paginate) by column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/189#issuecomment-377546510", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/189", "id": 377546510, "node_id": "MDEyOklzc3VlQ29tbWVudDM3NzU0NjUxMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-03-30T15:13:11Z", "updated_at": "2018-03-30T15:13:11Z", "author_association": "OWNER", "body": "Pushed some work-in-progress with failing unit tests here: https://github.com/simonw/datasette/commit/2f8359c6f25768805431c80c74e5ec4213c2b2a6\r\n\r\nHere's a demo: https://datasette-column-sort-wip.now.sh/sortable-4bbaa6f/sortable?_sort=sortable - note that the `_sort_desc` and `_sort_nulls_last` options aren't done yet, plus it doesn't correctly paginate (the `_next` tokens do not yet take sorting into account).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 309471814, "label": "Ability to sort (and paginate) by column"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/189#issuecomment-377460127", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/189", "id": 377460127, "node_id": "MDEyOklzc3VlQ29tbWVudDM3NzQ2MDEyNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-03-30T06:51:29Z", "updated_at": "2018-03-30T06:51:52Z", "author_association": "OWNER", "body": "The problem is that our `_next=` pagination currently works based on a `>` - but for this case a `>=` for the value is needed combined with a `>` on the tie-breaker (which would be the `rowid` column).\r\n\r\nSo I think this is the right SQL:\r\n\r\n```\r\nselect rowid, * from [nfl-wide-receivers/advanced-historical]\r\nwhere career_ranypa >= -6.331167749 and rowid > 2736\r\norder by case when career_ranypa is null then 1 else 0 end, career_ranypa, rowid limit 11\r\n```\r\n\r\nhttps://fivethirtyeight.datasettes.com/fivethirtyeight-2628db9?sql=select+rowid%2C+*+from+%5Bnfl-wide-receivers%2Fadvanced-historical%5D%0D%0Awhere+career_ranypa+%3E%3D+-6.331167749+and+rowid+%3E+2736%0D%0Aorder+by+case+when+career_ranypa+is+null+then+1+else+0+end%2C+career_ranypa%2C+rowid+limit+11\r\n\r\nBut how do I encode a `_next` token that means \">= X and > Y\"?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 309471814, "label": "Ability to sort (and paginate) by column"}, "performed_via_github_app": null}