{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-392969173", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 392969173, "node_id": "MDEyOklzc3VlQ29tbWVudDM5Mjk2OTE3Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-29T22:32:08Z", "updated_at": "2018-05-29T22:32:08Z", "author_association": "OWNER", "body": "The more time I spend with SpatiaLite the more convinced I am that this should be default behavior. There's nothing useful about the binary Geometry representation - it's not even valid WKB. I'm on board with WKT as the default display in HTML and GeoJSON as the default for `.json`", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-392825746", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 392825746, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MjgyNTc0Ng==", "user": {"value": 45057, "label": "russss"}, "created_at": "2018-05-29T15:42:53Z", "updated_at": "2018-05-29T15:42:53Z", "author_association": "CONTRIBUTOR", "body": "I haven't had time to look further into this, but if doing this as a plugin results in useful hooks then I think we should do it that way. We could always require the plugin as a standard dependency. \r\n\r\nI think this is going to result in quite a bit of refactoring anyway so it's a good time to add hooks regardless. \r\n\r\nOn the other hand, if we have to add lots of specialist hooks for it then maybe it's worth integrating into the core.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-392815673", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 392815673, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MjgxNTY3Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-29T15:17:04Z", "updated_at": "2018-05-29T15:17:04Z", "author_association": "OWNER", "body": "I'm coming round to the idea that this should be baked into Datasette core - see above referenced issues for some of the explorations I've been doing around this area.\r\n\r\nDatasette should absolutely work without SpatiaLite, but it's such a huge bonus part of the SQLite ecosystem that I'm happy to ship features that take advantage of it without being relegated to plugins.\r\n\r\nI'm also becoming aware that there aren't really that many other interesting loadable extensions for SQLite. If SpatiaLite was one of dozens I'd feel that a rule that \"anything dependent on an extension lives in a plugin\" would make sense, but as it stands I think 99% of the time the only loadable extensions people will be using will be SpatiaLite and json1 (and json1 is available in the amalgamation anyway).\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}