{"html_url": "https://github.com/simonw/datasette/issues/777#issuecomment-640957423", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/777", "id": 640957423, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MDk1NzQyMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-09T00:29:03Z", "updated_at": "2020-06-09T00:29:03Z", "author_association": "OWNER", "body": "Here's why:\r\n\r\nhttps://github.com/simonw/datasette/blob/49d6d2f7b0f6cb02e25022e1c9403811f1fa0a7c/datasette/app.py#L1024-L1029\r\n\r\n404 errors are rendered by looking for a template from `[\"404.html\", \"500.html\"]`.\r\n\r\n`404.html` doesn't actually ship with Datasette (plugins or custom template directories can provide it). So the `500.html` template is used.\r\n\r\nThat template extends `base.html`, which expects there to be `base_url` and `app_css_hash` variables. But as you can see in the excerpt above, those variables are not being passed to the template context when the error page is rendered.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626171242, "label": "Error pages not correctly loading CSS"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/777#issuecomment-640955788", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/777", "id": 640955788, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MDk1NTc4OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-09T00:23:26Z", "updated_at": "2020-06-09T00:23:57Z", "author_association": "OWNER", "body": "Clue: https://latest.datasette.io/404 displays correctly but https://latest.datasette.io/fixtures/404 does not.\r\n\r\nThat's because `<link rel=\"stylesheet\" href=\"-/static/app.css?\">` does the correct thing if you are on the root of the site but not if you are in a sub-directory.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626171242, "label": "Error pages not correctly loading CSS"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/777#issuecomment-640925018", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/777", "id": 640925018, "node_id": "MDEyOklzc3VlQ29tbWVudDY0MDkyNTAxOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-08T22:41:42Z", "updated_at": "2020-06-08T22:41:42Z", "author_association": "OWNER", "body": "This is particularly worth fixing now that 403 forbidden pages are much more likely due to #811.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626171242, "label": "Error pages not correctly loading CSS"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/777#issuecomment-635513983", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/777", "id": 635513983, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTUxMzk4Mw==", "user": {"value": 63653929, "label": "thisismyfuckingusername"}, "created_at": "2020-05-28T18:16:49Z", "updated_at": "2020-05-28T18:16:49Z", "author_association": "NONE", "body": " think, because the given URL of the CSS file doesn't have any complete parameters after query \r\nTry to complete the parameter \r\n`<link rel=\"stylesheet\" href=\"-/static/app.css?(whatever you want that shows a css file)\">`", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626171242, "label": "Error pages not correctly loading CSS"}, "performed_via_github_app": null}