{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-754187520", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 754187520, "node_id": "MDEyOklzc3VlQ29tbWVudDc1NDE4NzUyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-04T20:04:10Z", "updated_at": "2021-01-04T20:04:10Z", "author_association": "OWNER", "body": "That's pretty elegant: each plugin gets its own namespace and can register new settings.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-754187326", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 754187326, "node_id": "MDEyOklzc3VlQ29tbWVudDc1NDE4NzMyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-04T20:03:50Z", "updated_at": "2021-01-04T20:03:50Z", "author_association": "OWNER", "body": "I renamed `--config` to `--setting` and changed it to work like this:\r\n\r\n    datasette --setting sql_time_limit_ms 1000\r\n\r\nNote the lack of colons.\r\n\r\nThis actually makes colons cleaner to use for plugins - I could support this:\r\n\r\n    datasette --setting datasette-insert:unsafe 1", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-667430352", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 667430352, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQzMDM1Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:52:10Z", "updated_at": "2020-07-31T23:52:10Z", "author_association": "OWNER", "body": "The bigger question here is when this mechanism should be used in place of `metadata.json` or `metadata.yml`. Especially since I'm already considering renaming or reworking that mechanism since plugin configuration has nothing to do with database metadata: #493", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-667429616", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 667429616, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQyOTYxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:48:25Z", "updated_at": "2020-07-31T23:49:59Z", "author_association": "OWNER", "body": "I could let plugins add additional options to `datasette serve` - but what if two plugins both try to register an option with the same name?\r\n\r\nA better solution could be to use the existing `--config` option - and allow plugins to register their own, namespaced config options. So you could do things like:\r\n\r\n    datasette my.db --config datasette-insert:unsafe:1\r\n\r\nMaybe even drop the `datasette-` prefix?\r\n\r\n    datasette my.db --config insert:unsafe:1\r\n\r\nI think I prefer keeping the prefix to be honest - it makes it more obvious that this is a setting which comes from a specific named plugin.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-667429690", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 667429690, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQyOTY5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:48:48Z", "updated_at": "2020-07-31T23:48:48Z", "author_association": "OWNER", "body": "Here's the code in Datasette that parses `--config` options at the moment:\r\n\r\nhttps://github.com/simonw/datasette/blob/7ca8c0521ac1ea48a3cd8d0fe9275d1316e54b43/datasette/cli.py#L25-L40", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}