{"html_url": "https://github.com/simonw/datasette/issues/939#issuecomment-674548163", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/939", "id": 674548163, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU0ODE2Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T16:34:30Z", "updated_at": "2020-08-16T16:34:30Z", "author_association": "OWNER", "body": "Docs also need to note that `request` may be `None` for all of these hooks.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679779797, "label": "extra_ plugin hooks should take the same arguments"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/939#issuecomment-674547811", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/939", "id": 674547811, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU0NzgxMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T16:31:20Z", "updated_at": "2020-08-16T16:31:20Z", "author_association": "OWNER", "body": "And the docs need to be updated too.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679779797, "label": "extra_ plugin hooks should take the same arguments"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/939#issuecomment-674547788", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/939", "id": 674547788, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU0Nzc4OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T16:31:08Z", "updated_at": "2020-08-16T16:31:08Z", "author_association": "OWNER", "body": "Also: they should all be able to return `async def` inner functions. At the moment only `extra_template_vars` supports that pattern.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679779797, "label": "extra_ plugin hooks should take the same arguments"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/939#issuecomment-674545058", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/939", "id": 674545058, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU0NTA1OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T16:07:20Z", "updated_at": "2020-08-16T16:07:20Z", "author_association": "OWNER", "body": "I'm going to implement this first as a single commit, then implement `columns` from #938 as a separate change.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679779797, "label": "extra_ plugin hooks should take the same arguments"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/939#issuecomment-674544973", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/939", "id": 674544973, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU0NDk3Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T16:06:34Z", "updated_at": "2020-08-16T16:06:34Z", "author_association": "OWNER", "body": "They should also be next to each other in the documentation - right now they're a bit scattered in terms of page order:\r\n\r\n<img width=\"598\" alt=\"Plugin_hooks_\u2014_Datasette_documentation\" src=\"https://user-images.githubusercontent.com/9599/90338620-c5d3af00-df9f-11ea-908b-3f888947dd03.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679779797, "label": "extra_ plugin hooks should take the same arguments"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/939#issuecomment-674544875", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/939", "id": 674544875, "node_id": "MDEyOklzc3VlQ29tbWVudDY3NDU0NDg3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-16T16:05:36Z", "updated_at": "2020-08-16T16:05:36Z", "author_association": "OWNER", "body": "They should all take:\r\n\r\n    template, database, table, view_name, request, datasette, columns\r\n\r\n`columns` is new, see #938.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 679779797, "label": "extra_ plugin hooks should take the same arguments"}, "performed_via_github_app": null}