{"html_url": "https://github.com/simonw/sqlite-utils/issues/167#issuecomment-696565981", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/167", "id": 696565981, "node_id": "MDEyOklzc3VlQ29tbWVudDY5NjU2NTk4MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-22T07:53:13Z", "updated_at": "2020-09-22T07:53:13Z", "author_association": "OWNER", "body": "Confirmed this is a bug, https://www.sqlite.org/lang_altertable.html#making_other_kinds_of_table_schema_changes explicitly says you should do the `PRAGMA foreign_keys` bits before and after the transaction, not during.\r\n\r\nRight now my code does this INSIDE the transaction: https://github.com/simonw/sqlite-utils/blob/f29f6821f2d08e91c5c6d65d885a1bbc0c743bdd/sqlite_utils/db.py#L790-L793\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 706098005, "label": "Review the foreign key pragma stuff"}, "performed_via_github_app": null}