{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701707116", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701707116, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTcwNzExNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T23:58:17Z", "updated_at": "2020-09-30T23:58:17Z", "author_association": "OWNER", "body": "Now live at https://latest.datasette.io/fixtures/facetable\r\n\r\n<img width=\"1264\" alt=\"fixtures__facetable__15_rows\" src=\"https://user-images.githubusercontent.com/9599/94751748-1f205380-033e-11eb-940b-bb4ee7728d31.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701704716", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701704716, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTcwNDcxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T23:48:36Z", "updated_at": "2020-09-30T23:48:36Z", "author_association": "OWNER", "body": "Since this menu doesn't provide new functionality, I'm going to ignore the fact that it doesn't exist on portrait mobile view for the moment. Likewise, I'm going to skip making it accessible for the moment since lacking accessibility doesn't prevent functionality from being accessed - the menu-less experience currently works the same as the portrait mobile experience.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701703472", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701703472, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTcwMzQ3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T23:43:30Z", "updated_at": "2020-09-30T23:43:30Z", "author_association": "OWNER", "body": "I'm going to go based just on the visible values on the current page. I think that's good enough, and it avoids the complexity involved in doing a server-side check for blank values.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701697918", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701697918, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY5NzkxOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T23:24:14Z", "updated_at": "2020-09-30T23:25:28Z", "author_association": "OWNER", "body": "I could provide the \"Show non-blank values\" option only for columns where there are blank values visible on the current page.\r\n\r\nThis could be a bit confusing though, since the absence of that option could suggest that there are no blank values at all when that's actually not true.\r\n\r\nOne option: run a separate `fetch()` call that figures out if any of the columns contain blank values, which gets a bit of extra time to execute. Only show the \"Show non-blank values\" option in the menu once that has returned.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701679729", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701679729, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY3OTcyOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T22:26:33Z", "updated_at": "2020-09-30T22:26:33Z", "author_association": "OWNER", "body": "Bug: https://latest.datasette.io/fixtures/sortable?_sort=sortable\r\n\r\n![sort-bug](https://user-images.githubusercontent.com/9599/94746304-4e7c9380-0331-11eb-8e81-7245529c4654.gif)\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701668526", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701668526, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY2ODUyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T21:57:22Z", "updated_at": "2020-09-30T21:57:22Z", "author_association": "OWNER", "body": "A bunch of things to fix:\r\n\r\n- It clobbers existing querystring parameters - it needs to leave these alone (but replace the current sort order)\r\n- Facet option should not show up if you are already faceting by that column\r\n- There's no way to close the menu once it has opened!\r\n- Accessibility: SVG icon doesn't even have an alt attribute yet. Should use ARIA when the thing appears.\r\n\r\nIt's also not visible on mobile, need to think about how that will work.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701664306", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701664306, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY2NDMwNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T21:47:08Z", "updated_at": "2020-09-30T21:47:08Z", "author_association": "OWNER", "body": "The arrow icon didn't make sense because I already have a triangle icon showing sort order. I'm trying a cog icon instead:\r\n\r\n<img width=\"303\" alt=\"data__dogs__10_rows\" src=\"https://user-images.githubusercontent.com/9599/94743176-ce9ffa80-032b-11eb-8f4d-da3962984a4f.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701659197", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701659197, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY1OTE5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T21:34:44Z", "updated_at": "2020-09-30T21:34:44Z", "author_association": "OWNER", "body": "Showing \"facet by this\" on the primary key column doesn't make sense.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701642448", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701642448, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTY0MjQ0OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T20:59:33Z", "updated_at": "2020-09-30T20:59:33Z", "author_association": "OWNER", "body": "I think I've got everything I need to implement this now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701616922", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701616922, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTYxNjkyMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T20:08:02Z", "updated_at": "2020-09-30T20:08:02Z", "author_association": "OWNER", "body": "It would be neat to provide a JavaScript plugin hook that plugins can use to add their own options to this menu. No idea what that would look like though.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701157010", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701157010, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTE1NzAxMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T05:00:42Z", "updated_at": "2020-09-30T20:06:59Z", "author_association": "OWNER", "body": "Maybe use this as the icon:\r\n```svg\r\n<svg width=\"100px\" height=\"100px\" viewBox=\"0 0 255 255\">\r\n  <polygon points=\"0,64 128,191 255,64\"/>\r\n</svg>\r\n```\r\n\r\n<img width=\"41\" alt=\"Real-time_HTML_Editor\" src=\"https://user-images.githubusercontent.com/9599/94734258-d22c8500-031d-11eb-982b-82cde4b1920f.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701615291", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701615291, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTYxNTI5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T20:04:34Z", "updated_at": "2020-09-30T20:05:37Z", "author_association": "OWNER", "body": "Another potential action:\r\n\r\n* Show rows where this is not blank (equivalent to `is not blank` filter)\r\n\r\nThis could be displayed conditionally based on if the column is detected to have any blank rows in it?\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701153543", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701153543, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTE1MzU0Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T04:46:05Z", "updated_at": "2020-09-30T05:11:45Z", "author_association": "OWNER", "body": "Prototype:\r\n```html\r\n<style>\r\nbody {\r\nfont-family: helvetica;\r\n}\r\n.dropdown-menu {\r\n  display: inline-flex;\r\n  border: 1px solid #ccc;\r\n  border-radius: 4px;\r\n  line-height: 1.4;\r\n  font-size: 12px;\r\n  box-shadow: 2px 2px 2px #aaa;\r\n}\r\n.dropdown-menu ul,\r\n.dropdown-menu li {\r\n  list-style-type: none;\r\n  margin: 0;\r\n  padding: 0;\r\n}\r\n.dropdown-menu li {\r\n  border-bottom: 1px solid #ccc;\r\n}\r\n.dropdown-menu li:last-child {\r\n  border: none;\r\n}\r\n.dropdown-menu a:link,\r\n.dropdown-menu a:visited,\r\n.dropdown-menu a:hover,\r\n.dropdown-menu a:focus\r\n.dropdown-menu a:active {\r\n  text-decoration: none;\r\n  display: block;\r\n  padding: 4px 8px 2px 8px;\r\n  color: #222;\r\n  background-color: #fff;\r\n}\r\n.dropdown-menu a:hover {\r\n  background-color: #eee;\r\n}\r\n.hook {\r\n  display: block;\r\n  position: absolute;\r\n  top: 3px;\r\n  left: 12px;\r\n  width: 0; \r\n  height: 0; \r\n  border-left: 5px solid transparent;\r\n  border-right: 5px solid transparent;\r\n  border-bottom: 5px solid #ccc;\r\n}\r\n</style>\r\n<div class=\"dropdown-menu\">\r\n<div class=\"hook\"></div>\r\n<ul>\r\n  <li><a href=\"#\">Sort descending</a></li>\r\n  <li><a href=\"#\">Sort ascending</a></li>\r\n  <li><a href=\"#\">Facet by this</a></li>\r\n  <li><a href=\"#\">Count by this</a></li>\r\n</ul>\r\n</div>\r\n```\r\n<img width=\"148\" alt=\"Real-time_HTML_Editor\" src=\"https://user-images.githubusercontent.com/9599/94643784-7241ca00-029c-11eb-8554-863fcc255352.png\">", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701153982", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701153982, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTE1Mzk4Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T04:47:54Z", "updated_at": "2020-09-30T04:47:54Z", "author_association": "OWNER", "body": "I think the accessible way to do this is with absolute positioning - have a menu icon in the `<th>` which, when clicked, causes the dropdown menu to appear as an absolutely positioned `<div>` that is not located within the DOM hierarchy of the`<th>` itself but is positioned to show up in the correct place.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701153822", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701153822, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTE1MzgyMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T04:47:10Z", "updated_at": "2020-09-30T04:47:10Z", "author_association": "OWNER", "body": "Future version could have expanding out nested side menus that let you do things like \"calculate sum/avg for this column against this-other-column\".", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/981#issuecomment-701153600", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/981", "id": 701153600, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTE1MzYwMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-30T04:46:18Z", "updated_at": "2020-09-30T04:46:18Z", "author_association": "OWNER", "body": "More options:\r\n```html\r\n<ul>\r\n  <li><a href=\"#\">Sort descending</a></li>\r\n  <li><a href=\"#\">Sort ascending</a></li>\r\n  <li><a href=\"#\">Facet by this</a></li>\r\n  <li><a href=\"#\">Unique values</a></li>\r\n  <li><a href=\"#\">Count unique values</a></li>\r\n</ul>\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 711627628, "label": "Action menu for table columns"}, "performed_via_github_app": null}