{"html_url": "https://github.com/simonw/datasette/issues/1442#issuecomment-902243498", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1442", "id": 902243498, "node_id": "IC_kwDOBm6k_c41xySq", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-19T21:04:01Z", "updated_at": "2021-08-19T21:04:01Z", "author_association": "OWNER", "body": "That successfully deployed to https://datasette-latest-deploy-this-branch-j7hipcg4aq-uc.a.run.app/ even though the tests failed.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 974987856, "label": "Mechanism to cause specific branches to deploy their own demos"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1442#issuecomment-902239215", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1442", "id": 902239215, "node_id": "IC_kwDOBm6k_c41xxPv", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-19T20:56:46Z", "updated_at": "2021-08-19T20:56:46Z", "author_association": "OWNER", "body": "I'm going to only run the tests if it's a push to `main` - that way I can ship demo branches really quickly, even if they don't yet have passing tests.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 974987856, "label": "Mechanism to cause specific branches to deploy their own demos"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1442#issuecomment-902235714", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1442", "id": 902235714, "node_id": "IC_kwDOBm6k_c41xwZC", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-19T20:50:38Z", "updated_at": "2021-08-19T20:50:38Z", "author_association": "OWNER", "body": "Would this allow anyone to push a PR to this repo that would result in their code being deployed against my Cloud Run account? I'm reasonably confident that it would not, since the secrets would not be visible to their PR branch.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 974987856, "label": "Mechanism to cause specific branches to deploy their own demos"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1442#issuecomment-902231018", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1442", "id": 902231018, "node_id": "IC_kwDOBm6k_c41xvPq", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-19T20:42:08Z", "updated_at": "2021-08-19T20:42:08Z", "author_association": "OWNER", "body": "If I get this working I should document it on https://docs.datasette.io/en/stable/contributing.html", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 974987856, "label": "Mechanism to cause specific branches to deploy their own demos"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1442#issuecomment-902217726", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1442", "id": 902217726, "node_id": "IC_kwDOBm6k_c41xr_-", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-19T20:21:47Z", "updated_at": "2021-08-19T20:21:47Z", "author_association": "OWNER", "body": "I think the neatest way to implement this would be for the `on -> push -> branches` list to be the list of branches that should be deployed in this way. The rest of the code can react to that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 974987856, "label": "Mechanism to cause specific branches to deploy their own demos"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1442#issuecomment-902191150", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1442", "id": 902191150, "node_id": "IC_kwDOBm6k_c41xlgu", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-19T19:43:05Z", "updated_at": "2021-08-19T19:43:59Z", "author_association": "OWNER", "body": "Maybe as simple as teaching https://github.com/simonw/datasette/blob/main/.github/workflows/deploy-latest.yml to run on pushes to ALL branches:\r\n\r\nhttps://github.com/simonw/datasette/blob/adb5b70de5cec3c3dd37184defe606a082c232cf/.github/workflows/deploy-latest.yml#L3-L6\r\n\r\nAnd then quit early if the branch is not in some allow-list.\r\n\r\nIf it IS in the allow-list, use the name of the branch to dynamically construct the name of the Cloud Run service here: https://github.com/simonw/datasette/blob/adb5b70de5cec3c3dd37184defe606a082c232cf/.github/workflows/deploy-latest.yml#L60\r\n\r\nNeed to skip the documentation build and deployment stuff for other branches though.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 974987856, "label": "Mechanism to cause specific branches to deploy their own demos"}, "performed_via_github_app": null}