{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905022931", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905022931, "node_id": "IC_kwDOCGYnMM418Y3T", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-08-24T22:38:38Z", "updated_at": "2021-08-24T23:27:26Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/321?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#321](https://codecov.io/gh/simonw/sqlite-utils/pull/321?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (db2dd6d) into [main](https://codecov.io/gh/simonw/sqlite-utils/commit/9258f4bd8450c951900de998a7bf81ca9b45a014?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (9258f4b) will **increase** coverage by `0.16%`.\n> The diff coverage is `100.00%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/sqlite-utils/pull/321/graphs/tree.svg?width=650&height=150&src=pr&token=O0X3703L9P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/sqlite-utils/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@            Coverage Diff             @@\n##             main     #321      +/-   ##\n==========================================\n+ Coverage   96.41%   96.58%   +0.16%     \n==========================================\n  Files           5        5              \n  Lines        2206     2223      +17     \n==========================================\n+ Hits         2127     2147      +20     \n+ Misses         79       76       -3     \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/sqlite-utils/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [sqlite\\_utils/cli.py](https://codecov.io/gh/simonw/sqlite-utils/pull/321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-c3FsaXRlX3V0aWxzL2NsaS5weQ==) | `95.69% <100.00%> (+0.42%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/321?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute <relative> (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/321?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [9258f4b...db2dd6d](https://codecov.io/gh/simonw/sqlite-utils/pull/321?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905040902", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905040902, "node_id": "IC_kwDOCGYnMM418dQG", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-24T23:25:03Z", "updated_at": "2021-08-24T23:25:03Z", "author_association": "OWNER", "body": "I'm going to skip this test on windows.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905040307", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905040307, "node_id": "IC_kwDOCGYnMM418dGz", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-24T23:23:36Z", "updated_at": "2021-08-24T23:23:36Z", "author_association": "OWNER", "body": "https://discuss.python.org/t/pep-597-use-utf-8-for-default-text-file-encoding/1819 says:\r\n\r\n> Currently, `TextIOWrapper` uses `locale.getpreferredencoding(False)` (hereinafter called \u201clocale encoding\u201d) when encoding is not specified.\r\n> ...\r\n> Package authors using macOS or Linux may forget that the default encoding\r\nis not always UTF-8.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905039576", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905039576, "node_id": "IC_kwDOCGYnMM418c7Y", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-24T23:21:29Z", "updated_at": "2021-08-24T23:21:29Z", "author_association": "OWNER", "body": "Hah, the error here is actually:\r\n```\r\n>           assert result.exit_code == 1, result.output\r\nE           AssertionError: \r\nE             \r\nE           assert 0 == 1\r\nE            +  where 0 = <Result okay>.exit_code\r\n```\r\nSo I was expecting an error, but instead the command worked.\r\n\r\nI suspect this is because on Windows the default character set may not be UTF-8?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905037323", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905037323, "node_id": "IC_kwDOCGYnMM418cYL", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-24T23:15:29Z", "updated_at": "2021-08-24T23:15:29Z", "author_association": "OWNER", "body": "Huh, tests are failing but only on Windows!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}