{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905040902", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905040902, "node_id": "IC_kwDOCGYnMM418dQG", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-24T23:25:03Z", "updated_at": "2021-08-24T23:25:03Z", "author_association": "OWNER", "body": "I'm going to skip this test on windows.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905040307", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905040307, "node_id": "IC_kwDOCGYnMM418dGz", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-24T23:23:36Z", "updated_at": "2021-08-24T23:23:36Z", "author_association": "OWNER", "body": "https://discuss.python.org/t/pep-597-use-utf-8-for-default-text-file-encoding/1819 says:\r\n\r\n> Currently, `TextIOWrapper` uses `locale.getpreferredencoding(False)` (hereinafter called \u201clocale encoding\u201d) when encoding is not specified.\r\n> ...\r\n> Package authors using macOS or Linux may forget that the default encoding\r\nis not always UTF-8.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905039576", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905039576, "node_id": "IC_kwDOCGYnMM418c7Y", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-24T23:21:29Z", "updated_at": "2021-08-24T23:21:29Z", "author_association": "OWNER", "body": "Hah, the error here is actually:\r\n```\r\n>           assert result.exit_code == 1, result.output\r\nE           AssertionError: \r\nE             \r\nE           assert 0 == 1\r\nE            +  where 0 = <Result okay>.exit_code\r\n```\r\nSo I was expecting an error, but instead the command worked.\r\n\r\nI suspect this is because on Windows the default character set may not be UTF-8?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905037323", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/321", "id": 905037323, "node_id": "IC_kwDOCGYnMM418cYL", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-24T23:15:29Z", "updated_at": "2021-08-24T23:15:29Z", "author_association": "OWNER", "body": "Huh, tests are failing but only on Windows!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 978537855, "label": "Ability to insert file contents as text, in addition to blob"}, "performed_via_github_app": null}