{"html_url": "https://github.com/simonw/datasette/pull/2209#issuecomment-1812750369", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2209", "id": 1812750369, "node_id": "IC_kwDOBm6k_c5sDGAh", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2023-11-15T15:29:37Z", "updated_at": "2023-11-15T15:29:37Z", "author_association": "CONTRIBUTOR", "body": "Looks like tests are passing now but there is an issue with yaml loading and/or cog.\r\n\r\nhttps://github.com/simonw/datasette/actions/runs/6879299298/job/18710911166?pr=2209", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1994861266, "label": "Fix query for suggested facets with column named value"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2209#issuecomment-1812623778", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2209", "id": 1812623778, "node_id": "IC_kwDOBm6k_c5sCnGi", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2023-11-15T14:22:42Z", "updated_at": "2023-11-15T15:24:09Z", "author_association": "CONTRIBUTOR", "body": "Whoops, looks like I forgot to check for other places where the 'facetable' table is used in the tests.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1994861266, "label": "Fix query for suggested facets with column named value"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2208#issuecomment-1812617851", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2208", "id": 1812617851, "node_id": "IC_kwDOBm6k_c5sClp7", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2023-11-15T14:18:58Z", "updated_at": "2023-11-15T14:18:58Z", "author_association": "CONTRIBUTOR", "body": "Without aliases:\r\n\r\n\r\n\r\nThe proposed fix in #2209 also works when the 'value' column is actually facetable (just added another value in the 'value' column).\r\n\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1994857251, "label": "No suggested facets when a column named 'value' is included"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1238#issuecomment-789186458", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1238", "id": 789186458, "node_id": "MDEyOklzc3VlQ29tbWVudDc4OTE4NjQ1OA==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2021-03-02T20:19:30Z", "updated_at": "2021-03-02T20:19:30Z", "author_association": "CONTRIBUTOR", "body": "A custom `templates/index.html` seems to work and custom `pages` as a workaround with moving them to `pages/base_url_dir`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 813899472, "label": "Custom pages don't work with base_url setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391077700", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391077700, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3NzcwMA==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:38:17Z", "updated_at": "2018-05-22T17:38:17Z", "author_association": "CONTRIBUTOR", "body": "Alright, that should work now -- let me know if you would prefer any different behaviour.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391073267", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391073267, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3MzI2Nw==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:24:16Z", "updated_at": "2018-05-22T17:24:16Z", "author_association": "CONTRIBUTOR", "body": "Sorry, just realised you rely on `version` being a module ...", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391073009", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391073009, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3MzAwOQ==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:23:26Z", "updated_at": "2018-05-22T17:23:26Z", "author_association": "CONTRIBUTOR", "body": "> I think I prefer the aesthetics of just \"0.22\" for the version string if it's a tagged release with no additional changes - does that work?\r\n\r\nYes! That's the default versioneer behaviour.\r\n\r\n> I'd like to continue to provide a tuple that can be imported from the version.py module as well, as seen here:\r\n\r\nShould work now, it can be a two (for a tagged version), three or four items tuple.\r\n\r\n```\r\nIn [2]: datasette.__version__\r\nOut[2]: '0.12+292.ga70c2a8.dirty'\r\n\r\nIn [3]: datasette.__version_info__\r\nOut[3]: ('0', '12+292', 'ga70c2a8', 'dirty')\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/273#issuecomment-390250253", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/273", "id": 390250253, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MDI1MDI1Mw==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-18T15:49:52Z", "updated_at": "2018-05-18T15:49:52Z", "author_association": "CONTRIBUTOR", "body": "Shouldn't [versioneer](https://github.com/warner/python-versioneer) do that?\r\n\r\nE.g. 0.21+2.g1076c97\r\n\r\nYou'd need to install via `pip install git+https://github.com/simow/datasette.git` though, this does a temp git clone.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324451322, "label": "Figure out a way to have /-/version return current git commit hash"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/27#issuecomment-345652450", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/27", "id": 345652450, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NTY1MjQ1MA==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2017-11-20T10:19:39Z", "updated_at": "2017-11-20T10:19:39Z", "author_association": "CONTRIBUTOR", "body": "If Data Package metadata gets adopted (#105) the views spec work might also be worth a look:\r\n\r\nhttp://frictionlessdata.io/specs/views/\r\n\r\nhttp://datahub.io/docs/features/views\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 267886330, "label": "Ability to plot a simple graph"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/105#issuecomment-345503897", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/105", "id": 345503897, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NTUwMzg5Nw==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2017-11-19T09:38:08Z", "updated_at": "2017-11-19T09:38:08Z", "author_association": "CONTRIBUTOR", "body": "Thanks, I wrote this very simple reader because the default approach as described on the Datahub pages seemed to complicated. I had metadata from the `datapackage.json` attached to the returned DataFrames but removed this due to some attribute handling change in the latest Pandas version.\r\n\r\nThis could also be useful for getting from Data Package to SQL db: https://github.com/frictionlessdata/tableschema-sql-py\r\n\r\nI maintain a few climate science related dataset at https://github.com/openclimatedata/\r\n\r\nThe Data Retriever (mainly ecological data) by @ethanwhite et al. is also using the Data Package format for metadata and has some tooling for different dbs: \r\n\r\nhttps://frictionlessdata.io/articles/the-data-retriever/\r\nhttps://github.com/weecology/retriever\r\n\r\nThe Open Power System Data project also has a couple of datasets that show nicely how CSV is great for assembling and then already make SQLite files available. It's one of the first data sets I tried with Datasette, perfect for the use case of getting an API for putting power stations on a map ...\r\n\r\nhttps://data.open-power-system-data.org/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 274314940, "label": "Consider data-package as a format for metadata"}, "performed_via_github_app": null}