{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391077700", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391077700, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3NzcwMA==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:38:17Z", "updated_at": "2018-05-22T17:38:17Z", "author_association": "CONTRIBUTOR", "body": "Alright, that should work now -- let me know if you would prefer any different behaviour.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391073267", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391073267, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3MzI2Nw==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:24:16Z", "updated_at": "2018-05-22T17:24:16Z", "author_association": "CONTRIBUTOR", "body": "Sorry, just realised you rely on `version` being a module ...", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391073009", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391073009, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3MzAwOQ==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:23:26Z", "updated_at": "2018-05-22T17:23:26Z", "author_association": "CONTRIBUTOR", "body": "> I think I prefer the aesthetics of just \"0.22\" for the version string if it's a tagged release with no additional changes - does that work?\r\n\r\nYes! That's the default versioneer behaviour.\r\n\r\n> I'd like to continue to provide a tuple that can be imported from the version.py module as well, as seen here:\r\n\r\nShould work now, it can be a two (for a tagged version), three or four items tuple.\r\n\r\n```\r\nIn [2]: datasette.__version__\r\nOut[2]: '0.12+292.ga70c2a8.dirty'\r\n\r\nIn [3]: datasette.__version_info__\r\nOut[3]: ('0', '12+292', 'ga70c2a8', 'dirty')\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}