{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391355030", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391355030, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTM1NTAzMA==", "user": {"value": 565628, "label": "r4vi"}, "created_at": "2018-05-23T13:53:27Z", "updated_at": "2018-05-23T15:22:45Z", "author_association": "CONTRIBUTOR", "body": "No objections;\r\nIt's good to go @simonw\r\n\r\nOn Wed, 23 May 2018, 14:51 Simon Willison, <notifications@github.com> wrote:\r\n\r\n> @r4vi <https://github.com/r4vi> any objections to me merging this?\r\n>\r\n> \u2014\r\n> You are receiving this because you were mentioned.\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/simonw/datasette/pull/280#issuecomment-391354237>, or mute\r\n> the thread\r\n> <https://github.com/notifications/unsubscribe-auth/AAihfM_2DN5WR2mkO-VK6ozDmkUQ4IMjks5t1WlcgaJpZM4UI_2m>\r\n> .\r\n>\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391290271", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391290271, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTI5MDI3MQ==", "user": {"value": 565628, "label": "r4vi"}, "created_at": "2018-05-23T09:53:38Z", "updated_at": "2018-05-23T09:53:38Z", "author_association": "CONTRIBUTOR", "body": "Running:\r\n```bash\r\ndocker run -p 8001:8001 -v `pwd`:/mnt datasette \\\r\n    datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db \\\r\n        --load-extension=/usr/local/lib/mod_spatialite.so\r\n```\r\n\r\nis now returning FTS5 enabled in the versions output:\r\n\r\n```json\r\n{\r\n    \"datasette\": {\r\n        \"version\": \"0.22\"\r\n    },\r\n    \"python\": {\r\n        \"full\": \"3.6.5 (default, May  5 2018, 03:07:21) \\n[GCC 6.3.0 20170516]\",\r\n        \"version\": \"3.6.5\"\r\n    },\r\n    \"sqlite\": {\r\n        \"extensions\": {\r\n            \"json1\": null,\r\n            \"spatialite\": \"4.4.0-RC0\"\r\n        },\r\n        \"fts_versions\": [\r\n            \"FTS5\",\r\n            \"FTS4\",\r\n            \"FTS3\"\r\n        ],\r\n        \"version\": \"3.23.1\"\r\n    }\r\n}\r\n```\r\nThe old query didn't work because specifying `(t TEXT)` caused an error", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391141391", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391141391, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTE0MTM5MQ==", "user": {"value": 565628, "label": "r4vi"}, "created_at": "2018-05-22T21:08:39Z", "updated_at": "2018-05-22T21:08:39Z", "author_association": "CONTRIBUTOR", "body": "I'm going to clean this up for consistency tomorrow morning so hold off\nmerging until then please\n\nOn Tue, May 22, 2018 at 6:34 PM, Simon Willison <notifications@github.com>\nwrote:\n\n> Yeah let's try this without pysqlite3 and see if we still get the correct\n> version.\n>\n> \u2014\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/simonw/datasette/pull/280#issuecomment-391076458>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAihfMI-H6CBt-Py0xdBbH2xDK0KsjT2ks5t1EwYgaJpZM4UI_2m>\n> .\n>\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391059008", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391059008, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA1OTAwOA==", "user": {"value": 565628, "label": "r4vi"}, "created_at": "2018-05-22T16:40:27Z", "updated_at": "2018-05-22T16:40:27Z", "author_association": "CONTRIBUTOR", "body": "```python\r\n>>> import sqlite3\r\n>>> sqlite3.sqlite_version\r\n'3.23.1'\r\n>>> \r\n```\r\nrunning the above in the container seems to show 3.23.1 too so maybe we don't need pysqlite3 at all?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}