home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1027654979

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1618#issuecomment-1027654979 https://api.github.com/repos/simonw/datasette/issues/1618 1027654979 IC_kwDOBm6k_c49QMVD 9599 2022-02-02T07:25:22Z 2022-02-02T07:25:22Z OWNER

But... I just noticed something I had missed in the docs for https://www.sqlite.org/pragma.html#pragfunc

Table-valued functions exist only for PRAGMAs that return results and that have no side-effects.

So it's possible I'm being overly paranoid here after all: what I want to block here is people running things like PRAGMA case_sensitive_like = 1 which could affect the global state for that connection and cause unexpected behaviour later on.

So maybe I should allow all pragma functions. I previously allowed an allow-list of them in: - #761

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1121121305  
Powered by Datasette · Queries took 1.06ms · About: github-to-sqlite