issue_comments: 1032050489

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1632#issuecomment-1032050489 https://api.github.com/repos/simonw/datasette/issues/1632 1032050489 IC_kwDOBm6k_c49g9c5 9599 2022-02-07T23:39:11Z 2022-02-07T23:42:08Z OWNER

That implementation broke on Python 3.6 - which is still a supported Python version for the 0.60.x branch - test_homepage failed.

```

  assert (
        "2 rows in 1 table, 5 rows in 4 hidden tables, 1 view" == counts_p.text.strip()
    )

E AssertionError: assert '2 rows in 1 ...ables, 1 view' == '1 table, 4 h...ables, 1 view' E - 1 table, 4 hidden tables, 1 view E + 2 rows in 1 table, 5 rows in 4 hidden tables, 1 view E ? ++++++++++ ++++++++++ ``` That's because this idiom isn't guaranteed to preserve order in versions earlier than Python 3.7:

https://github.com/simonw/datasette/blob/fa5fc327adbbf70656ac533912f3fc0526a3873d/datasette/cli.py#L552-L553

I could say that 0.60.2 is the first version to require Python 3.7 - but that feels a little surprising.

I'm going to use a different idiom for order-preserving de-duplication from this StackOverflow instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1126604194