home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1106908642

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1715#issuecomment-1106908642 https://api.github.com/repos/simonw/datasette/issues/1715 1106908642 IC_kwDOBm6k_c5B-hXi 9599 2022-04-22T21:47:55Z 2022-04-22T21:47:55Z OWNER

I need a asyncio.Registry with functions registered to perform the role of the table view.

Something like this perhaps: python def table_html_context(facet_results, query, datasette, rows): return {...} That then gets called like this: python async def view(request): registry = Registry(facet_results, query, datasette, rows) context = await registry.resolve(table_html, request=request, datasette=datasette) return Reponse.html(await datasette.render("table.html", context) It's also interesting to start thinking about this from a Python client library point of view. If I'm writing code outside of the HTTP request cycle, what would it look like?

One thing I could do: break out is the code that turns a request into a list of pairs extracted from the request - this code here: https://github.com/simonw/datasette/blob/8338c66a57502ef27c3d7afb2527fbc0663b2570/datasette/views/table.py#L442-L449

I could turn that into a typed dependency injection function like this:

python def filter_args(request: Request) -> List[Tuple[str, str]]: # Arguments that start with _ and don't contain a __ are # special - things like ?_search= - and should not be # treated as filters. filter_args = [] for key in request.args: if not (key.startswith("_") and "__" not in key): for v in request.args.getlist(key): filter_args.append((key, v)) return filter_args Then I can either pass a request into a .resolve() call, or I can instead skip that function by passing:

python output = registry.resolve(table_context, filter_args=[("foo", "bar")]) I do need to think about where plugins get executed in all of this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1212823665  
Powered by Datasette · Queries took 0.87ms · About: github-to-sqlite