home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1107863924

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1718#issuecomment-1107863924 https://api.github.com/repos/simonw/datasette/issues/1718 1107863924 IC_kwDOBm6k_c5CCKl0 9599 2022-04-24T15:30:03Z 2022-04-24T15:30:03Z OWNER

On the one hand, I'm not crazy about some of the indentation decisions Black made here - in particular this one, which I had indented deliberately for readability: `diff diff --git a/docs/authentication.rst b/docs/authentication.rst index 0d98cf8..8008023 100644 --- a/docs/authentication.rst +++ b/docs/authentication.rst @@ -381,11 +381,7 @@ Authentication plugins can set signedds_actor`` cookies themselves like so: .. code-block:: python

 response = Response.redirect("/")
  • response.set_cookie("ds_actor", datasette.sign({
  • "a": {
  • "id": "cleopaws"
  • }
  • }, "actor"))
  • response.set_cookie("ds_actor", datasette.sign({"a": {"id": "cleopaws"}}, "actor")) ``` But... consistency is a virtue. Maybe I'm OK with just this one disagreement?

Also: I've been mentally trying to keep the line lengths a bit shorter to help them be more readable on mobile devices.

I'll try a different line length using blacken-docs -l 60 docs/*.rst instead.

I like this more - here's the result for that example: `diff diff --git a/docs/authentication.rst b/docs/authentication.rst index 0d98cf8..2496073 100644 --- a/docs/authentication.rst +++ b/docs/authentication.rst @@ -381,11 +381,10 @@ Authentication plugins can set signedds_actor`` cookies themselves like so: .. code-block:: python

 response = Response.redirect("/")
  • response.set_cookie("ds_actor", datasette.sign({
  • "a": {
  • "id": "cleopaws"
  • }
  • }, "actor"))
  • response.set_cookie(
  • "ds_actor",
  • datasette.sign({"a": {"id": "cleopaws"}}, "actor"),
  • ) ```
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1213683988  
Powered by Datasette · Queries took 1.103ms · About: github-to-sqlite