home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1110246593

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1715#issuecomment-1110246593 https://api.github.com/repos/simonw/datasette/issues/1715 1110246593 IC_kwDOBm6k_c5CLQTB 9599 2022-04-26T21:03:56Z 2022-04-26T21:03:56Z OWNER

Well this is fun... I applied this change:

```diff diff --git a/datasette/views/table.py b/datasette/views/table.py index d66adb8..85f9e44 100644 --- a/datasette/views/table.py +++ b/datasette/views/table.py @@ -1,3 +1,4 @@ +import asyncio import itertools import json

@@ -5,6 +6,7 @@ import markupsafe

from datasette.plugins import pm from datasette.database import QueryInterrupted +from datasette import tracer from datasette.utils import ( await_me_maybe, CustomRow, @@ -174,8 +176,11 @@ class TableView(DataView): write=bool(canned_query.get("write")), )

  • is_view = bool(await db.get_view_definition(table_name))
  • table_exists = bool(await db.table_exists(table_name))
  • with tracer.trace_child_tasks():
  • is_view, table_exists = map(bool, await asyncio.gather(
  • db.get_view_definition(table_name),
  • db.table_exists(table_name)
  • ))
     # If table or view not found, return 404
     if not is_view and not table_exists:
    

    ``` And now using https://datasette.io/plugins/datasette-pretty-traces I get this:

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1212823665  
Powered by Datasette · Queries took 2.133ms · About: github-to-sqlite